From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v2 18/18] doc: remove devargs deprecation
	notices
Date: Fri, 22 Dec 2017 10:29:14 +0530
Message-ID: <cffdbe8c-9629-0733-b5e5-63bb71fdb028@nxp.com>
References: <cover.1503676587.git.gaetan.rivet@6wind.com>
 <cover.1507796100.git.gaetan.rivet@6wind.com>
 <c500984327843ad210a7356686288af8f8f5c483.1507796100.git.gaetan.rivet@6wind.com>
 <3930fcee-7ff6-c6f9-273b-14c16bef6ab1@nxp.com>
 <20171213102552.nmrf73y7yvzexkz7@bidouze.vm.6wind.com>
 <VI1PR0401MB246445F4DEF6E22319007FC390350@VI1PR0401MB2464.eurprd04.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0046.outbound.protection.outlook.com [104.47.36.46])
 by dpdk.org (Postfix) with ESMTP id 8B6641B27F
 for <dev@dpdk.org>; Fri, 22 Dec 2017 05:45:19 +0100 (CET)
In-Reply-To: <VI1PR0401MB246445F4DEF6E22319007FC390350@VI1PR0401MB2464.eurprd04.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Gaetan,

On Wednesday 13 December 2017 04:24 PM, Shreyansh Jain wrote:
> Hello Gaetan,
> 
>> -----Original Message-----
>> From: Gaëtan Rivet [mailto:gaetan.rivet@6wind.com]
>> Sent: Wednesday, December 13, 2017 3:56 PM
>> To: Shreyansh Jain <shreyansh.jain@nxp.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [PATCH v2 18/18] doc: remove devargs deprecation notices
>>

[...]

>   
> While reading through the code, I also had the same feeling - there can be corner cases in the parsing functions which I can't imagine. Anyways, those need to be runtime-verified - static reviews may not suffice.
> 
>>
>> I would certainly appreciate if you are able to fix the pci / vdev
>> limitation in rte_eal_dev_attach, as I am starting to be overwhelmed
>> with work (trying to finish a lot of things before the holidays).
>   
> OK.
> Once you give the devargs a push, I will start work on the PCI removal from rte_eal_dev_attach. Before that, I just want to be sure of devargs with non-PCI bus (non hotplug case).
> 
> And, thanks for tons of work you are handling. I saw the patches and really appreciate how you have split things up in sequential manner per-patch. It is difficult.

Have you pushed the new version of the devargs patches?
Just wanted to check in case I have missed it.

-
Shreyansh