All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Dave Huseby" <dwh@linuxprogrammer.org>,
	"Lars Schneider" <larsxschneider@gmail.com>,
	"Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
	"Felipe Contreras" <felipe.contreras@gmail.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v2 0/3] SubmittingPatches: a few unrelated minor fixes
Date: Mon,  7 Jun 2021 13:03:40 +0200	[thread overview]
Message-ID: <cover-0.3-0000000000-20210607T110044Z-avarab@gmail.com> (raw)
In-Reply-To: <cover-0.3-0000000000-20210512T084137Z-avarab@gmail.com>

A few minor updates to SubmittingPatches spotted while paging through
it the other day (or other month, given the delay until v2).

See
https://lore.kernel.org/git/cover-0.3-0000000000-20210512T084137Z-avarab@gmail.com/
for the v1 discussion. This hopefully addresses all the outstanding
comments with it.

Ævar Arnfjörð Bjarmason (3):
  SubmittingPatches: move discussion of Signed-off-by above "send"
  SubmittingPatches: replace discussion of Travis with GitHub Actions
  SubmittingPatches: remove pine-specific hints from MUA hints

 Documentation/SubmittingPatches | 256 ++++++++++++--------------------
 1 file changed, 97 insertions(+), 159 deletions(-)

Range-diff against v1:
1:  d18a3caa07 = 1:  9fa5437bb5 SubmittingPatches: move discussion of Signed-off-by above "send"
2:  7add00cc87 ! 2:  7d5d2854e3 SubmittingPatches: replace discussion of Travis with GitHub Actions
    @@ Documentation/SubmittingPatches: the feature triggers the new behavior when it s
     -on open source projects), you can use their Travis CI integration to
     -test your changes on Linux, Mac (and hopefully soon Windows).  See
     -GitHub-Travis CI hints section for details.
    -+If you have an account at GitHub pushing to a fork of
    -+https://github.com/git/git will use their CI integration to test your
    -+changes on Linux, Mac and Windows. See the GitHub CI section for details.
    ++Pushing to a fork of https://github.com/git/git will use their CI
    ++integration to test your changes on Linux, Mac and Windows. See the
    ++GitHub CI section for details.
      
      Do not forget to update the documentation to describe the updated
      behavior and make sure that the resulting documentation set formats
    @@ Documentation/SubmittingPatches: their trees themselves.
     -source projects), you can use Travis CI to test your changes on Linux,
     -Mac (and hopefully soon Windows).  You can find a successful example
     -test build here: https://travis-ci.org/git/git/builds/120473209
    -+With an account at GitHub you can use GitHub CI to test your changes
    ++With an account at GitHub, you can use GitHub CI to test your changes
     +on Linux, Mac and Windows. See
     +https://github.com/git/git/actions/workflows/main.yml for examples of
     +recent CI runs.
    @@ Documentation/SubmittingPatches: Follow these steps for the initial setup:
     +can also download "Artifacts" which are tarred (or zipped) archives
     +with test data relevant for debugging.
     +
    -+Then fix the problem and push your fix to your Github fork. This will
    ++Then fix the problem and push your fix to your GitHub fork. This will
     +trigger a new CI build to ensure all tests pass.
      
      [[mua]]
3:  9da5bc4a0c ! 3:  a61885a198 SubmittingPatches: remove pine-specific hints from MUA hints
    @@ Metadata
      ## Commit message ##
         SubmittingPatches: remove pine-specific hints from MUA hints
     
    -    Remove the whole section about configuring pine with
    -    no-strip-whitespace-before-send.
    +    Replace the whole section about configuring pine with
    +    no-strip-whitespace-before-send with a note that users should use
    +    another MUA instead.
     
         There hasn't been a release of Pine since late 2005, in Alpine the
         no-strip-whitespace-before-send switch is already the default.
     
         This documentation was initially added in 9740d289ee7 (Update
    -    SubmittingPatches to add MUA specific notes., 2005-08-26), at this
    +    SubmittingPatches to add MUA specific notes., 2005-08-26). At this
         point it's safe to say that it's not useful to anyone anymore, let's
         remove it.
     
         Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
     
      ## Documentation/SubmittingPatches ##
    -@@ Documentation/SubmittingPatches: first patch.\n", if you really want to put in the patch e-mail,
    - should come after the three-dash line that signals the end of the
    - commit message.
    +@@ Documentation/SubmittingPatches: commit message.
    + 
    + === Pine
      
    --
    --=== Pine
    --
     -(Johannes Schindelin)
     -
     -....
    @@ -219,7 +219,9 @@ PICO *pm;
     -"strip-whitespace-before-send", in which case you should avoid checking
     -it.
     -....
    --
    ++Abandoned by its uptsream and has known flowed text bugs, use its
    ++successor alpine or another MUA instead.
    + 
      === Thunderbird, KMail, GMail
      
    - See the MUA-SPECIFIC HINTS section of linkgit:git-format-patch[1].
-- 
2.32.0.rc3.434.gd8aed1f08a7


  parent reply	other threads:[~2021-06-07 11:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12  8:44 [PATCH 0/3] SubmittingPatches: a few unrelated minor fixes Ævar Arnfjörð Bjarmason
2021-05-12  8:45 ` [PATCH 1/3] SubmittingPatches: move discussion of Signed-off-by above "send" Ævar Arnfjörð Bjarmason
2021-05-12  9:29   ` Felipe Contreras
2021-06-07 11:02     ` Ævar Arnfjörð Bjarmason
2021-06-07 16:16       ` Felipe Contreras
2021-05-12  8:45 ` [PATCH 2/3] SubmittingPatches: replace discussion of Travis with GitHub Actions Ævar Arnfjörð Bjarmason
2021-05-12 12:24   ` Đoàn Trần Công Danh
2021-05-12 22:40   ` Junio C Hamano
2021-05-12  8:45 ` [PATCH 3/3] SubmittingPatches: remove pine-specific hints from MUA hints Ævar Arnfjörð Bjarmason
2021-05-12 23:51   ` Dave Huseby
2021-05-13  6:38     ` Felipe Contreras
2021-05-13 14:45       ` Dave Huseby
2021-05-13 20:08         ` Felipe Contreras
2021-05-17 19:05           ` Dave Huseby
2021-05-13  7:50     ` Ævar Arnfjörð Bjarmason
2021-05-13 14:42       ` Dave Huseby
2021-06-07 11:03 ` Ævar Arnfjörð Bjarmason [this message]
2021-06-07 11:03   ` [PATCH v2 1/3] SubmittingPatches: move discussion of Signed-off-by above "send" Ævar Arnfjörð Bjarmason
2021-06-07 15:58     ` Đoàn Trần Công Danh
2021-06-07 11:03   ` [PATCH v2 2/3] SubmittingPatches: replace discussion of Travis with GitHub Actions Ævar Arnfjörð Bjarmason
2021-06-07 17:25     ` SZEDER Gábor
2021-06-07 11:03   ` [PATCH v2 3/3] SubmittingPatches: remove pine-specific hints from MUA hints Ævar Arnfjörð Bjarmason
2021-06-07 21:49     ` Johannes Schindelin
2021-06-08  3:50   ` [PATCH v2 0/3] SubmittingPatches: a few unrelated minor fixes Junio C Hamano
2021-07-22 12:11   ` [PATCH v3 0/2] SubmittingPatches: talk about GitHub CI, not Travis + move-only Ævar Arnfjörð Bjarmason
2021-07-22 12:11     ` [PATCH v3 1/2] SubmittingPatches: move discussion of Signed-off-by above "send" Ævar Arnfjörð Bjarmason
2021-07-23  6:36       ` Bagas Sanjaya
2021-07-22 12:11     ` [PATCH v3 2/2] SubmittingPatches: replace discussion of Travis with GitHub Actions Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover-0.3-0000000000-20210607T110044Z-avarab@gmail.com \
    --to=avarab@gmail.com \
    --cc=congdanhqx@gmail.com \
    --cc=dwh@linuxprogrammer.org \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=larsxschneider@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.