From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MmCak-0003LA-Lj for qemu-devel@nongnu.org; Fri, 11 Sep 2009 16:19:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MmCaf-0003Gd-9I for qemu-devel@nongnu.org; Fri, 11 Sep 2009 16:19:33 -0400 Received: from [199.232.76.173] (port=34680 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmCae-0003GW-Vr for qemu-devel@nongnu.org; Fri, 11 Sep 2009 16:19:29 -0400 Received: from oxygen.pond.sub.org ([213.239.205.148]:41816) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MmCae-0005rs-AQ for qemu-devel@nongnu.org; Fri, 11 Sep 2009 16:19:28 -0400 Received: from pike.pond.sub.org (pD9E39C1E.dip.t-dialin.net [217.227.156.30]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 070BF276D4B for ; Fri, 11 Sep 2009 22:19:27 +0200 (CEST) From: Markus Armbruster Date: Fri, 11 Sep 2009 22:19:15 +0200 Message-Id: Subject: [Qemu-devel] [PATCH 0/6] Clean up use of qdev_init() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org qdev_init() can fail since commit 81a322d4. Most callers don't bother to check. This is less serious than it sounds, because they typically work with devices for which qdev_init() never fails. It's still unclean. The last patch makes the compiler warn when the value of qdev_init() isn't used. If that warning triggers after merging this series, more unchecked calls have crept in since the base of this series (commit 2637c754). Feel free to ask me for a respin then. Markus Armbruster (6): Move function definitions out of xilinx.h Make qdev_init() destroy the device on failure Check return value of qdev_init() New qdev_init_nofail() Make isa_create() terminate program on failure Warn if value of qdev_init() isn't checked hw/apb_pci.c | 2 +- hw/arm_sysctl.c | 2 +- hw/armv7m.c | 6 ++-- hw/axis_dev88.c | 2 +- hw/escc.c | 4 +- hw/esp.c | 2 +- hw/etraxfs.c | 2 +- hw/fdc.c | 4 +- hw/grackle_pci.c | 2 +- hw/i2c.c | 2 +- hw/integratorcp.c | 2 +- hw/isa-bus.c | 11 +++------ hw/m48t59.c | 2 +- hw/mc146818rtc.c | 2 +- hw/mips_malta.c | 2 +- hw/musicpal.c | 4 +- hw/ne2000-isa.c | 2 +- hw/pc.c | 2 +- hw/pci-hotplug.c | 4 +- hw/pci.c | 9 ++++--- hw/piix_pci.c | 2 +- hw/qdev.c | 26 +++++++++++++++++++--- hw/qdev.h | 3 +- hw/scsi-bus.c | 4 ++- hw/smc91c111.c | 2 +- hw/ssi.c | 2 +- hw/stellaris.c | 2 +- hw/sun4m.c | 28 ++++++++++++------------ hw/sun4u.c | 4 +- hw/syborg.c | 4 +- hw/sysbus.c | 2 +- hw/unin_pci.c | 2 +- hw/usb-bus.c | 2 +- hw/usb-msd.c | 3 +- hw/vga-pci.c | 2 +- hw/xilinx.h | 58 ++++++++------------------------------------------ hw/xilinx_ethlite.c | 19 ++++++++++++++++ hw/xilinx_intc.c | 14 ++++++++++++ hw/xilinx_timer.c | 15 +++++++++++++ usb-linux.c | 4 +- 40 files changed, 148 insertions(+), 118 deletions(-)