From: Joshua Lock <josh@linux.intel.com>
To: bitbake-devel@lists.openembedded.org
Subject: [RFC PATCH 0/1] Don't use set() for datastore variables
Date: Wed, 7 Sep 2011 14:27:00 -0700 [thread overview]
Message-ID: <cover.1315406971.git.josh@linux.intel.com> (raw)
This is an RFC patch.
I recently implemented a check within the hob gui to ensure that it's running with the
required pre and post configuration files. However this check uses a variable from the data
store which is a Python set container.
The Python xmlrpclib is unable to marshal sets and therefore the patch I added breaks hob
when using the xmlrpc server backend.
I've assumed that storing variables in the datastore that cannot be accessed using the
getVariable API with each of our servers is a bad thing and the attached patch changes the
use of set to a dict.
There are, of course, alternative workarounds for this issue. For example, we could create a
new variable to list file dependencies, but that seems a little wasteful? Or we could add
some logic to the xmlrpc server to ensure it doesn't try and marshal unsupported types?
Comments?
Regards,
Joshua
The following changes since commit 24272dae15ccf641ece11ef5a6e2bfa3ebb6f5f9:
lib/bb/siggen.py: return a string from noop get_taskhash (2011-09-05 20:16:08 +0100)
are available in the git repository at:
git://github.com/incandescant/bitbake hob
https://github.com/incandescant/bitbake/tree/hob
Joshua Lock (1):
cache|cooker|parse: switch __depends from a set to a dict
lib/bb/cache.py | 11 ++++++-----
lib/bb/cooker.py | 8 ++++----
lib/bb/parse/__init__.py | 4 ++--
lib/bb/ui/hob.py | 8 ++++----
4 files changed, 16 insertions(+), 15 deletions(-)
--
1.7.6
next reply other threads:[~2011-09-07 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 21:27 Joshua Lock [this message]
2011-09-07 21:27 ` [PATCH 1/1] cache|cooker|parse: switch __depends from a set to a dict Joshua Lock
2011-09-12 20:42 ` [RFC PATCH 0/1] Don't use set() for datastore variables Joshua Lock
2011-09-13 12:55 ` Bernhard Reutner-Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1315406971.git.josh@linux.intel.com \
--to=josh@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.