From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752030AbaIMKj2 (ORCPT ); Sat, 13 Sep 2014 06:39:28 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:14095 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148AbaIMKjV (ORCPT ); Sat, 13 Sep 2014 06:39:21 -0400 From: Yann Droneaud To: linux-kernel@vger.kernel.org Cc: Yann Droneaud , Adrian Hunter , David Ahern , Frederic Weisbecker , Jiri Olsa , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Stephane Eranian , William Cohen Subject: [PATCH 0/2] perf tool: improve error handling in perf_flag_probe() Date: Sat, 13 Sep 2014 10:46:22 +0200 Message-Id: X-Mailer: git-send-email 1.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Following the EBUSY errors reported by Jiri Olsa [1], I've tryed to improve a bit the way perf_flag_probe() handle errors. In case EBUSY is returned by perf_event_open(), testing the function again without PERF_FLAG_FD_CLOEXEC is meaningless: EBUSY is not related to close-on-exec flag, so there's nothing to confirm. For other errors, not yet handled by perf_flag_probe(), it's pointless to report a second error message for the same error code: the second check should not print an error if the error is the same as the one return for the first check. [1] http://lkml.kernel.org/r/1406908014-8312-1-git-send-email-jolsa@kernel.org Yann Droneaud (2): perf tools: shortcut PERF_FLAG_FD_CLOEXEC probing in case of EBUSY error perf tools: report PERF_FLAG_FD_CLOEXEC probing error once tools/perf/util/cloexec.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) Cc: Adrian Hunter Cc: David Ahern Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Stephane Eranian Cc: William Cohen -- 1.9.3