From: Lukas Wunner <lukas@wunner.de>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v6 0/4] fbdev deadlock & failure path fixes
Date: Sun, 25 Oct 2015 12:14:53 +0100 [thread overview]
Message-ID: <cover.1445771693.git.lukas@wunner.de> (raw)
In-Reply-To: <20151015173423.GK26517@intel.com>
Next iteration of these fixes, taking into account the additional
issues discovered in the recent exchange with Ville (this series
is in-reply-to that thread):
* Patch 1 now with Reviewed-by tag by Ville (thanks!), moved to the
front of the series.
* Patch 2 is new, fixes a double unref of the bo in a failure path
of intelfb_alloc, spotted by Ville.
* Patch 3 is another attempt to eliminate the deadlocks in
intelfb_alloc and intelfb_create, patch originally by Tvrtko.
New in v6: Avoid unrefing the fb if it's an ERR_PTR,
replace drm_framebuffer_remove with drm_framebuffer_unreference
(Daniel).
* Patch 4 is new, plugs leak of a struct intel_fbdev in
intelfb_create. Not sure if I made the right call in the case
where the fb was inherited from BIOS, comments welcome.
(I decided to leave the fb as is and limp on. Alternative would
be to call drm_framebuffer_remove to free the memory occupied
by the fb and disable the crtc; the fbcon will be unusable anyway
at this point and if X11 is able to start up without errors,
it should be able to reinitialize the crtc.)
Browsable on GitHub:
https://github.com/l1k/linux/commits/intel_fbdev_fixes
Lukas Wunner (3):
drm/i915: On fb alloc failure, unref gem object where it gets refed
drm/i915: Fix double unref in intelfb_alloc failure path
drm/i915: Fix error handling in intelfb_create
Tvrtko Ursulin (1):
drm/i915: Fix failure paths around initial fbdev allocation
drivers/gpu/drm/i915/intel_display.c | 21 +++++++++++++-------
drivers/gpu/drm/i915/intel_fbdev.c | 38 +++++++++++++++++++++++-------------
2 files changed, 38 insertions(+), 21 deletions(-)
--
1.8.5.2 (Apple Git-48)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-25 13:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 9:06 [PATCH v5 1/2] drm/i915: Fix failure paths around initial fbdev allocation Lukas Wunner
2015-07-04 9:50 ` [PATCH v5 2/2] drm/i915: On fb alloc failure, unref gem object where it gets refed Lukas Wunner
2015-10-13 15:39 ` Ville Syrjälä
2015-10-13 15:04 ` [PATCH v5 1/2] drm/i915: Fix failure paths around initial fbdev allocation Ville Syrjälä
2015-10-14 9:35 ` Chris Wilson
2015-10-15 17:14 ` Lukas Wunner
2015-10-15 17:22 ` Daniel Vetter
2015-10-15 17:34 ` Ville Syrjälä
2015-10-18 18:03 ` Lukas Wunner
2015-10-25 11:14 ` Lukas Wunner [this message]
2015-06-30 9:06 ` [PATCH v6 3/4] " Lukas Wunner
2015-10-30 18:28 ` Daniel Vetter
2015-11-07 10:41 ` [PATCH v7 0/3] fbdev fixes (reviewed) Lukas Wunner
2015-06-30 9:06 ` [PATCH v7 3/3] drm/i915: Fix failure paths around initial fbdev allocation Lukas Wunner
2015-07-04 9:50 ` [PATCH v7 1/3] drm/i915: On fb alloc failure, unref gem object where it gets refed Lukas Wunner
2015-10-22 11:37 ` [PATCH v7 2/3] drm/i915: Fix double unref in intelfb_alloc failure path Lukas Wunner
2015-11-09 14:23 ` [PATCH v7 0/3] fbdev fixes (reviewed) Jani Nikula
2015-11-12 19:20 ` Lukas Wunner
2015-11-13 7:06 ` Jani Nikula
2015-11-17 13:44 ` Daniel Vetter
2015-07-04 9:50 ` [PATCH v6 1/4] drm/i915: On fb alloc failure, unref gem object where it gets refed Lukas Wunner
2015-10-22 11:37 ` [PATCH v6 2/4] drm/i915: Fix double unref in intelfb_alloc failure path Lukas Wunner
2015-10-30 18:17 ` Daniel Vetter
2015-10-23 22:27 ` [PATCH v6 4/4] drm/i915: Fix error handling in intelfb_create Lukas Wunner
2015-10-30 18:23 ` Daniel Vetter
2015-11-08 12:56 ` [PATCH v2 0/2] fbdev fixes (need review) Lukas Wunner
2015-11-03 7:00 ` [PATCH v2 2/2] drm/i915: Tear down fbdev if initialization fails Lukas Wunner
2015-11-05 9:42 ` [PATCH v2 1/2] drm/i915: Fix oops caused by fbdev initialization failure Lukas Wunner
2015-11-17 13:51 ` [PATCH v2 0/2] fbdev fixes (need review) Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1445771693.git.lukas@wunner.de \
--to=lukas@wunner.de \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.