All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v5 0/7] #11662 - wic should mount /boot
Date: Fri, 28 Jul 2017 12:29:21 +0300	[thread overview]
Message-ID: <cover.1501233796.git.ed.bartosh@linux.intel.com> (raw)

Hi,

This patchset adds /boot to the /etc/fstab of root partition, making
it mounted on boot. It also fixes reporting and testing issues
caused by this change.

The patchset also fixes long standing bug: wic updated fstab
inplace in rootfs directory. This causes other tasks working with
rootfs directory to produce incorrect results or crash. This is
fixed by hadlinking rootfs content to the temporary directory before
updating fstab.

This approach caused do_image_tar to fail with the error "file changed as we read it"
as hardlinking changes files ctime. In order to solve this we had to
modify do_image_tar to ignore file changes.

Changes in v2: squashed patches by reviewer's request
Changes in v3: unlink /etc/fstab in rootfs copy before updating it
Changes in v4: used 'cp -a' instead of copyhardlinktree to avoid
               do_image_tar failure due to changed ctime
Changes in v5: back to hardlinking. ignored tar exit code 1.

The following changes since commit b73f5e088a543775a2a94b60302f750edfffbd10:

  wic-tools: add dependency to e2fsprogs-native (2017-07-27 16:07:26 +0300)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib ed/wip
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wip

Ed Bartosh (7):
  image_types.bbclass: ignore tar exit code 1
  wic: copy rootfs directory before changing fstab
  wic: use absolute paths in rootfs plugin
  wic: rootfs: fix rootfs path reporting
  wic: rootfs: make copied rootfs unique
  wic: add /boot mount point to fstab by default
  oe-selftest: wic: fix test_quemu

 meta/classes/image_types.bbclass         |  3 ++-
 meta/lib/oeqa/selftest/cases/wic.py      |  2 +-
 scripts/lib/wic/plugins/imager/direct.py | 26 ++++++++++++++++----------
 scripts/lib/wic/plugins/source/rootfs.py | 16 +++++++---------
 4 files changed, 26 insertions(+), 21 deletions(-)

-- 
2.1.4



             reply	other threads:[~2017-07-28  9:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28  9:29 Ed Bartosh [this message]
2017-07-28  9:29 ` [PATCH v5 1/7] image_types.bbclass: ignore tar exit code 1 Ed Bartosh
2017-07-28  9:29 ` [PATCH v5 2/7] wic: copy rootfs directory before changing fstab Ed Bartosh
2017-07-28  9:29 ` [PATCH v5 3/7] wic: use absolute paths in rootfs plugin Ed Bartosh
2017-07-28  9:29 ` [PATCH v5 4/7] wic: rootfs: fix rootfs path reporting Ed Bartosh
2017-07-28  9:29 ` [PATCH v5 5/7] wic: rootfs: make copied rootfs unique Ed Bartosh
2017-07-28  9:29 ` [PATCH v5 6/7] wic: add /boot mount point to fstab by default Ed Bartosh
2017-07-28  9:29 ` [PATCH v5 7/7] oe-selftest: wic: fix test_quemu Ed Bartosh
2017-07-29  7:40 ` [PATCH v5 0/7] #11662 - wic should mount /boot Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1501233796.git.ed.bartosh@linux.intel.com \
    --to=ed.bartosh@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.