From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936725AbdJQQRh (ORCPT ); Tue, 17 Oct 2017 12:17:37 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:55902 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934114AbdJQQRg (ORCPT ); Tue, 17 Oct 2017 12:17:36 -0400 X-Google-Smtp-Source: ABhQp+QB2yp5HIPmV3tNfY74tKRVU3tw6KNKc4X14488fJNGcNK/9p23BKMekA1hNvf5mDyLdrfxwg== Date: Tue, 17 Oct 2017 18:17:26 +0200 From: Guillaume =?utf-8?Q?Dou=C3=A9zan-Grard?= To: Darren Hart Cc: Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/4] Topstar ACPI LED Workaround Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Darren, On Topstar U931 Notebooks, an issue prevents the WLAN toggle key from being properly managed by the Embedded Controller and successfully disconnect the adapter. A specific ACPI method allows to toggle the WLAN LED state regardless. These are barebone laptops, sold under quite a lot of brands and configurations, with different firmwares and so on. I can only say for sure that this issue is present for all the models sold under a specific brand, that's why I'm reluctant to enable this by default with a DMI check. Thus, the new `led_workaround` option registers this LED with the corresponding subsystem, making possible to use a software-based trigger (rfkill for instance to synchronize the LED with the softkill state). Thank you for your time, -- Guillaume Douézan-Grard Guillaume Douézan-Grard (4): platform/x86: topstar-laptop: non-functional changes platform/x86: topstar-laptop: change to generic module platform/x86: topstar-laptop: add platform device platform/x86: topstar-laptop: add optional WLAN LED workaround drivers/platform/x86/Kconfig | 2 + drivers/platform/x86/topstar-laptop.c | 339 ++++++++++++++++++++++++++-------- 2 files changed, 267 insertions(+), 74 deletions(-) -- 2.14.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guillaume =?utf-8?Q?Dou=C3=A9zan-Grard?= Subject: [PATCH 0/4] Topstar ACPI LED Workaround Date: Tue, 17 Oct 2017 18:17:26 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wr0-f194.google.com ([209.85.128.194]:55902 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934114AbdJQQRg (ORCPT ); Tue, 17 Oct 2017 12:17:36 -0400 Content-Disposition: inline Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Darren Hart Cc: Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Hi Darren, On Topstar U931 Notebooks, an issue prevents the WLAN toggle key from being properly managed by the Embedded Controller and successfully disconnect the adapter. A specific ACPI method allows to toggle the WLAN LED state regardless. These are barebone laptops, sold under quite a lot of brands and configurations, with different firmwares and so on. I can only say for sure that this issue is present for all the models sold under a specific brand, that's why I'm reluctant to enable this by default with a DMI check. Thus, the new `led_workaround` option registers this LED with the corresponding subsystem, making possible to use a software-based trigger (rfkill for instance to synchronize the LED with the softkill state). Thank you for your time,