From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jose Abreu Subject: [PATCH v3 net-next 00/12] net: stmmac: Clean-up and tune-up Date: Fri, 18 May 2018 14:55:57 +0100 Message-ID: Cc: Jose Abreu , "David S. Miller" , Joao Pinto , Vitor Soares , Giuseppe Cavallaro , Alexandre Torgue To: netdev@vger.kernel.org Return-path: Received: from smtprelay.synopsys.com ([198.182.37.59]:57776 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534AbeERN4p (ORCPT ); Fri, 18 May 2018 09:56:45 -0400 Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by smtprelay.synopsys.com (Postfix) with ESMTP id 8FE911E044E for ; Fri, 18 May 2018 15:56:43 +0200 (CEST) Sender: netdev-owner@vger.kernel.org List-ID: This targets to uniformize the handling of the different GMAC versions in stmmac_main.c file and also tune-up the HW. Currently there are some if/else conditions in the main source file which calls different callbacks depending on the ID of GMAC. With the introducion of a generic HW interface handling which automatically selects the GMAC callbacks to be used, it is now unpleasant to see if conditions in the main code because this should be completely agnostic of the GMAC version. This series removes most of these conditions. There are some if conditions that remain untouched but the callbacks handling are now uniformized. Tested in GMAC5, hope I didn't break any previous versions. Please check [1] for performance analisys of patches 3-12. --- David, This will probably generate a merge conflict with [2] (which was not merged yet). I'm waiting for Corentin input and then, if this series is merged before, I will rebase [2]. Or the other way around if you prefer :D Thanks --- Cc: David S. Miller Cc: Joao Pinto Cc: Vitor Soares Cc: Giuseppe Cavallaro Cc: Alexandre Torgue [1] https://marc.info/?l=linux-netdev&m=152656352607905&w=2 [2] https://patchwork.ozlabs.org/patch/915286/ Jose Abreu (12): net: stmmac: Enable OSP for GMAC4 net: stmmac: Do not keep rearming the coalesce timer in stmmac_xmit net: stmmac: Let descriptor code set skbuff address net: stmmac: Let descriptor code clear the descriptor net: stmmac: Uniformize the use of dma_{rx/tx}_mode callbacks net: stmmac: Remove uneeded checks for GMAC version net: stmmac: Move PTP and MMC base address calculation to hwif.c net: stmmac: Uniformize the use of dma_init_* callbacks net: stmmac: Remove uneeded check for GMAC version in stmmac_xmit net: stmmac: Uniformize set_rx_owner() net: stmmac: Let descriptor code get skbuff address net: stmmac: Remove if condition by taking advantage of hwif return code drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 82 +++++--- .../net/ethernet/stmicro/stmmac/dwmac1000_dma.c | 92 ++++++---- drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c | 35 +++-- drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 34 +++- drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c | 7 +- drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h | 1 - drivers/net/ethernet/stmicro/stmmac/enh_desc.c | 20 ++- drivers/net/ethernet/stmicro/stmmac/hwif.c | 34 ++++ drivers/net/ethernet/stmicro/stmmac/hwif.h | 27 ++- drivers/net/ethernet/stmicro/stmmac/norm_desc.c | 20 ++- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 + drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 198 +++++++------------- 12 files changed, 323 insertions(+), 228 deletions(-)