From: Jeff Cody <jcody@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, qemu-stable@nongnu.org, jsnow@redhat.com,
eblake@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/3] block/rbd: enable filename parsing on open
Date: Tue, 11 Sep 2018 16:43:49 -0400 [thread overview]
Message-ID: <cover.1536698311.git.jcody@redhat.com> (raw)
Changes from v1:
Patch 1: Don't pass unused BlockDriverState to helper function
Patch 2: Do not allow mixed usage; fail if keyvalue is present [Eric]
Add deprecation warning [John]
Pull legacy parsing code into function [John]
Fixed filename leak
Patch 3: New; iotest 231. [Eric]
iotest failure on current master:
QA output created by 231
-qemu-img: RBD options encoded in the filename as keyvalue pairs is deprecated. Future versions may cease to parse these options in the future.
-unable to get monitor info from DNS SRV with service name: ceph-mon
-no monitors specified to connect to.
-qemu-img: Could not open 'json:{'file.driver':'rbd','file.filename':'rbd:rbd/bogus:conf=BOGUS_CONF'}': error connecting: No such file or directory
+qemu-img: Could not open 'json:{'file.driver':'rbd','file.filename':'rbd:rbd/bogus:conf=BOGUS_CONF'}': Parameter 'pool' is missing
unable to get monitor info from DNS SRV with service name: ceph-mon
no monitors specified to connect to.
qemu-img: Could not open 'json:{'file.driver':'rbd','file.pool':'rbd','file.image':'bogus','file.conf':'BOGUS_CONF'}': error connecting: No such file or directory
Failures: 231
Failed 1 of 1 tests
Jeff Cody (3):
block/rbd: pull out qemu_rbd_convert_options
block/rbd: Attempt to parse legacy filenames
block/rbd: add iotest for rbd legacy keyvalue filename parsing
block/rbd.c | 89 ++++++++++++++++++++++++++++++++------
tests/qemu-iotests/231 | 62 ++++++++++++++++++++++++++
tests/qemu-iotests/231.out | 9 ++++
tests/qemu-iotests/group | 1 +
4 files changed, 147 insertions(+), 14 deletions(-)
create mode 100755 tests/qemu-iotests/231
create mode 100644 tests/qemu-iotests/231.out
--
2.17.1
next reply other threads:[~2018-09-11 20:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 20:43 Jeff Cody [this message]
2018-09-11 20:43 ` [Qemu-devel] [PATCH v2 1/3] block/rbd: pull out qemu_rbd_convert_options Jeff Cody
2018-09-11 20:43 ` [Qemu-devel] [PATCH v2 2/3] block/rbd: Attempt to parse legacy filenames Jeff Cody
2018-09-11 21:05 ` Eric Blake
2018-09-11 21:23 ` Jeff Cody
2018-09-11 20:43 ` [Qemu-devel] [PATCH v2 3/3] block/rbd: add iotest for rbd legacy keyvalue filename parsing Jeff Cody
2018-09-11 21:11 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1536698311.git.jcody@redhat.com \
--to=jcody@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.