From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96170C433DF for ; Sat, 13 Jun 2020 11:32:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6918F207DD for ; Sat, 13 Jun 2020 11:32:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=earth.li header.i=@earth.li header.b="IpELI3Ff" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726132AbgFMLbm (ORCPT ); Sat, 13 Jun 2020 07:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725857AbgFMLbh (ORCPT ); Sat, 13 Jun 2020 07:31:37 -0400 Received: from the.earth.li (the.earth.li [IPv6:2a00:1098:86:4d:c0ff:ee:15:900d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DE0EC03E96F; Sat, 13 Jun 2020 04:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=earth.li; s=the; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject :Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2i9hfgGNeitd7hYzWmJeqbpBgVgM1F/BZAahxCgFTeY=; b=IpELI3FfbNtHLseeTGv6y2epuB +iUSCoO2Q4VtWg0Miqfi06FN5SFybtWDv5YW+EJy21EsHhWEB6psWCLuOLZWr5cYIahHvNdIQqDHH IL9UkvoYT4EW6c6EVMP/dKsyJ6qwjYp4/Hib5wUf09Fia9IigX2QW9FkPkqhZmp7m532nJDzGDkZD 3sFO3MAQNGnkCjG57O4LQwE4IEq5tNMKbVnVupjHhKMh0UnrAqxdrz8IDd3uMX8tIaC3w+67lJ9y/ DFg0WzFQ4I7JdSCsSLTGLpInMrF6idgMjtVrWijgYlIEMfeFRaB3AXwnBDt7x2qaiJKrwHC9JAfzU uEZzu1hA==; Received: from noodles by the.earth.li with local (Exim 4.92) (envelope-from ) id 1jk4Nk-0000Zr-LO; Sat, 13 Jun 2020 12:31:28 +0100 Date: Sat, 13 Jun 2020 12:31:28 +0100 From: Jonathan McDowell To: Russell King - ARM Linux admin Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v4 0/2] net: dsa: qca8k: Improve SGMII interface handling Message-ID: References: <8ddd76e484e1bedd12c87ea0810826b60e004a65.1591380105.git.noodles@earth.li> <20200605183843.GB1006885@lunn.ch> <20200606074916.GM311@earth.li> <20200606083741.GK1551@shell.armlinux.org.uk> <20200606105909.GN311@earth.li> <20200608183953.GR311@earth.li> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hopefully getting there, thanks for all the review comments. This 2 patch series migrates the qca8k switch driver over to PHYLINK, and then adds the SGMII clean-ups (i.e. the missing initialisation) on top of that as a second patch. As before, tested with a device where the CPU connection is RGMII (i.e. the common current use case) + one where the CPU connection is SGMII. I don't have any devices where the SGMII interface is brought out to something other than the CPU. v4: - Enable pcs_poll so we keep phylink updated when doing in-band negotiation - Explicitly check for PHY_INTERFACE_MODE_1000BASEX when setting SGMII port mode. - Address Vladimir's review comments v3: - Move phylink changes to separate patch - Address rmk review comments v2: - Switch to phylink - Avoid need for device tree configuration options Jonathan McDowell (2): net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB net: dsa: qca8k: Improve SGMII interface handling drivers/net/dsa/qca8k.c | 341 ++++++++++++++++++++++++++++------------ drivers/net/dsa/qca8k.h | 13 ++ 2 files changed, 256 insertions(+), 98 deletions(-) -- 2.20.1