All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni at redhat.com>
To: mptcp at lists.01.org
Subject: [MPTCP] [PATCH mptcp-next 0/3] mptcp: re-enable snd buf autotune
Date: Fri, 08 Jan 2021 12:50:00 +0100	[thread overview]
Message-ID: <cover.1610106588.git.pabeni@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

It was lost in a recent refactor.

With great power come great responsability, so we need a more
accurate packet scheduler decision, or b/w usage for assimetric links
will be sub-optimal.

Patches 2 && 3 are the minimal changes I was able to cook somehow
addressing the above 

There are still some sporadic self-test failures for assimetric links.
Looks like they are caused by retransmissions/receiver dropping packets
due to MPTCP level OoO check.

I'll try to address that asap, but I still consider this series for
inclusion, so that it can stage a bit in the export branch.

Note: patch 3 re-introduces the workqueue usage for the datapath (yes,
it makes me feel sick, sad and tired :(. I was unable to avoid it.

There is weird and convoluted schema to possibly avoiding (again) the
workqueue usage. If you don't feel too scaring using a fake NAPI instance
to delegate actions to other mptcp subflows, I can try to cook that... 

Paolo Abeni (3):
  mptcp: re-enable sndbuf autotune
  mptcp: do not queue excessive data on subflows.
  mptcp: schedule work for better snd subflow selection

 net/mptcp/protocol.c | 85 +++++++++++++++++++++++++-------------------
 net/mptcp/protocol.h | 20 +++++++++++
 net/mptcp/subflow.c  | 10 +++++-
 3 files changed, 77 insertions(+), 38 deletions(-)

-- 
2.26.2

                 reply	other threads:[~2021-01-08 11:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1610106588.git.pabeni@redhat.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.