From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6804CC4332B for ; Wed, 20 Jan 2021 16:19:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35AD5233E2 for ; Wed, 20 Jan 2021 16:19:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403771AbhATQT3 (ORCPT ); Wed, 20 Jan 2021 11:19:29 -0500 Received: from guitar.tcltek.co.il ([192.115.133.116]:55070 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391451AbhATQRk (ORCPT ); Wed, 20 Jan 2021 11:17:40 -0500 Received: from tarshish.tkos.co.il (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 6A0C444056C; Wed, 20 Jan 2021 18:16:37 +0200 (IST) From: Baruch Siach To: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Lee Jones , Linus Walleij , Bartosz Golaszewski Cc: Baruch Siach , Andrew Lunn , Gregory Clement , Russell King , Sebastian Hesselbarth , Thomas Petazzoni , Chris Packham , Sascha Hauer , Ralph Sennhauser , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 0/4] gpio: mvebu: pwm fixes and improvements Date: Wed, 20 Jan 2021 18:16:24 +0200 Message-Id: X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This series adds a few related fixes to the pwm .apply and .get_state callbacks. The first patch was originally part of the series adding Armada 8K/7K pwm support. I split it out to a separate series following review comments from Uwe Kleine-König who spotted a few more issues. There is no dependency between this and the Armada 8K/7K series. v5: * Drop a patch applied to the gpio tree * Fix patch 4/4 description typo (Uwe) * Reduce the number of multiplications (Uwe) * Add spaces around '+' (Uwe) * Use '1ULL' instead of explicit cast to reduce verbosity * Add Linus' Reviewed-by tags to patches that are unchanged since v2 v4: * Take advantage of zero value being treated as 2^32 by hardware. Rewrite patch 5/5 (Uwe). v3: * Improve patch 3/5 description (Uwe) * Add more Reviewed-by tags from Uwe v2: Address Uwe Kleine-König comments. * Improve patch 1/5 summary line * Add more information to patch 1/5 description * Add more information to patch 2/5 description * Don't round period/duty_cycle up in .apply (patch 3/5) * Expand the comment in path 5/5 based on RMK's analysis of hardware behaviour * Add Uwe's Reviewed-by tags Baruch Siach (4): gpio: mvebu: improve pwm period calculation accuracy gpio: mvebu: make pwm .get_state closer to idempotent gpio: mvebu: don't limit pwm period/duty_cycle to UINT_MAX gpio: mvebu: improve handling of pwm zero on/off values drivers/gpio/gpio-mvebu.c | 47 +++++++++++++++++++++------------------ 1 file changed, 25 insertions(+), 22 deletions(-) -- 2.29.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BB5CC433E0 for ; Wed, 20 Jan 2021 16:18:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C2B5233CE for ; Wed, 20 Jan 2021 16:18:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C2B5233CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=DJTmIpmTzLBMRfuhSx2/wx5BBMYnhspzTT6dZvRaRpg=; b=jUh18CzyMfIr9IkRyDNVKu58r0 pSSe9Q0ElWb+c70zoGIrYk8XX49UWrFeZ6WXLzf4R4UmDJf84FMrh08ATYde7Aro73u3c6Wb5Ogqs Raz9tVWH1qKnP4hEmRBK9sn/Ll33zJlRO/DMnTgx+3mh6uMcLKMX5JRq8OQ0Li6f2U2UAznKwvLva HGgmurqqySBlxPRTQ6fTAorhmBVIBYwNJzaqmRUzUsUtIc2dGooV9pnIn/zWieBLv845/s36S+6n0 YbO727oZX0eyyLbjehg7w4MTQwKEOdacm21OYF2u86wqhcmtRjrukKfarWoVm4xbEVmGgj45cHQpW OvtdC8IQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2GAE-00060a-Oz; Wed, 20 Jan 2021 16:16:58 +0000 Received: from guitar.tcltek.co.il ([192.115.133.116] helo=mx.tkos.co.il) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2GA3-0005vU-Ez for linux-arm-kernel@lists.infradead.org; Wed, 20 Jan 2021 16:16:48 +0000 Received: from tarshish.tkos.co.il (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 6A0C444056C; Wed, 20 Jan 2021 18:16:37 +0200 (IST) From: Baruch Siach To: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Lee Jones , Linus Walleij , Bartosz Golaszewski Subject: [PATCH v5 0/4] gpio: mvebu: pwm fixes and improvements Date: Wed, 20 Jan 2021 18:16:24 +0200 Message-Id: X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210120_111647_695961_14A7D89A X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Baruch Siach , linux-pwm@vger.kernel.org, Gregory Clement , Russell King , linux-gpio@vger.kernel.org, Chris Packham , Thomas Petazzoni , Ralph Sennhauser , Sascha Hauer , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhpcyBzZXJpZXMgYWRkcyBhIGZldyByZWxhdGVkIGZpeGVzIHRvIHRoZSBwd20gLmFwcGx5IGFu ZCAuZ2V0X3N0YXRlCmNhbGxiYWNrcy4KClRoZSBmaXJzdCBwYXRjaCB3YXMgb3JpZ2luYWxseSBw YXJ0IG9mIHRoZSBzZXJpZXMgYWRkaW5nIEFybWFkYSA4Sy83SyBwd20Kc3VwcG9ydC4gSSBzcGxp dCBpdCBvdXQgdG8gYSBzZXBhcmF0ZSBzZXJpZXMgZm9sbG93aW5nIHJldmlldyBjb21tZW50cyBm cm9tClV3ZSBLbGVpbmUtS8O2bmlnIHdobyBzcG90dGVkIGEgZmV3IG1vcmUgaXNzdWVzLiBUaGVy ZSBpcyBubyBkZXBlbmRlbmN5IGJldHdlZW4KdGhpcyBhbmQgdGhlIEFybWFkYSA4Sy83SyBzZXJp ZXMuCgp2NToKCiAgKiBEcm9wIGEgcGF0Y2ggYXBwbGllZCB0byB0aGUgZ3BpbyB0cmVlCgogICog Rml4IHBhdGNoIDQvNCBkZXNjcmlwdGlvbiB0eXBvIChVd2UpCgogICogUmVkdWNlIHRoZSBudW1i ZXIgb2YgbXVsdGlwbGljYXRpb25zIChVd2UpCgogICogQWRkIHNwYWNlcyBhcm91bmQgJysnIChV d2UpCgogICogVXNlICcxVUxMJyBpbnN0ZWFkIG9mIGV4cGxpY2l0IGNhc3QgdG8gcmVkdWNlIHZl cmJvc2l0eQoKICAqIEFkZCBMaW51cycgUmV2aWV3ZWQtYnkgdGFncyB0byBwYXRjaGVzIHRoYXQg YXJlIHVuY2hhbmdlZCBzaW5jZSB2MgoKdjQ6CgogICogVGFrZSBhZHZhbnRhZ2Ugb2YgemVybyB2 YWx1ZSBiZWluZyB0cmVhdGVkIGFzIDJeMzIgYnkgaGFyZHdhcmUuIFJld3JpdGUKICAgIHBhdGNo IDUvNSAoVXdlKS4KCnYzOgoKICAqIEltcHJvdmUgcGF0Y2ggMy81IGRlc2NyaXB0aW9uIChVd2Up CgogICogQWRkIG1vcmUgUmV2aWV3ZWQtYnkgdGFncyBmcm9tIFV3ZQoKdjI6CgpBZGRyZXNzIFV3 ZSBLbGVpbmUtS8O2bmlnIGNvbW1lbnRzLgoKICAqIEltcHJvdmUgcGF0Y2ggMS81IHN1bW1hcnkg bGluZQoKICAqIEFkZCBtb3JlIGluZm9ybWF0aW9uIHRvIHBhdGNoIDEvNSBkZXNjcmlwdGlvbgoK ICAqIEFkZCBtb3JlIGluZm9ybWF0aW9uIHRvIHBhdGNoIDIvNSBkZXNjcmlwdGlvbgoKICAqIERv bid0IHJvdW5kIHBlcmlvZC9kdXR5X2N5Y2xlIHVwIGluIC5hcHBseSAocGF0Y2ggMy81KQoKICAq IEV4cGFuZCB0aGUgY29tbWVudCBpbiBwYXRoIDUvNSBiYXNlZCBvbiBSTUsncyBhbmFseXNpcyBv ZiBoYXJkd2FyZQogICAgYmVoYXZpb3VyCgogICogQWRkIFV3ZSdzIFJldmlld2VkLWJ5IHRhZ3MK CkJhcnVjaCBTaWFjaCAoNCk6CiAgZ3BpbzogbXZlYnU6IGltcHJvdmUgcHdtIHBlcmlvZCBjYWxj dWxhdGlvbiBhY2N1cmFjeQogIGdwaW86IG12ZWJ1OiBtYWtlIHB3bSAuZ2V0X3N0YXRlIGNsb3Nl ciB0byBpZGVtcG90ZW50CiAgZ3BpbzogbXZlYnU6IGRvbid0IGxpbWl0IHB3bSBwZXJpb2QvZHV0 eV9jeWNsZSB0byBVSU5UX01BWAogIGdwaW86IG12ZWJ1OiBpbXByb3ZlIGhhbmRsaW5nIG9mIHB3 bSB6ZXJvIG9uL29mZiB2YWx1ZXMKCiBkcml2ZXJzL2dwaW8vZ3Bpby1tdmVidS5jIHwgNDcgKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjUg aW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pCgotLSAKMi4yOS4yCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=