From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 00/25] staging: rtl8723bs: remove DBG_8192C tracing macro
Date: Sat, 10 Apr 2021 16:20:13 +0200 [thread overview]
Message-ID: <cover.1618064274.git.fabioaiuto83@gmail.com> (raw)
This patchset remove from rtl8723bs driver the tracing macro
DBG_8192C.
This macro belongs to a verbose private tracing family,
which by default is set to _do nothing_. The only way
to activate the tracing is to manually define a symbol
in code.
First patch applies the following semantic patch:
@@
expression a, b, c, d, e, f, g, h, i, j, k;
constant B, C, D, E;
@@
(
- DBG_8192C(a);
|
- DBG_8192C(a, b);
|
- DBG_8192C(a, B);
|
- DBG_8192C(a, b, c);
|
- DBG_8192C(a, B, c);
|
- DBG_8192C(a, b, C);
|
- DBG_8192C(a, B, C);
|
- DBG_8192C(a, b, c, d);
|
- DBG_8192C(a, B, c, d);
|
- DBG_8192C(a, b, C, d);
|
- DBG_8192C(a, b, c, D);
|
- DBG_8192C(a, B, C, d);
|
- DBG_8192C(a, B, c, D);
|
- DBG_8192C(a, b, C, D);
|
- DBG_8192C(a, B, C, D);
|
- DBG_8192C(a, b, c, d, e);
|
- DBG_8192C(a, B, c, d, e);
|
- DBG_8192C(a, b, C, d, e);
|
- DBG_8192C(a, b, c, D, e);
|
- DBG_8192C(a, b, c, d, E);
|
- DBG_8192C(a, B, C, d, e);
|
- DBG_8192C(a, B, c, D, e);
|
- DBG_8192C(a, B, c, d, E);
|
- DBG_8192C(a, b, C, D, e);
|
- DBG_8192C(a, b, C, d, E);
|
- DBG_8192C(a, b, c, D, E);
|
- DBG_8192C(a, B, C, D, e);
|
- DBG_8192C(a, B, C, d, E);
|
- DBG_8192C(a, B, c, D, E);
|
- DBG_8192C(a, b, C, D, E);
|
- DBG_8192C(a, B, C, D, E);
|
- DBG_8192C(a, b, c, d, e, f);
|
- DBG_8192C(a, b, c, d, e, f, g);
|
- DBG_8192C(a, b, c, d, e, f, g, h);
|
- DBG_8192C(a, b, c, d, e, f, g, h, i);
|
- DBG_8192C(a, b, c, d, e, f, g, h, i, j);
|
- DBG_8192C(a, b, c, d, e, f, g, h, i, j, k);
)
Second patch removes all commented out call of macro.
Third patch removes macro definitions.
All subsequent patches do some code cleaning in all places
left empty by deleted macro, such as empty #ifdef blocks,
conditional code blocks guarded by never defined symbols
if-else blocks, for cycles, commented debug symbol definitions,
unnecessary parentheses and some other checkpatch issues.
Fabio Aiuto (25):
staging: rtl8723bs: remove all DBG_8192C logs
staging: rtl8723bs: remove all commented out DBG_8192C logs
staging: rtl8723bs: remove DBG_8192C macro definitions
staging: rtl8723bs: remove all if-blocks left empty by
DBG_8192C-remove coccinelle script
staging: rtl8723bs: put spaces around operators
staging: rtl8723bs: remove unused code blocks guarded by DEBUG_RTL871X
staging: rtl8723bs: remove commented out DEBUG_RTL871X definition
staging: rtl8723bs: remove code blocks guarded by DEBUG symbol
staging: rtl8723bs: remove empty code block guarded by DBG_CCX
staging: rtl8723bs: remove code block guarded by undefined
SDIO_DEBUG_IO
staging: rtl8723bs: remove commented out SDIO_DEBUG_IO symbol
definition
staging: rtl8723bs: remove empty ifdef blocks conditioned to
DEBUG_CFG80211 definition
staging: rtl8723bs: remove commented out DEBUG_CFG80211 symbol
definition
staging: rtl8723bs: remove unnecessary bracks
staging: rtl8723bs: fix comparison to null
staging: rtl8723bs: put spaces around operators
staging: rtl8723bs: split long line
staging: rtl8723bs: put constant on the right side of the test
staging: rtl8723bs: remove empty if and else blocks
staging: rtl8723bs: put constant on the right side of a test in
os_dep/ioctl_cfg80211.c
staging: rtl8723bs: remove unnecessary parentheses in
os_dep/ioctl_cfg80211.c
staging: rtl8723bs: remove empty else block in os_dep/ioctl_cfg80211.c
staging: rtl8723bs: fix comparison to true issue
staging: rtl8723bs: remove more unnecessary parentheses
staging: rtl8723bs: remove more empty if blocks after DBG_8192C
deletion
drivers/staging/rtl8723bs/core/rtw_debug.c | 35 ---
.../staging/rtl8723bs/core/rtw_ieee80211.c | 1 -
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 21 --
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 7 -
.../staging/rtl8723bs/core/rtw_wlan_util.c | 3 -
drivers/staging/rtl8723bs/core/rtw_xmit.c | 7 +-
drivers/staging/rtl8723bs/hal/hal_com.c | 10 +-
drivers/staging/rtl8723bs/hal/odm.c | 1 -
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 48 +---
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 263 +++---------------
.../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 -
.../staging/rtl8723bs/hal/rtl8723b_rxdesc.c | 3 -
.../staging/rtl8723bs/hal/rtl8723bs_recv.c | 15 +-
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 19 +-
drivers/staging/rtl8723bs/hal/sdio_ops.c | 39 +--
drivers/staging/rtl8723bs/include/autoconf.h | 7 -
drivers/staging/rtl8723bs/include/rtw_debug.h | 10 -
.../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 216 +-------------
.../staging/rtl8723bs/os_dep/ioctl_linux.c | 6 -
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 35 +--
20 files changed, 69 insertions(+), 679 deletions(-)
--
2.20.1
next reply other threads:[~2021-04-10 14:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 14:20 Fabio Aiuto [this message]
2021-04-10 14:20 ` [PATCH 01/25] staging: rtl8723bs: remove all DBG_8192C logs Fabio Aiuto
2021-04-10 14:20 ` [PATCH 02/25] staging: rtl8723bs: remove all commented out " Fabio Aiuto
2021-04-10 14:20 ` [PATCH 03/25] staging: rtl8723bs: remove DBG_8192C macro definitions Fabio Aiuto
2021-04-10 14:20 ` [PATCH 04/25] staging: rtl8723bs: remove all if-blocks left empty by DBG_8192C-remove coccinelle script Fabio Aiuto
2021-04-10 14:20 ` [PATCH 05/25] staging: rtl8723bs: put spaces around operators Fabio Aiuto
2021-04-10 14:20 ` [PATCH 06/25] staging: rtl8723bs: remove unused code blocks guarded by DEBUG_RTL871X Fabio Aiuto
2021-04-10 14:20 ` [PATCH 07/25] staging: rtl8723bs: remove commented out DEBUG_RTL871X definition Fabio Aiuto
2021-04-10 14:20 ` [PATCH 08/25] staging: rtl8723bs: remove code blocks guarded by DEBUG symbol Fabio Aiuto
2021-04-10 14:20 ` [PATCH 09/25] staging: rtl8723bs: remove empty code block guarded by DBG_CCX Fabio Aiuto
2021-04-10 14:20 ` [PATCH 10/25] staging: rtl8723bs: remove code block guarded by undefined SDIO_DEBUG_IO Fabio Aiuto
2021-04-10 14:20 ` [PATCH 11/25] staging: rtl8723bs: remove commented out SDIO_DEBUG_IO symbol definition Fabio Aiuto
2021-04-10 14:20 ` [PATCH 12/25] staging: rtl8723bs: remove empty ifdef blocks conditioned to DEBUG_CFG80211 definition Fabio Aiuto
2021-04-10 14:20 ` [PATCH 13/25] staging: rtl8723bs: remove commented out DEBUG_CFG80211 symbol definition Fabio Aiuto
2021-04-10 14:20 ` [PATCH 14/25] staging: rtl8723bs: remove unnecessary bracks Fabio Aiuto
2021-04-10 14:20 ` [PATCH 15/25] staging: rtl8723bs: fix comparison to null Fabio Aiuto
2021-04-10 14:20 ` [PATCH 16/25] staging: rtl8723bs: put spaces around operators Fabio Aiuto
2021-04-10 14:20 ` [PATCH 17/25] staging: rtl8723bs: split long line Fabio Aiuto
2021-04-10 14:20 ` [PATCH 18/25] staging: rtl8723bs: put constant on the right side of the test Fabio Aiuto
2021-04-10 14:20 ` [PATCH 19/25] staging: rtl8723bs: remove empty if and else blocks Fabio Aiuto
2021-04-10 14:20 ` [PATCH 20/25] staging: rtl8723bs: put constant on the right side of a test in os_dep/ioctl_cfg80211.c Fabio Aiuto
2021-04-10 14:20 ` [PATCH 21/25] staging: rtl8723bs: remove unnecessary parentheses " Fabio Aiuto
2021-04-10 14:20 ` [PATCH 22/25] staging: rtl8723bs: remove empty else block " Fabio Aiuto
2021-04-10 14:20 ` [PATCH 23/25] staging: rtl8723bs: fix comparison to true issue Fabio Aiuto
2021-04-10 14:20 ` [PATCH 24/25] staging: rtl8723bs: remove more unnecessary parentheses Fabio Aiuto
2021-04-10 14:20 ` [PATCH 25/25] staging: rtl8723bs: remove more empty if blocks after DBG_8192C deletion Fabio Aiuto
2021-04-10 17:23 ` kernel test robot
2021-04-10 17:23 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1618064274.git.fabioaiuto83@gmail.com \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.