All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 0/2] btrfs_del_csums error handling fixes
Date: Wed, 19 May 2021 10:52:44 -0400	[thread overview]
Message-ID: <cover.1621435862.git.josef@toxicpanda.com> (raw)

Hello,

Here are two fixes related to deleting csums.  Doing error injection stress
testing I was consistently seeing cases where we had a corrupt file system with
csums that existed without the corresponding extents being written.  This was
occuring because we were losing the return value in two cases, both of which
would result in this style of corruption.  With these two patches I'm no longer
seeing these errors.  Thanks,

Josef

Josef Bacik (2):
  btrfs: fix error handling in btrfs_del_csums
  btrfs: return errors from btrfs_del_csums in cleanup_ref_head

 fs/btrfs/extent-tree.c |  4 ++--
 fs/btrfs/file-item.c   | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

-- 
2.26.3


             reply	other threads:[~2021-05-19 14:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 14:52 Josef Bacik [this message]
2021-05-19 14:52 ` [PATCH 1/2] btrfs: fix error handling in btrfs_del_csums Josef Bacik
2021-05-20  1:02   ` Qu Wenruo
2021-05-19 14:52 ` [PATCH 2/2] btrfs: return errors from btrfs_del_csums in cleanup_ref_head Josef Bacik
2021-05-20  1:02   ` Qu Wenruo
2021-05-21 12:20   ` David Sterba
2021-05-21 12:24 ` [PATCH 0/2] btrfs_del_csums error handling fixes David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1621435862.git.josef@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.