From: email@example.com To: firstname.lastname@example.org Cc: Eduardo Habkost <email@example.com>, Juan Quintela <firstname.lastname@example.org>, Hyman <email@example.com>, "Dr. David Alan Gilbert" <firstname.lastname@example.org>, Peter Xu <email@example.com>, Chuan Zheng <firstname.lastname@example.org>, Paolo Bonzini <email@example.com> Subject: [PATCH v7 0/7] support dirtyrate at the granualrity of vcpu Date: Thu, 17 Jun 2021 22:12:01 +0800 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) From: Hyman Huang(黄勇) <email@example.com> v7 - fix the code style problem, sorry about that v6: - pick up commit "KVM: introduce dirty_pages and kvm_dirty_ring_enabled" which has been dropped in verison 5 v5: - rename global_dirty_log to global_dirty_tracking on Peter's advice - make global_dirty_tracking a bitmask: 1. add assert statement to ensure starting dirty tracking repeatly not allowed. 2. add assert statement to ensure dirty tracking cannot be stopped without having been started. - protecting dirty rate stat info: 1. drop the mutext for protecting dirty rate introduced in version 4 2. change the code block in query_dirty_rate_info so that requirements of "safe racing" to the dirty rate stat can be meet - make the helper function "record_dirtypages" inline and change the global var dirty_pages to local var - free DirtyRateVcpuList in case of memory leak please review, thanks a lot. v4: - make global_dirty_log a bitmask: 1. add comments about dirty log bitmask 2. use assert statement to check validity of flags 3. add trace to log bitmask changes - introduce mode option to show what method calculation should be used, also, export mode option in the as last commmit - split cleanup and init of dirty rate stat and move it in the main thread - change the fields of DirtyPageRecord to uint64_t type so that we can calculation the increased dirty pages with the formula as Peter's advice: dirty pages = end_pages - start_pages - introduce mutex to protect dirty rate stat info - adjust order of registering thread - drop the memory free callback this version modify some code on Peter's advice, reference to: https://lore.kernel.org/qemu-devel/YL5nNYXmrqMlXF3v@t490s/ thanks again. v3: - pick up "migration/dirtyrate: make sample page count configurable" to make patchset apply master correctly v2: - rebase to "migration/dirtyrate: make sample page count configurable" - rename "vcpu" to "per_vcpu" to show the per-vcpu method - squash patch 5/6 into a single one, squash patch 1/2 also - pick up "hmp: Add "calc_dirty_rate" and "info dirty_rate" cmds" - make global_dirty_log a bitmask to make sure both migration and dirty could not intefer with each other - add memory free callback to prevent memory leaking the most different of v2 fron v1 is that we make the global_dirty_log a bitmask. the reason is dirty rate measurement may start or stop dirty logging during calculation. this conflict with migration because stop dirty log make migration leave dirty pages out then that'll be a problem. make global_dirty_log a bitmask can let both migration and dirty rate measurement work fine. introduce GLOBAL_DIRTY_MIGRATION and GLOBAL_DIRTY_DIRTY_RATE to distinguish what current dirty log aims for, migration or dirty rate. all references to global_dirty_log should be untouched because any bit set there should justify that global dirty logging is enabled. Please review, thanks ! v1: Since the Dirty Ring on QEMU part has been merged recently, how to use this feature is under consideration. In the scene of migration, it is valuable to provide a more accurante interface to track dirty memory than existing one, so that the upper layer application can make a wise decision, or whatever. More importantly, dirtyrate info at the granualrity of vcpu could provide a possibility to make migration convergent by imposing restriction on vcpu. With Dirty Ring, we can calculate dirtyrate efficiently and cheaply. The old interface implemented by sampling pages, it consumes cpu resource, and the larger guest memory size become, the more cpu resource it consumes, namely, hard to scale. New interface has no such drawback. Please review, thanks ! Best Regards ! Hyman Huang(黄勇) (7): KVM: introduce dirty_pages and kvm_dirty_ring_enabled memory: rename global_dirty_log to global_dirty_tracking memory: make global_dirty_tracking a bitmask migration/dirtyrate: introduce struct and adjust DirtyRateStat migration/dirtyrate: adjust order of registering thread migration/dirtyrate: move init step of calculation to main thread migration/dirtyrate: implement dirty-ring dirtyrate calculation accel/kvm/kvm-all.c | 7 ++ hmp-commands.hx | 7 +- include/exec/memory.h | 18 +++- include/exec/ram_addr.h | 4 +- include/hw/core/cpu.h | 1 + include/sysemu/kvm.h | 1 + migration/dirtyrate.c | 267 ++++++++++++++++++++++++++++++++++++++++++------ migration/dirtyrate.h | 19 +++- migration/ram.c | 8 +- migration/trace-events | 2 + qapi/migration.json | 46 ++++++++- softmmu/memory.c | 36 +++++-- softmmu/trace-events | 1 + 13 files changed, 355 insertions(+), 62 deletions(-) -- 184.108.40.206
next reply other threads:[~2021-06-17 14:11 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-17 14:12 huangy81 [this message] 2021-06-17 14:12 ` [PATCH v7 1/7] KVM: introduce dirty_pages and kvm_dirty_ring_enabled huangy81 2021-06-17 14:12 ` [PATCH v7 2/7] memory: rename global_dirty_log to global_dirty_tracking huangy81 2021-06-17 14:12 ` [PATCH v7 3/7] memory: make global_dirty_tracking a bitmask huangy81 2021-06-17 15:29 ` Peter Xu 2021-06-18 0:36 ` Hyman Huang 2021-06-18 0:50 ` Hyman Huang 2021-06-17 14:12 ` [PATCH v7 4/7] migration/dirtyrate: introduce struct and adjust DirtyRateStat huangy81 2021-06-17 15:27 ` Peter Xu 2021-06-18 0:35 ` Hyman Huang 2021-06-17 14:12 ` [PATCH v7 5/7] migration/dirtyrate: adjust order of registering thread huangy81 2021-06-17 14:12 ` [PATCH v7 6/7] migration/dirtyrate: move init step of calculation to main thread huangy81 2021-06-17 15:34 ` Peter Xu 2021-06-18 1:16 ` Hyman Huang 2021-06-17 14:12 ` [PATCH v7 7/7] migration/dirtyrate: implement dirty-ring dirtyrate calculation huangy81 2021-06-17 15:41 ` Peter Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v7 0/7] support dirtyrate at the granualrity of vcpu' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.