From: huangy81@chinatelecom.cn
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Hyman <huangy81@chinatelecom.cn>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Peter Xu <peterx@redhat.com>, Chuan Zheng <zhengchuan@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH 0/4] support dirtyrate measurement with dirty bitmap
Date: Sun, 27 Jun 2021 13:38:13 +0800 [thread overview]
Message-ID: <cover.1624768443.git.huangy81@chinatelecom.cn> (raw)
From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
the dirtyrate measurement implemented by page-sampling originally, it
is not accurate in some scenarios, so we have introduced dirty-ring
based dirtyrate measurement(maybe it will be merged soon), it fix the
accuracy of page-sampling, and more importantly, it is at the
granualrity of vcpu.
dirty-ring method can be used when dirty-ring enable, as supplementary,
we introduce dirty-bitmap method to calculating dirtyrate when dirty log
enable, so that we can also get the accurate dirtyrate if needed in the
absence of dirty-ring.
three things has done to implement the measurement:
- introduce a fresh new dirty bits named DIRTY_MEMORY_DIRTY_RATE, which
is used to store dirty bitmap after fetching it from kvm. why we do
not reuse the existing DIRTY_MEMORY_MIGRATION dirty bits is we do not
want to interfere with migration of and let implementation clear, this
is also the reason why dirty_memory be split.
DIRTY_MEMORY_DIRTY_RATE dirty bits will be filled when
memory_global_dirty_log_sync executed if GLOBAL_DIRTY_DIRTY_RATE bit
be set in the global_dirty_tracking flag.
- introduce kvm_get_manual_dirty_log_protect function so that we can
probe the protect caps of kvm when calculating.
- implement dirtyrate measurement with dirty bitmap with following step:
1. start the dirty log.
2. probe the protect cap, if KVM_DIRTY_LOG_INITIALLY_SET enable, skip
skip the 1'R and do the reset page protection manually, since kvm
file bitmap with 1 bits if this cap is enabled.
3. clear the DIRTY_MEMORY_DIRTY_RATE dirty bits, prepare to store
the dirty bitmap.
4. start memory_global_dirty_log_sync and fetch dirty bitmap from kvm
5. reap the DIRTY_MEMORY_DIRTY_RATE dirty bits and do the calculation.
this patchset rebases on the commit
"migration/dirtyrate: implement dirty-ring dirtyrate calculation",
since the above feature has not been merged, so we post this patch
for the sake of RFC. ideally, this patshset may be merged after it.
Please, review, thanks !
Best Regards !
Hyman Huang(黄勇) (4):
memory: introduce DIRTY_MEMORY_DIRTY_RATE dirty bits
KVM: introduce kvm_get_manual_dirty_log_protect
memory: introduce DIRTY_MEMORY_DIRTY_RATE dirty bits functions
migration/dirtyrate: implement dirty-bitmap dirtyrate calculation
accel/kvm/kvm-all.c | 6 ++
hmp-commands.hx | 9 +--
include/exec/ram_addr.h | 140 +++++++++++++++++++++++++++++++++++++++++++++-
include/exec/ramlist.h | 9 +--
include/sysemu/kvm.h | 1 +
migration/dirtyrate.c | 146 +++++++++++++++++++++++++++++++++++++++++++++---
migration/trace-events | 2 +
qapi/migration.json | 6 +-
softmmu/physmem.c | 60 ++++++++++++++++++++
9 files changed, 358 insertions(+), 21 deletions(-)
--
1.8.3.1
next reply other threads:[~2021-06-27 5:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 5:38 huangy81 [this message]
[not found] ` <cover.1624771216.git.huangy81@chinatelecom.cn>
2021-06-27 5:38 ` [PATCH 1/4] memory: introduce DIRTY_MEMORY_DIRTY_RATE dirty bits huangy81
2021-07-09 18:37 ` Peter Xu
2021-06-27 5:38 ` [PATCH 2/4] KVM: introduce kvm_get_manual_dirty_log_protect huangy81
2021-06-27 5:38 ` [PATCH 3/4] memory: introduce DIRTY_MEMORY_DIRTY_RATE dirty bits functions huangy81
2021-07-09 18:26 ` Peter Xu
2021-06-27 5:38 ` [PATCH 4/4] migration/dirtyrate: implement dirty-bitmap dirtyrate calculation huangy81
2021-07-09 18:32 ` Peter Xu
2021-07-09 18:20 ` [PATCH 0/4] support dirtyrate measurement with dirty bitmap Peter Xu
2021-07-11 15:27 ` Hyman Huang
2021-07-13 17:45 ` Peter Xu
2021-07-14 15:59 ` Hyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1624768443.git.huangy81@chinatelecom.cn \
--to=huangy81@chinatelecom.cn \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.