From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5FA8C07E99 for ; Mon, 5 Jul 2021 08:19:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E62F6128B for ; Mon, 5 Jul 2021 08:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230114AbhGEIWD (ORCPT ); Mon, 5 Jul 2021 04:22:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbhGEIWC (ORCPT ); Mon, 5 Jul 2021 04:22:02 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC184C061574; Mon, 5 Jul 2021 01:19:24 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id b8-20020a17090a4888b02901725eedd346so8402643pjh.4; Mon, 05 Jul 2021 01:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z1P0C+fJT3E1BmyLma3Hvt+LmdbtbvRdt4PGsDvZhDo=; b=hbAxn5PkjyDIa6lxUCJXoInHZZziGv78nTgayqagi4cPk6CZAHbU6uAkYcE9ckzcBL lXmrxyWAcdQUgSxTak7vyp6yD+8kwgGIzFpuk/4nHM6A7OvByeaF38nm4f2SQilizy1j dF8aiUS9VDps+5xuRFEpgXt9Wm23VPxUwbzjBCzdjpRdvJAMzH/XYEILlAuPYYxlgPR8 YJO8cvgoyw6KtHDnICzUV+FmvSgJD/6vfyqfnGithRmnD5rH9XfcKUTIRdsdDoDzSIQq MUfKS1D/YjhygvLbXvy/YlfnX2hEy34tjVkj+eR+4vX8oEKOi4nvbeKDQsCk3PgMZVXt mP8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z1P0C+fJT3E1BmyLma3Hvt+LmdbtbvRdt4PGsDvZhDo=; b=iYQMHj7I99kY+rwDcxiH9epsF3mns5SURI5YPXtWWnnYjUfVUyYRx+EqhCWB+rX9fa T7I3rxPkZb8MKmZ4dlWi+oPKHGHX0lqyBa4BWX1WbeaSPJygYMzpZJxeOBkVL0BaxE/U GaS0yROFOHdaEiu/k6dRwkyox9CwIUdDiv78ZFoG4776eI+2XCt9GIZON+f1XlqpUnSz DVt7CmAJPkp6vGjz4XwAQvYaOUPnW9QVYooUbT2b6j7yo2xm9Zf0TNYpge+eFLpsck5G tw+2DUtNc3b2L96wjlGke+AE5BZx2q8RVEmB01oWpvFZmlgbR4W5SlI7NflM6jzp0Lav 8w0Q== X-Gm-Message-State: AOAM533s4e3lN4Xn9vu87ohCI8WBW6NB2UsIwUvm/dtBXVh3tt4EBRvQ htPgCxS/PuPpV9FmgcUE+zI= X-Google-Smtp-Source: ABdhPJyW07EURk2obQnItNdqKcxAHzpBo8dwmgWrp9zIifIAudIWcCD5SxYkGAzC63Rwk+MqT8t6hA== X-Received: by 2002:a17:90a:5401:: with SMTP id z1mr13788644pjh.7.1625473164317; Mon, 05 Jul 2021 01:19:24 -0700 (PDT) Received: from localhost.localdomain ([156.146.35.76]) by smtp.gmail.com with ESMTPSA id y11sm12209986pfo.160.2021.07.05.01.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jul 2021 01:19:23 -0700 (PDT) From: William Breathitt Gray To: jic23@kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com, William Breathitt Gray Subject: [PATCH v12 00/17] Introduce the Counter character device interface Date: Mon, 5 Jul 2021 17:18:48 +0900 Message-Id: X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes in v12: - Move unlock to after register set in quad8_count_ceiling_write() - Add locking protection to counter_set_event_node() - Fix sparse warning by using {} instead of {0} - Clean up and organize comments for clarity - Reduce boilerplate by utilizing devm_add_action_or_reset() - Use switch statements in ti_eqep_action_read() to make possible cases more obvious I pulled out a lot of bits and pieces to their own patches; hopefully that makes reviewing this patchset much simpler than before. This patchset is also available on my personal git repo for convenience: https://gitlab.com/vilhelmgray/iio/-/tree/counter_chrdev_v12 The patches preceding "counter: Internalize sysfs interface code" are primarily cleanup and fixes that can be picked up and applied now to the IIO tree if so desired. The "counter: Internalize sysfs interface code" patch as well may be considered for pickup because it is relatively safe and makes no changes to the userspace interface. To summarize the main points of this patchset: there are no changes to the existing Counter sysfs userspace interface; a Counter character device interface is introduced that allows Counter events and associated data to be read() by userspace; the events_configure() and watch_validate() driver callbacks are introduced to support Counter events; and IRQ support is added to the 104-QUAD-8 driver, serving as an example of how to support the new Counter events functionality. Something that should still be discussed: should the struct counter_event "status" member be 8 bits or 32 bits wide? This member will provide the return status (system error number) of an event operation. William Breathitt Gray (17): counter: 104-quad-8: Return error when invalid mode during ceiling_write counter: Return error code on invalid modes counter: Standardize to ERANGE for limit exceeded errors counter: Rename counter_signal_value to counter_signal_level counter: Rename counter_count_function to counter_function counter: Internalize sysfs interface code counter: Update counter.h comments to reflect sysfs internalization docs: counter: Update to reflect sysfs internalization counter: Move counter enums to uapi header counter: Add character device interface docs: counter: Document character device interface tools/counter: Create Counter tools counter: Implement signalZ_action_component_id sysfs attribute counter: Implement *_component_id sysfs attributes counter: Implement events_queue_size sysfs attribute counter: 104-quad-8: Replace mutex with spinlock counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 Documentation/ABI/testing/sysfs-bus-counter | 38 +- Documentation/driver-api/generic-counter.rst | 366 +++- .../userspace-api/ioctl/ioctl-number.rst | 1 + MAINTAINERS | 3 +- drivers/counter/104-quad-8.c | 728 ++++---- drivers/counter/Kconfig | 6 +- drivers/counter/Makefile | 1 + drivers/counter/counter-chrdev.c | 498 ++++++ drivers/counter/counter-chrdev.h | 14 + drivers/counter/counter-core.c | 182 ++ drivers/counter/counter-sysfs.c | 953 +++++++++++ drivers/counter/counter-sysfs.h | 13 + drivers/counter/counter.c | 1496 ----------------- drivers/counter/ftm-quaddec.c | 59 +- drivers/counter/intel-qep.c | 150 +- drivers/counter/interrupt-cnt.c | 73 +- drivers/counter/microchip-tcb-capture.c | 103 +- drivers/counter/stm32-lptimer-cnt.c | 176 +- drivers/counter/stm32-timer-cnt.c | 147 +- drivers/counter/ti-eqep.c | 205 ++- include/linux/counter.h | 716 ++++---- include/linux/counter_enum.h | 45 - include/uapi/linux/counter.h | 133 ++ tools/Makefile | 13 +- tools/counter/Build | 1 + tools/counter/Makefile | 53 + tools/counter/counter_example.c | 95 ++ 27 files changed, 3501 insertions(+), 2767 deletions(-) create mode 100644 drivers/counter/counter-chrdev.c create mode 100644 drivers/counter/counter-chrdev.h create mode 100644 drivers/counter/counter-core.c create mode 100644 drivers/counter/counter-sysfs.c create mode 100644 drivers/counter/counter-sysfs.h delete mode 100644 drivers/counter/counter.c delete mode 100644 include/linux/counter_enum.h create mode 100644 include/uapi/linux/counter.h create mode 100644 tools/counter/Build create mode 100644 tools/counter/Makefile create mode 100644 tools/counter/counter_example.c base-commit: 6cbb3aa0f9d5d23221df787cf36f74d3866fdb78 -- 2.32.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE8CC07E98 for ; Mon, 5 Jul 2021 08:21:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81F93613C8 for ; Mon, 5 Jul 2021 08:21:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81F93613C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Fdtf7k2AJwLVa+9yj4f4XKzWCUHO6RzED1cvtWwolhM=; b=PQxLgJqTlUpDJB 0B5QRNr3V+X3oudtSnRqzO5GM7whOlRR/M7Muj5/lWlPXnVfnFCOa8VsIKwaROrDigr0oOoJbvNPy wUUU8lIjeUK+NvTixiY9mEHEoDMaJHh93c8wCRNtMtEuzsd726naKexN6KSwttIFK0OOFd3g4xzBA 2uR+8Pb6LsfG8oMOTRVbuUlxYarwyzHIXxuhzWusiiOKaS7783Yb+/5p35b7byUNain+01FFT2w4U vvQ+Q3jAxmQtuOb++NdhKiLCDxR2qrd4b9OeaIuMK6oKLPJyyXSFx1okS4BHoK1pW/YzYXsacjfsl mstnKJ7wIHRumW9v4bDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0JpF-008C34-HM; Mon, 05 Jul 2021 08:19:33 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0JpA-008C1S-CL for linux-arm-kernel@lists.infradead.org; Mon, 05 Jul 2021 08:19:31 +0000 Received: by mail-pj1-x1034.google.com with SMTP id b14-20020a17090a7aceb029017261c7d206so8289021pjl.5 for ; Mon, 05 Jul 2021 01:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z1P0C+fJT3E1BmyLma3Hvt+LmdbtbvRdt4PGsDvZhDo=; b=hbAxn5PkjyDIa6lxUCJXoInHZZziGv78nTgayqagi4cPk6CZAHbU6uAkYcE9ckzcBL lXmrxyWAcdQUgSxTak7vyp6yD+8kwgGIzFpuk/4nHM6A7OvByeaF38nm4f2SQilizy1j dF8aiUS9VDps+5xuRFEpgXt9Wm23VPxUwbzjBCzdjpRdvJAMzH/XYEILlAuPYYxlgPR8 YJO8cvgoyw6KtHDnICzUV+FmvSgJD/6vfyqfnGithRmnD5rH9XfcKUTIRdsdDoDzSIQq MUfKS1D/YjhygvLbXvy/YlfnX2hEy34tjVkj+eR+4vX8oEKOi4nvbeKDQsCk3PgMZVXt mP8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z1P0C+fJT3E1BmyLma3Hvt+LmdbtbvRdt4PGsDvZhDo=; b=Im/ZiCEuHGJ3P6Yh7MpTzPPWSxsErfskBB3+J/vjVs0/mYgkUCZqnb0oaRIt9X9qGF LcxN3+oaNC3ieyt7wcwg64m4UiS4juObMaNIXhfx61gyoB8f1HxkWRqZoK6NYOMl7YQu WHq16QLUGj1u+rrE++ngeG5TJmruHyifMBN3NC8muzc7RVgT58cPDG74QhW3EMX2/LCW vG4Wfz/BePlUOpDv7ue4nd8Wq25mQQcahAsRsF3ftj1s/Y9SHYRBAKakTL/HgcyV1JRK VyBf91rxTsaG5oE3WoTDKYR+zBfnlixgVH3+eT4tIIeTkJFDe4dcqquPJAmT8gdQOScl 1qjA== X-Gm-Message-State: AOAM533tSXPA8cOrjFYiMN1oLzmY7pfGkOxsBdJmzy4PCbuISdJgcew4 Zo4gfJSl9yPwFNHuxF56pMk= X-Google-Smtp-Source: ABdhPJyW07EURk2obQnItNdqKcxAHzpBo8dwmgWrp9zIifIAudIWcCD5SxYkGAzC63Rwk+MqT8t6hA== X-Received: by 2002:a17:90a:5401:: with SMTP id z1mr13788644pjh.7.1625473164317; Mon, 05 Jul 2021 01:19:24 -0700 (PDT) Received: from localhost.localdomain ([156.146.35.76]) by smtp.gmail.com with ESMTPSA id y11sm12209986pfo.160.2021.07.05.01.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jul 2021 01:19:23 -0700 (PDT) From: William Breathitt Gray To: jic23@kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com, William Breathitt Gray Subject: [PATCH v12 00/17] Introduce the Counter character device interface Date: Mon, 5 Jul 2021 17:18:48 +0900 Message-Id: X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210705_011929_414781_09348B48 X-CRM114-Status: GOOD ( 18.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Changes in v12: - Move unlock to after register set in quad8_count_ceiling_write() - Add locking protection to counter_set_event_node() - Fix sparse warning by using {} instead of {0} - Clean up and organize comments for clarity - Reduce boilerplate by utilizing devm_add_action_or_reset() - Use switch statements in ti_eqep_action_read() to make possible cases more obvious I pulled out a lot of bits and pieces to their own patches; hopefully that makes reviewing this patchset much simpler than before. This patchset is also available on my personal git repo for convenience: https://gitlab.com/vilhelmgray/iio/-/tree/counter_chrdev_v12 The patches preceding "counter: Internalize sysfs interface code" are primarily cleanup and fixes that can be picked up and applied now to the IIO tree if so desired. The "counter: Internalize sysfs interface code" patch as well may be considered for pickup because it is relatively safe and makes no changes to the userspace interface. To summarize the main points of this patchset: there are no changes to the existing Counter sysfs userspace interface; a Counter character device interface is introduced that allows Counter events and associated data to be read() by userspace; the events_configure() and watch_validate() driver callbacks are introduced to support Counter events; and IRQ support is added to the 104-QUAD-8 driver, serving as an example of how to support the new Counter events functionality. Something that should still be discussed: should the struct counter_event "status" member be 8 bits or 32 bits wide? This member will provide the return status (system error number) of an event operation. William Breathitt Gray (17): counter: 104-quad-8: Return error when invalid mode during ceiling_write counter: Return error code on invalid modes counter: Standardize to ERANGE for limit exceeded errors counter: Rename counter_signal_value to counter_signal_level counter: Rename counter_count_function to counter_function counter: Internalize sysfs interface code counter: Update counter.h comments to reflect sysfs internalization docs: counter: Update to reflect sysfs internalization counter: Move counter enums to uapi header counter: Add character device interface docs: counter: Document character device interface tools/counter: Create Counter tools counter: Implement signalZ_action_component_id sysfs attribute counter: Implement *_component_id sysfs attributes counter: Implement events_queue_size sysfs attribute counter: 104-quad-8: Replace mutex with spinlock counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 Documentation/ABI/testing/sysfs-bus-counter | 38 +- Documentation/driver-api/generic-counter.rst | 366 +++- .../userspace-api/ioctl/ioctl-number.rst | 1 + MAINTAINERS | 3 +- drivers/counter/104-quad-8.c | 728 ++++---- drivers/counter/Kconfig | 6 +- drivers/counter/Makefile | 1 + drivers/counter/counter-chrdev.c | 498 ++++++ drivers/counter/counter-chrdev.h | 14 + drivers/counter/counter-core.c | 182 ++ drivers/counter/counter-sysfs.c | 953 +++++++++++ drivers/counter/counter-sysfs.h | 13 + drivers/counter/counter.c | 1496 ----------------- drivers/counter/ftm-quaddec.c | 59 +- drivers/counter/intel-qep.c | 150 +- drivers/counter/interrupt-cnt.c | 73 +- drivers/counter/microchip-tcb-capture.c | 103 +- drivers/counter/stm32-lptimer-cnt.c | 176 +- drivers/counter/stm32-timer-cnt.c | 147 +- drivers/counter/ti-eqep.c | 205 ++- include/linux/counter.h | 716 ++++---- include/linux/counter_enum.h | 45 - include/uapi/linux/counter.h | 133 ++ tools/Makefile | 13 +- tools/counter/Build | 1 + tools/counter/Makefile | 53 + tools/counter/counter_example.c | 95 ++ 27 files changed, 3501 insertions(+), 2767 deletions(-) create mode 100644 drivers/counter/counter-chrdev.c create mode 100644 drivers/counter/counter-chrdev.h create mode 100644 drivers/counter/counter-core.c create mode 100644 drivers/counter/counter-sysfs.c create mode 100644 drivers/counter/counter-sysfs.h delete mode 100644 drivers/counter/counter.c delete mode 100644 include/linux/counter_enum.h create mode 100644 include/uapi/linux/counter.h create mode 100644 tools/counter/Build create mode 100644 tools/counter/Makefile create mode 100644 tools/counter/counter_example.c base-commit: 6cbb3aa0f9d5d23221df787cf36f74d3866fdb78 -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel