All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Geoffrey D. Bennett" <g@b4.vu>
To: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>
Cc: Hin-Tak Leung <htl10@users.sourceforge.net>,
	Vladimir Sadovnikov <sadko4u@gmail.com>
Subject: [PATCH 0/4] ALSA: scarlett2: note gen 3 support + fix four issues
Date: Fri, 23 Jul 2021 05:41:40 +0930	[thread overview]
Message-ID: <cover.1626959758.git.g@b4.vu> (raw)

Hi Takashi,

In the sound-5.14-rc1 merge commit log the highlights included:
"Scarlett2 mixer code fixes and enhancements". I think that the new
support for Gen 3 devices is significant enough to be worth
mentioning.

Can you add to the next update a note along the lines of "Support for
Focusrite Scarlett Solo/2i2/4i4/8i6/18i8/18i20 Gen 3 audio interface
proprietary mixer controls"?

This set of patches is relative to v5.14-rc2 and fixes four issues:

1. The Mute/Dim/MSD Mode controls are missing the direction/function
parts of the syntax of standard control names as per
Documentation/sound/designs/control-names.rst

- This could be considered a breaking-stable change if someone is
  relying on the Mute/Dim control names not changing. I think it's
  unlikely to be a problem as this driver is still considered
  experimental and not enabled by default, but if never changing
  control names is important, then you can drop this patch.

2. The Direct Monitor control on the 2i2 interface is an Enum, not a
Switch.

- This changes a control name, but that control was only introduced in
  v5.14-rc1, so not a problem to change it now.

3. Fixes the mute status not being correctly read when the mute button
is pressed.

- Not applicable for stable; those controls were introduced in
  v5.14-rc1.

4. Sends the correct notification on line out and speaker switching
changes.

- Partly applicable to stable, but will need a separate patch.

Thanks,
Geoffrey.

Geoffrey D. Bennett (4):
  ALSA: scarlett2: Fix Mute/Dim/MSD Mode control names
  ALSA: scarlett2: Fix Direct Monitor control name for 2i2
  ALSA: scarlett2: Correct channel mute status after mute button pressed
  ALSA: scarlett2: Fix line out/speaker switching notifications

 sound/usb/mixer_scarlett_gen2.c | 34 +++++++++++++++++++++++----------
 1 file changed, 24 insertions(+), 10 deletions(-)

-- 
2.31.1


             reply	other threads:[~2021-07-22 20:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22 20:11 Geoffrey D. Bennett [this message]
2021-07-22 18:30 ` [PATCH 0/4] ALSA: scarlett2: note gen 3 support + fix four issues Geraldo Nascimento
2021-07-22 20:11 ` [PATCH 1/4] ALSA: scarlett2: Fix Mute/Dim/MSD Mode control names Geoffrey D. Bennett
2021-07-22 20:12 ` [PATCH 2/4] ALSA: scarlett2: Fix Direct Monitor control name for 2i2 Geoffrey D. Bennett
2021-07-22 20:12 ` [PATCH 3/4] ALSA: scarlett2: Correct channel mute status after mute button pressed Geoffrey D. Bennett
2021-07-22 20:13 ` [PATCH 4/4] ALSA: scarlett2: Fix line out/speaker switching notifications Geoffrey D. Bennett
2021-07-24  8:06 ` [PATCH 0/4] ALSA: scarlett2: note gen 3 support + fix four issues Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1626959758.git.g@b4.vu \
    --to=g@b4.vu \
    --cc=alsa-devel@alsa-project.org \
    --cc=htl10@users.sourceforge.net \
    --cc=sadko4u@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.