From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 0/3] btrfs-progs: make check handle invalid bg items
Date: Wed, 18 Aug 2021 00:39:19 -0400 [thread overview]
Message-ID: <cover.1629261403.git.josef@toxicpanda.com> (raw)
Hello,
While writing code for extent tree v2 I noticed that I was generating a fs with
an invalid block group ->used value. However fsck wasn't catching this, because
we don't actuall check the used value of the block group items in normal mode.
lowmem mode does this properly thankfully, so this only needs to be added to the
normal fsck mode.
I've added code to btrfs-corrupt-block to generate the corrupt image I need for
the test case. Then of course the actual patch to detect and fix the problem.
Thanks,
Josef
Josef Bacik (3):
btrfs-progs: add the ability to corrupt block group items
btrfs-progs: make check detect and fix invalid used for block groups
btrfs-progs: add a test image with a corrupt block group item
btrfs-corrupt-block.c | 108 +++++++++++++++++-
check/common.h | 5 +
check/main.c | 89 ++++++++++++++-
.../default.img.xz | Bin 0 -> 1036 bytes
4 files changed, 197 insertions(+), 5 deletions(-)
create mode 100644 tests/fsck-tests/050-invalid-block-group-used/default.img.xz
--
2.26.3
next reply other threads:[~2021-08-18 4:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 4:39 Josef Bacik [this message]
2021-08-18 4:39 ` [PATCH 1/3] btrfs-progs: add the ability to corrupt block group items Josef Bacik
2021-08-20 12:58 ` David Sterba
2021-08-18 4:39 ` [PATCH 2/3] btrfs-progs: make check detect and fix invalid used for block groups Josef Bacik
2021-08-18 4:39 ` [PATCH 3/3] btrfs-progs: add a test image with a corrupt block group item Josef Bacik
2021-08-18 5:45 ` [PATCH 0/3] btrfs-progs: make check handle invalid bg items Qu Wenruo
2021-08-20 12:57 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1629261403.git.josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.