From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>, hanwen@google.com
Subject: [RFC PATCH 0/2] First steps towards iterating over submodule refs
Date: Wed, 25 Aug 2021 16:23:29 -0700 [thread overview]
Message-ID: <cover.1629933380.git.jonathantanmy@google.com> (raw)
Here are more results from my submodule partial clone work - teaching
ref iteration to work with submodules by introducing struct repo
parameters at different points. I'm sending this out early as RFC
(before implementing the part that actually adds support for other
repositories) because there might be a better way to do this that I
haven't thought of. (This patch set contains my best idea for how this
could be implemented, but admittedly it is a bit unelegant that the repo
parameter is injected differently into each iterator function.)
This will break any existing topic that introduces new ref store
backends (Han-Wen cc-ed for reftable), although I think that the changes
introduced here are not too significant.
Jonathan Tan (2):
refs: make _advance() check struct repo, not flag
refs: add repo paramater to _iterator_peel()
refs.c | 50 +++++++++++++++++++++++-------------------
refs/debug.c | 13 ++++++-----
refs/files-backend.c | 31 ++++++++++++++++++--------
refs/iterator.c | 38 ++++++++++++++++++++++++--------
refs/packed-backend.c | 30 ++++++++++++++++---------
refs/ref-cache.c | 7 +++---
refs/refs-internal.h | 51 +++++++++++++++++++++++++++++--------------
7 files changed, 144 insertions(+), 76 deletions(-)
--
2.33.0.rc2.250.ged5fa647cd-goog
next reply other threads:[~2021-08-25 23:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 23:23 Jonathan Tan [this message]
2021-08-25 23:23 ` [RFC PATCH 1/2] refs: make _advance() check struct repo, not flag Jonathan Tan
2021-08-26 16:39 ` Han-Wen Nienhuys
2021-08-26 22:24 ` Jonathan Tan
2021-09-14 22:41 ` Glen Choo
2021-09-15 7:35 ` Han-Wen Nienhuys
2021-09-16 17:26 ` Jonathan Tan
2021-09-16 21:56 ` Junio C Hamano
2021-09-16 22:05 ` Jonathan Tan
2021-09-16 17:24 ` Jonathan Tan
2021-08-25 23:23 ` [RFC PATCH 2/2] refs: add repo paramater to _iterator_peel() Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1629933380.git.jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.