All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Kenny <darren.kenny@oracle.com>
To: grub-devel@gnu.org
Cc: daniel.kiper@oracle.com, darren.kenny@oracle.com
Subject: [PATCH 0/6] Fix some Coverity low-hanging bugs
Date: Tue, 26 Oct 2021 15:02:34 +0000	[thread overview]
Message-ID: <cover.1635260363.git.darren.kenny@oracle.com> (raw)

Coverity has flagged a number of small issues that should be fixed to help in
cleaning up the code - these here are primarily memory leaks or uninitialized
variables.

In theory leaked memory is significant, but for short-lived processes it is
minor. 

Similarly for unitinialized variables - some compilers will do the right thing
and zero out the value allocated on the stack, but some won't. So it is better
to be sure of the content that leave it open for possible misuse.

Darren Kenny (6):
  grub-install-common: Fix memory leak in copy_all()
  grub-mkrescue: Fix memory leak in write_part()
  grub-fstest: Fix resource leaks in cmd_cmp()
  grub-mkfont: Fix memory leak in write_font_pf2()
  zfs: Fix possible insecure use of chunk size in zap_leaf_array_get()
  gzio: Fix possible use of uninitialized variable in huft_build()

 grub-core/fs/zfs/zfs.c     | 3 ++-
 grub-core/io/gzio.c        | 2 +-
 util/grub-fstest.c         | 7 ++++++-
 util/grub-install-common.c | 4 +++-
 util/grub-mkfont.c         | 1 +
 util/grub-mkrescue.c       | 1 +
 6 files changed, 14 insertions(+), 4 deletions(-)

-- 
2.27.0



             reply	other threads:[~2021-10-26 15:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 15:02 Darren Kenny [this message]
2021-10-26 15:02 ` [PATCH 1/6] grub-install-common: Fix memory leak in copy_all() Darren Kenny
2021-10-26 15:02 ` [PATCH 2/6] grub-mkrescue: Fix memory leak in write_part() Darren Kenny
2021-10-26 15:02 ` [PATCH 3/6] grub-fstest: Fix resource leaks in cmd_cmp() Darren Kenny
2021-10-26 15:02 ` [PATCH 4/6] grub-mkfont: Fix memory leak in write_font_pf2() Darren Kenny
2021-10-26 15:02 ` [PATCH 5/6] zfs: Fix possible insecure use of chunk size in zap_leaf_array_get() Darren Kenny
2021-10-26 15:02 ` [PATCH 6/6] gzio: Fix possible use of uninitialized variable in huft_build() Darren Kenny
2021-10-28 21:29 ` [PATCH 0/6] Fix some Coverity low-hanging bugs Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1635260363.git.darren.kenny@oracle.com \
    --to=darren.kenny@oracle.com \
    --cc=daniel.kiper@oracle.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.