Hi all, This patch series contains two improvements for the SiFive CLINT DT bindings. Changes compared to v2[1]: - Add Acked-by, Reviewed-by. Changes compared to v1[2]: - Split in two patches, - Improve patch description and document limit rationale. Thanks! [1] https://lore.kernel.org/r/cover.1639662093.git.geert@linux-m68k.org [2] https://lore.kernel.org/r/20211125152317.162958-1-geert@linux-m68k.org Geert Uytterhoeven (2): dt-bindings: timer: sifive,clint: Fix number of interrupts dt-bindings: timer: sifive,clint: Group interrupt tuples .../devicetree/bindings/timer/sifive,clint.yaml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.25.1
Hi all, This patch series contains two improvements for the SiFive CLINT DT bindings. Changes compared to v2[1]: - Add Acked-by, Reviewed-by. Changes compared to v1[2]: - Split in two patches, - Improve patch description and document limit rationale. Thanks! [1] https://lore.kernel.org/r/cover.1639662093.git.geert@linux-m68k.org [2] https://lore.kernel.org/r/20211125152317.162958-1-geert@linux-m68k.org Geert Uytterhoeven (2): dt-bindings: timer: sifive,clint: Fix number of interrupts dt-bindings: timer: sifive,clint: Group interrupt tuples .../devicetree/bindings/timer/sifive,clint.yaml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.25.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
The number of interrupts lacks an upper bound, thus assuming one, causing properly grouped "interrupts-extended" properties to be flagged as an error by "make dtbs_check". Fix this by adding the missing "maxItems". As the architectural maximum is 4095 interrupts, using that as the limit would be unpractical. Hence limit it to 10 interrupts (two interrupts for a system management core, and two interrupts per core for other cores). This should be sufficient for now, and the limit can always be increased when the need arises. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Rob Herring <robh@kernel.org> --- v3: - Add Acked-by, v2: - Split in two patches, - Improve patch description and document limit rationale. --- Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml index 8d5f4687add9e81e..b75fd6f982b1ecb3 100644 --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml @@ -44,6 +44,7 @@ properties: interrupts-extended: minItems: 1 + maxItems: 10 additionalProperties: false -- 2.25.1
The number of interrupts lacks an upper bound, thus assuming one, causing properly grouped "interrupts-extended" properties to be flagged as an error by "make dtbs_check". Fix this by adding the missing "maxItems". As the architectural maximum is 4095 interrupts, using that as the limit would be unpractical. Hence limit it to 10 interrupts (two interrupts for a system management core, and two interrupts per core for other cores). This should be sufficient for now, and the limit can always be increased when the need arises. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Rob Herring <robh@kernel.org> --- v3: - Add Acked-by, v2: - Split in two patches, - Improve patch description and document limit rationale. --- Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml index 8d5f4687add9e81e..b75fd6f982b1ecb3 100644 --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml @@ -44,6 +44,7 @@ properties: interrupts-extended: minItems: 1 + maxItems: 10 additionalProperties: false -- 2.25.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
To improve human readability and enable automatic validation, the tuples in "interrupts-extended" properties should be grouped using angle brackets. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- v3: - Add Reviewed-by, v2: - Split in two patches. --- Documentation/devicetree/bindings/timer/sifive,clint.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml index b75fd6f982b1ecb3..3b25ec37d81159cb 100644 --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml @@ -57,10 +57,10 @@ examples: - | timer@2000000 { compatible = "sifive,fu540-c000-clint", "sifive,clint0"; - interrupts-extended = <&cpu1intc 3 &cpu1intc 7 - &cpu2intc 3 &cpu2intc 7 - &cpu3intc 3 &cpu3intc 7 - &cpu4intc 3 &cpu4intc 7>; + interrupts-extended = <&cpu1intc 3>, <&cpu1intc 7>, + <&cpu2intc 3>, <&cpu2intc 7>, + <&cpu3intc 3>, <&cpu3intc 7>, + <&cpu4intc 3>, <&cpu4intc 7>; reg = <0x2000000 0x10000>; }; ... -- 2.25.1
To improve human readability and enable automatic validation, the tuples in "interrupts-extended" properties should be grouped using angle brackets. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- v3: - Add Reviewed-by, v2: - Split in two patches. --- Documentation/devicetree/bindings/timer/sifive,clint.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml index b75fd6f982b1ecb3..3b25ec37d81159cb 100644 --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml @@ -57,10 +57,10 @@ examples: - | timer@2000000 { compatible = "sifive,fu540-c000-clint", "sifive,clint0"; - interrupts-extended = <&cpu1intc 3 &cpu1intc 7 - &cpu2intc 3 &cpu2intc 7 - &cpu3intc 3 &cpu3intc 7 - &cpu4intc 3 &cpu4intc 7>; + interrupts-extended = <&cpu1intc 3>, <&cpu1intc 7>, + <&cpu2intc 3>, <&cpu2intc 7>, + <&cpu3intc 3>, <&cpu3intc 7>, + <&cpu4intc 3>, <&cpu4intc 7>; reg = <0x2000000 0x10000>; }; ... -- 2.25.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > The number of interrupts lacks an upper bound, thus assuming one, > causing properly grouped "interrupts-extended" properties to be flagged > as an error by "make dtbs_check". > > Fix this by adding the missing "maxItems". As the architectural maximum > is 4095 interrupts, using that as the limit would be unpractical. Hence > limit it to 10 interrupts (two interrupts for a system management core, > and two interrupts per core for other cores). This should be sufficient > for now, and the limit can always be increased when the need arises. Same comment as the PLIC DT binding patch. The "maxItems" should represent CLINT spec constraints so please don't add any synthetic value here. Regards, Anup > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Acked-by: Rob Herring <robh@kernel.org> > --- > v3: > - Add Acked-by, > > v2: > - Split in two patches, > - Improve patch description and document limit rationale. > --- > Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > index 8d5f4687add9e81e..b75fd6f982b1ecb3 100644 > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > @@ -44,6 +44,7 @@ properties: > > interrupts-extended: > minItems: 1 > + maxItems: 10 > > additionalProperties: false > > -- > 2.25.1 >
On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > The number of interrupts lacks an upper bound, thus assuming one, > causing properly grouped "interrupts-extended" properties to be flagged > as an error by "make dtbs_check". > > Fix this by adding the missing "maxItems". As the architectural maximum > is 4095 interrupts, using that as the limit would be unpractical. Hence > limit it to 10 interrupts (two interrupts for a system management core, > and two interrupts per core for other cores). This should be sufficient > for now, and the limit can always be increased when the need arises. Same comment as the PLIC DT binding patch. The "maxItems" should represent CLINT spec constraints so please don't add any synthetic value here. Regards, Anup > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Acked-by: Rob Herring <robh@kernel.org> > --- > v3: > - Add Acked-by, > > v2: > - Split in two patches, > - Improve patch description and document limit rationale. > --- > Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > index 8d5f4687add9e81e..b75fd6f982b1ecb3 100644 > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > @@ -44,6 +44,7 @@ properties: > > interrupts-extended: > minItems: 1 > + maxItems: 10 > > additionalProperties: false > > -- > 2.25.1 > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
On Fri, Dec 17, 2021 at 01:38:04PM +0100, Geert Uytterhoeven wrote: > To improve human readability and enable automatic validation, the tuples > in "interrupts-extended" properties should be grouped using angle > brackets. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > v3: > - Add Reviewed-by, Did you? ;) Reviewed-by: Rob Herring <robh@kernel.org> > > v2: > - Split in two patches. > --- > Documentation/devicetree/bindings/timer/sifive,clint.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > index b75fd6f982b1ecb3..3b25ec37d81159cb 100644 > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > @@ -57,10 +57,10 @@ examples: > - | > timer@2000000 { > compatible = "sifive,fu540-c000-clint", "sifive,clint0"; > - interrupts-extended = <&cpu1intc 3 &cpu1intc 7 > - &cpu2intc 3 &cpu2intc 7 > - &cpu3intc 3 &cpu3intc 7 > - &cpu4intc 3 &cpu4intc 7>; > + interrupts-extended = <&cpu1intc 3>, <&cpu1intc 7>, > + <&cpu2intc 3>, <&cpu2intc 7>, > + <&cpu3intc 3>, <&cpu3intc 7>, > + <&cpu4intc 3>, <&cpu4intc 7>; > reg = <0x2000000 0x10000>; > }; > ... > -- > 2.25.1 > >
On Fri, Dec 17, 2021 at 01:38:04PM +0100, Geert Uytterhoeven wrote: > To improve human readability and enable automatic validation, the tuples > in "interrupts-extended" properties should be grouped using angle > brackets. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > v3: > - Add Reviewed-by, Did you? ;) Reviewed-by: Rob Herring <robh@kernel.org> > > v2: > - Split in two patches. > --- > Documentation/devicetree/bindings/timer/sifive,clint.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > index b75fd6f982b1ecb3..3b25ec37d81159cb 100644 > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > @@ -57,10 +57,10 @@ examples: > - | > timer@2000000 { > compatible = "sifive,fu540-c000-clint", "sifive,clint0"; > - interrupts-extended = <&cpu1intc 3 &cpu1intc 7 > - &cpu2intc 3 &cpu2intc 7 > - &cpu3intc 3 &cpu3intc 7 > - &cpu4intc 3 &cpu4intc 7>; > + interrupts-extended = <&cpu1intc 3>, <&cpu1intc 7>, > + <&cpu2intc 3>, <&cpu2intc 7>, > + <&cpu3intc 3>, <&cpu3intc 7>, > + <&cpu4intc 3>, <&cpu4intc 7>; > reg = <0x2000000 0x10000>; > }; > ... > -- > 2.25.1 > > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
On Fri, Dec 17, 2021 at 6:48 AM Anup Patel <anup@brainfault.org> wrote:
>
> On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > The number of interrupts lacks an upper bound, thus assuming one,
> > causing properly grouped "interrupts-extended" properties to be flagged
> > as an error by "make dtbs_check".
> >
> > Fix this by adding the missing "maxItems". As the architectural maximum
> > is 4095 interrupts, using that as the limit would be unpractical. Hence
> > limit it to 10 interrupts (two interrupts for a system management core,
> > and two interrupts per core for other cores). This should be sufficient
> > for now, and the limit can always be increased when the need arises.
>
> Same comment as the PLIC DT binding patch.
>
> The "maxItems" should represent CLINT spec constraints so
> please don't add any synthetic value here.
I agree.
Geert, are you going to respin these?
Rob
On Fri, Dec 17, 2021 at 6:48 AM Anup Patel <anup@brainfault.org> wrote: > > On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > The number of interrupts lacks an upper bound, thus assuming one, > > causing properly grouped "interrupts-extended" properties to be flagged > > as an error by "make dtbs_check". > > > > Fix this by adding the missing "maxItems". As the architectural maximum > > is 4095 interrupts, using that as the limit would be unpractical. Hence > > limit it to 10 interrupts (two interrupts for a system management core, > > and two interrupts per core for other cores). This should be sufficient > > for now, and the limit can always be increased when the need arises. > > Same comment as the PLIC DT binding patch. > > The "maxItems" should represent CLINT spec constraints so > please don't add any synthetic value here. I agree. Geert, are you going to respin these? Rob _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
Hi Rob,
On Wed, Jan 26, 2022 at 8:37 PM Rob Herring <robh+dt@kernel.org> wrote:
> On Fri, Dec 17, 2021 at 6:48 AM Anup Patel <anup@brainfault.org> wrote:
> > On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > The number of interrupts lacks an upper bound, thus assuming one,
> > > causing properly grouped "interrupts-extended" properties to be flagged
> > > as an error by "make dtbs_check".
> > >
> > > Fix this by adding the missing "maxItems". As the architectural maximum
> > > is 4095 interrupts, using that as the limit would be unpractical. Hence
> > > limit it to 10 interrupts (two interrupts for a system management core,
> > > and two interrupts per core for other cores). This should be sufficient
> > > for now, and the limit can always be increased when the need arises.
> >
> > Same comment as the PLIC DT binding patch.
> >
> > The "maxItems" should represent CLINT spec constraints so
> > please don't add any synthetic value here.
>
> I agree.
>
> Geert, are you going to respin these?
Sure, will do, now we have an agreement.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Rob, On Wed, Jan 26, 2022 at 8:37 PM Rob Herring <robh+dt@kernel.org> wrote: > On Fri, Dec 17, 2021 at 6:48 AM Anup Patel <anup@brainfault.org> wrote: > > On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > The number of interrupts lacks an upper bound, thus assuming one, > > > causing properly grouped "interrupts-extended" properties to be flagged > > > as an error by "make dtbs_check". > > > > > > Fix this by adding the missing "maxItems". As the architectural maximum > > > is 4095 interrupts, using that as the limit would be unpractical. Hence > > > limit it to 10 interrupts (two interrupts for a system management core, > > > and two interrupts per core for other cores). This should be sufficient > > > for now, and the limit can always be increased when the need arises. > > > > Same comment as the PLIC DT binding patch. > > > > The "maxItems" should represent CLINT spec constraints so > > please don't add any synthetic value here. > > I agree. > > Geert, are you going to respin these? Sure, will do, now we have an agreement. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv