From: Ritesh Harjani <riteshh@linux.ibm.com>
To: linux-ext4@vger.kernel.org
Cc: Harshad Shirwadkar <harshadshirwadkar@gmail.com>,
"Theodore Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Ritesh Harjani <riteshh@linux.ibm.com>
Subject: [RFC 0/9] ext4: Improve FC trace events and discuss one FC failure
Date: Wed, 23 Feb 2022 02:04:08 +0530 [thread overview]
Message-ID: <cover.1645558375.git.riteshh@linux.ibm.com> (raw)
Hello,
Sending this RFC out for getting some review comments/suggestions on the
problem listed in this cover letter. It would be helpful if someone has any
pointers around these.
1. Patch-2 fixes the problem reported by Steven about dereferencing pointers from
the ring buffer [1].
One of the problem in this patch which I might need some help is, how to
expose EXT4_FC_REASON_MAX enum for
+ __array(unsigned int, fc_ineligible_rc, EXT4_FC_REASON_MAX)
My observation is that this trace_event is correctly printing the array
values when called from cat /sys/kernel/debug/tracing/trace_pipe.
But when I am using perf record -e ext4:ext4_fc_stats to record these trace
events, I am seeing the array values to be all 0.
Do you know what will be the right and easy way to fix above, so that this works
properly for perf tools too? And we should be able to backport this too.
2. Patch-9 discusses one of the problem where FC might miss to track/commit
inode's update. This also needs some discussion. I have added my observations
on the commit log of patch-9 itself.
3. Remaining are FC trace event improvement patches, which I found useful while
debugging some of the recent fast_commit issues.
Also a careful review of patches is always helpful :)
[1]: https://lore.kernel.org/linux-ext4/20220221160916.333e6491@rorschach.local.home/T/#u
Ritesh Harjani (9):
ext4: Remove unused enum EXT4_FC_COMMIT_FAILED
ext4: Fix ext4_fc_stats trace point
ext4: Add couple of more fast_commit tracepoints
ext4: Do not call FC trace event if FS does not support FC
ext4: Add commit_tid info in jbd debug log
ext4: Add commit tid info in ext4_fc_commit_start/stop trace events
ext4: Fix remaining two trace events to use same printk convention
ext4: Convert ext4_fc_track_dentry type events to use event class
ext4: fast_commit missing tracking updates to a file
fs/ext4/fast_commit.c | 30 +++--
fs/ext4/fast_commit.h | 1 -
include/trace/events/ext4.h | 229 +++++++++++++++++++++++++-----------
3 files changed, 182 insertions(+), 78 deletions(-)
--
2.31.1
next reply other threads:[~2022-02-22 20:34 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 20:34 Ritesh Harjani [this message]
2022-02-22 20:34 ` [RFC 1/9] ext4: Remove unused enum EXT4_FC_COMMIT_FAILED Ritesh Harjani
2022-02-23 9:37 ` Jan Kara
2022-02-27 18:27 ` harshad shirwadkar
2022-02-22 20:34 ` [RFC 2/9] ext4: Fix ext4_fc_stats trace point Ritesh Harjani
2022-02-22 20:52 ` Steven Rostedt
2022-02-23 9:54 ` Jan Kara
2022-02-27 18:29 ` harshad shirwadkar
2022-02-22 20:34 ` [RFC 3/9] ext4: Add couple of more fast_commit tracepoints Ritesh Harjani
2022-02-23 9:40 ` Jan Kara
2022-02-23 10:11 ` Ritesh Harjani
2022-02-23 11:53 ` Jan Kara
2022-02-23 12:04 ` Ritesh Harjani
2022-02-22 20:34 ` [RFC 4/9] ext4: Do not call FC trace event if FS does not support FC Ritesh Harjani
2022-02-23 9:41 ` Jan Kara
2022-02-27 18:30 ` harshad shirwadkar
2022-02-22 20:34 ` [RFC 5/9] ext4: Add commit_tid info in jbd debug log Ritesh Harjani
2022-02-23 9:42 ` Jan Kara
2022-02-27 18:31 ` harshad shirwadkar
2022-02-22 20:34 ` [RFC 6/9] ext4: Add commit tid info in ext4_fc_commit_start/stop trace events Ritesh Harjani
2022-02-23 9:44 ` Jan Kara
2022-02-27 18:31 ` harshad shirwadkar
2022-02-22 20:34 ` [RFC 7/9] ext4: Fix remaining two trace events to use same printk convention Ritesh Harjani
2022-02-23 9:45 ` Jan Kara
2022-02-27 18:32 ` harshad shirwadkar
2022-02-22 20:34 ` [RFC 8/9] ext4: Convert ext4_fc_track_dentry type events to use event class Ritesh Harjani
2022-02-23 9:49 ` Jan Kara
2022-02-27 18:35 ` harshad shirwadkar
2022-02-22 20:34 ` [RFC 9/9] ext4: fast_commit missing tracking updates to a file Ritesh Harjani
2022-02-23 3:50 ` [External] " Xin Yin
2022-02-23 13:58 ` Ritesh Harjani
2022-02-24 11:43 ` Xin Yin
2022-02-27 20:51 ` harshad shirwadkar
2022-03-09 17:48 ` [RFC 0/9] ext4: Improve FC trace events and discuss one FC failure Theodore Ts'o
2022-03-10 1:22 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1645558375.git.riteshh@linux.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=harshadshirwadkar@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.