From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>
Subject: [PATCH v4 0/7] 9pfs: fix 'Twalk' protocol violation
Date: Tue, 15 Mar 2022 11:10:25 +0100 [thread overview]
Message-ID: <cover.1647339025.git.qemu_oss@crudebyte.com> (raw)
Currently the implementation of 'Twalk' does not behave exactly as specified
by the 9p2000 protocol specification. Actual fix is patch 5; see the
description of that patch for details of what this overall fix and series is
about.
PREREQUISITES
=============
This series requires the following additional patch to work correctly:
https://lore.kernel.org/qemu-devel/E1nTpyU-0000yR-9o@lizzy.crudebyte.com/
OVERVIEW OF PATCHES
===================
Patch 4 is a preparatory (pure) refactoring change to make actual 'Twalk' fix
patch 5 better readable.
All the other patches are just additional test cases for guarding 'Twalk'
behaviour.
v3 -> v4:
* QID returned by Twalk request in fs_walk_2nd_nonexistent() test should NOT
be identical to root node's QID. [patch 7]
* Fix actual 'fid unaffected' check in fs_walk_2nd_nonexistent() test by
sending a subsequent 'Tgetattr' request. [patch 7]
Christian Schoenebeck (7):
tests/9pfs: walk to non-existent dir
tests/9pfs: Twalk with nwname=0
tests/9pfs: compare QIDs in fs_walk_none() test
9pfs: refactor 'name_idx' -> 'nwalked' in v9fs_walk()
9pfs: fix 'Twalk' to only send error if no component walked
tests/9pfs: guard recent 'Twalk' behaviour fix
tests/9pfs: check fid being unaffected in fs_walk_2nd_nonexistent
hw/9pfs/9p.c | 57 ++++++----
tests/qtest/virtio-9p-test.c | 201 ++++++++++++++++++++++++++++++++++-
2 files changed, 231 insertions(+), 27 deletions(-)
--
2.30.2
next reply other threads:[~2022-03-15 10:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 10:10 Christian Schoenebeck [this message]
2022-03-15 10:08 ` [PATCH v4 1/7] tests/9pfs: walk to non-existent dir Christian Schoenebeck
2022-03-15 10:08 ` [PATCH v4 2/7] tests/9pfs: Twalk with nwname=0 Christian Schoenebeck
2022-03-15 10:08 ` [PATCH v4 3/7] tests/9pfs: compare QIDs in fs_walk_none() test Christian Schoenebeck
2022-06-15 15:08 ` Greg Kurz
2022-03-15 10:08 ` [PATCH v4 4/7] 9pfs: refactor 'name_idx' -> 'nwalked' in v9fs_walk() Christian Schoenebeck
2022-03-15 10:08 ` [PATCH v4 5/7] 9pfs: fix 'Twalk' to only send error if no component walked Christian Schoenebeck
2022-06-15 15:52 ` Greg Kurz
2022-06-15 16:36 ` Christian Schoenebeck
2022-06-16 10:17 ` Greg Kurz
2022-03-15 10:08 ` [PATCH v4 6/7] tests/9pfs: guard recent 'Twalk' behaviour fix Christian Schoenebeck
2022-03-15 10:08 ` [PATCH v4 7/7] tests/9pfs: check fid being unaffected in fs_walk_2nd_nonexistent Christian Schoenebeck
2022-06-15 15:57 ` Greg Kurz
2022-03-29 10:21 ` [PATCH v4 0/7] 9pfs: fix 'Twalk' protocol violation Christian Schoenebeck
2022-03-29 10:59 ` Greg Kurz
2022-06-16 10:53 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1647339025.git.qemu_oss@crudebyte.com \
--to=qemu_oss@crudebyte.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.