From: Geliang Tang <geliang.tang@suse.com>
To: mptcp@lists.linux.dev
Cc: Geliang Tang <geliang.tang@suse.com>
Subject: [PATCH mptcp-next v7 0/8] BPF packet scheduler
Date: Mon, 28 Mar 2022 17:37:54 +0800 [thread overview]
Message-ID: <cover.1648459865.git.geliang.tang@suse.com> (raw)
v7:
- add bpf_try_module_get in mptcp_init_sched.
- add bpf_module_put in mptcp_release_sched.
- rename bpf_first to mptcp_bpf_first.
- update commit logs.
- depends on: "add skc_to_mptcp_sock" v14.
- export/20220325T055307
v6:
- still use pernet sched_list, use current->nsproxy->net_ns in BPF
context instead of using init_net.
- patch 1:
- use rcu_read_lock instead of spin_lock in mptcp_sched_find as Florian suggested.
- drop synchronize_rcu in sched_exit_net as Florian suggested.
- keep synchronize_rcu in mptcp_unregister_scheduler, otherwise, got
a workqueue lockup in my test.
- update Makefile as Mat suggested.
- patch 2:
- add mptcp_sched_data_init to register default sched, instead of
registering it in init_net.
- patch 5:
- move mptcp_sched_get_subflow to protocol.h as Mat suggested.
- patch 6:
- use current->nsproxy->net_ns instead of init_net.
- patch 8:
- add send_data to send more data, instead of send_byte.
v5:
- patch 1: define per-namespace sched_list (but only used init_net
namespace. It is difficult to get 'net' in bpf_mptcp_sched_reg and
bpf_mptcp_sched_unreg. I need some suggestions here.)
- patch 2: skip mptcp_sched_default in mptcp_unregister_scheduler.
- patch 8: add tests into mptcp.c, instead of bpf_tcp_ca.c.
v4:
- set msk->sched to &mptcp_sched_default when the sched argument is NULL
in mptcp_init_sched().
v3:
- add mptcp_release_sched helper in patch 4.
- rename mptcp_set_sched to mptcp_init_sched in patch 4.
- add mptcp_sched_first_release in patch 7.
- do some cleanups.
v2:
- split into more small patches.
- change all parameters of mptcp_sched_ops from sk to msk:
void (*init)(struct mptcp_sock *msk);
void (*release)(struct mptcp_sock *msk);
struct sock * (*get_subflow)(struct mptcp_sock *msk);
- add tests in bpf_tcp_ca.c, instead of adding a new one.
v1:
- Addressed to the commends in the RFC version.
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/75
Geliang Tang (8):
mptcp: add struct mptcp_sched_ops
mptcp: register default scheduler
mptcp: add a new sysctl scheduler
mptcp: add sched in mptcp_sock
mptcp: add get_subflow wrapper
mptcp: add bpf_mptcp_sched_ops
selftests: bpf: add mptcp_bpf_first scheduler
selftests: bpf: add mptcp_bpf_first test
Documentation/networking/mptcp-sysctl.rst | 8 +
include/net/mptcp.h | 13 ++
kernel/bpf/bpf_struct_ops_types.h | 4 +
net/mptcp/Makefile | 2 +-
net/mptcp/bpf.c | 103 ++++++++++++
net/mptcp/ctrl.c | 14 ++
net/mptcp/protocol.c | 14 +-
net/mptcp/protocol.h | 20 +++
net/mptcp/sched.c | 154 ++++++++++++++++++
tools/testing/selftests/bpf/bpf_tcp_helpers.h | 12 ++
.../testing/selftests/bpf/prog_tests/mptcp.c | 114 +++++++++++++
.../selftests/bpf/progs/mptcp_bpf_first.c | 30 ++++
12 files changed, 483 insertions(+), 5 deletions(-)
create mode 100644 net/mptcp/sched.c
create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_first.c
--
2.34.1
next reply other threads:[~2022-03-28 9:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 9:37 Geliang Tang [this message]
2022-03-28 9:37 ` [PATCH mptcp-next v7 1/8] mptcp: add struct mptcp_sched_ops Geliang Tang
2022-03-28 9:49 ` Florian Westphal
2022-03-28 13:11 ` Geliang Tang
2022-03-28 13:49 ` Florian Westphal
2022-03-28 9:37 ` [PATCH mptcp-next v7 2/8] mptcp: register default scheduler Geliang Tang
2022-03-28 9:37 ` [PATCH mptcp-next v7 3/8] mptcp: add a new sysctl scheduler Geliang Tang
2022-03-28 9:37 ` [PATCH mptcp-next v7 4/8] mptcp: add sched in mptcp_sock Geliang Tang
2022-03-28 9:51 ` Florian Westphal
2022-03-28 22:47 ` Mat Martineau
2022-03-28 9:37 ` [PATCH mptcp-next v7 5/8] mptcp: add get_subflow wrapper Geliang Tang
2022-03-28 9:38 ` [PATCH mptcp-next v7 6/8] mptcp: add bpf_mptcp_sched_ops Geliang Tang
2022-03-28 9:38 ` [PATCH mptcp-next v7 7/8] selftests: bpf: add mptcp_bpf_first scheduler Geliang Tang
2022-03-28 9:38 ` [PATCH mptcp-next v7 8/8] selftests: bpf: add mptcp_bpf_first test Geliang Tang
2022-03-28 22:49 ` Mat Martineau
2022-03-30 17:03 ` selftests: bpf: add mptcp_bpf_first test: Build Failure MPTCP CI
2022-03-30 21:10 ` selftests: bpf: add mptcp_bpf_first test: Tests Results MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1648459865.git.geliang.tang@suse.com \
--to=geliang.tang@suse.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.