From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BAC1C433F5 for ; Wed, 25 May 2022 10:10:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240622AbiEYKK0 (ORCPT ); Wed, 25 May 2022 06:10:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232731AbiEYKKU (ORCPT ); Wed, 25 May 2022 06:10:20 -0400 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 301309158B for ; Wed, 25 May 2022 03:10:19 -0700 (PDT) Received: from localhost.localdomain (unknown [80.240.223.29]) by mail.ispras.ru (Postfix) with ESMTPSA id 1994540D4004; Wed, 25 May 2022 10:10:17 +0000 (UTC) From: Evgeniy Baskov To: Borislav Petkov Cc: Evgeniy Baskov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 0/5] Parse CONFIG_CMDLINE in compressed kernel Date: Wed, 25 May 2022 13:10:08 +0300 Message-Id: X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220505103224.21667-1-baskov@ispras.ru> References: <20220505103224.21667-1-baskov@ispras.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CONFIG_CMDLINE_BOOL and CONFIG_CMDLINE_OVERRIDE were ignored during options lookup in compressed kernel, including earlyprintk option, so it was impossible to get earlyprintk messages from that stage of boot process via command line provided at compile time. Being able to enable earlyprintk via compile-time option might be desirable for booting on systems with broken UEFI command line arguments via EFISTUB. Changes in v2: * Compute resulting cmdline string once if needed and then reuse it. Store concatenation result in a static buffer. * Add strlcat() to compressed kernel to simplify the code. Changes in v3: v2 had a bug: cmd_line_ptr was set to a pointer to a buffer inside a kernel before kernel relocation, that makes this pointer invalid. * Replace the pointer by a boolean variable to avoid storing a pointer, since it becomes invalid during kernel relocation. Changes in v4: * Use better wording for commit messages. * Add buffer overflow check to strlcat(). * Factor out common logic of cmdline resolving into helper function. Evgeniy Baskov (5): x86/boot: Add strlcat() to compressed kernel x86: Add resolve_cmdline() helper x86/setup: Use resolve_cmdline() in setup.c x86/boot: Use resolve_cmdline() in compressed kernel x86/boot: Remove no longer needed includes arch/x86/boot/compressed/cmdline.c | 24 +++++++++++-- arch/x86/boot/compressed/ident_map_64.c | 4 --- arch/x86/boot/compressed/kaslr.c | 4 --- arch/x86/boot/compressed/misc.h | 1 + arch/x86/boot/compressed/string.c | 19 +++++++++++ arch/x86/include/asm/shared/setup-cmdline.h | 38 +++++++++++++++++++++ arch/x86/kernel/setup.c | 22 +++--------- arch/x86/purgatory/purgatory.c | 1 + 8 files changed, 85 insertions(+), 28 deletions(-) create mode 100644 arch/x86/include/asm/shared/setup-cmdline.h -- 2.36.1