From: Qiao Ma <mqaio@linux.alibaba.com>
To: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
kuba@kernel.org, gustavoars@kernel.org, cai.huoqing@linux.dev
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next v4 0/2] net: hinic: fix bugs about dev_get_stats
Date: Tue, 5 Jul 2022 19:22:21 +0800 [thread overview]
Message-ID: <cover.1657019475.git.mqaio@linux.alibaba.com> (raw)
These patches fixes 2 bugs of hinic driver:
- fix bug that ethtool get wrong stats because of hinic_{txq|rxq}_clean_stats() is called
- avoid kernel hung in hinic_get_stats64()
See every patch for more information.
Changes in v4:
- removed meaningless u64_stats_sync protection in hinic_{txq|rxq}_get_stats
- merged the third patch in v2 into first one
Changes in v3:
- fixes a compile warning reported by kernel test robot <lkp@intel.com>
Changes in v2:
- fixes another 2 bugs. (v1 is a single patch, see: https://lore.kernel.org/all/07736c2b7019b6883076a06129e06e8f7c5f7154.1656487154.git.mqaio@linux.alibaba.com/).
- to fix extra bugs, hinic_dev.tx_stats/rx_stats is removed, so there is no need to use spinlock or semaphore now.
Qiao Ma (2):
net: hinic: fix bug that ethtool get wrong stats
net: hinic: avoid kernel hung in hinic_get_stats64()
drivers/net/ethernet/huawei/hinic/hinic_dev.h | 3 --
drivers/net/ethernet/huawei/hinic/hinic_main.c | 61 +++++++-------------------
drivers/net/ethernet/huawei/hinic/hinic_rx.c | 2 -
drivers/net/ethernet/huawei/hinic/hinic_tx.c | 2 -
4 files changed, 16 insertions(+), 52 deletions(-)
--
1.8.3.1
next reply other threads:[~2022-07-05 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 11:22 Qiao Ma [this message]
2022-07-05 11:22 ` [PATCH net-next v4 1/2] net: hinic: fix bug that ethtool get wrong stats Qiao Ma
2022-07-05 11:22 ` [PATCH net-next v4 2/2] net: hinic: avoid kernel hung in hinic_get_stats64() Qiao Ma
2022-07-06 22:10 ` [PATCH net-next v4 0/2] net: hinic: fix bugs about dev_get_stats patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1657019475.git.mqaio@linux.alibaba.com \
--to=mqaio@linux.alibaba.com \
--cc=cai.huoqing@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.