From: Stefan Metzmacher <metze@samba.org>
To: io-uring@vger.kernel.org, axboe@kernel.dk, asml.silence@gmail.com
Cc: Stefan Metzmacher <metze@samba.org>
Subject: [PATCH for-6.0 0/5] IORING_OP_SEND_ZC improvements
Date: Fri, 16 Sep 2022 23:36:24 +0200 [thread overview]
Message-ID: <cover.1663363798.git.metze@samba.org> (raw)
Hi Pavel, hi Jens,
I did some initial testing with IORING_OP_SEND_ZC.
While reading the code I think I found a race that
can lead to IORING_CQE_F_MORE being missing even if
the net layer got references.
While there I added some code to allow userpace to
know how effective the IORING_OP_SEND_ZC attempt was,
in order to avoid it it's not used (e.g. on a long living tcp
connection).
This change requires a change to the existing test, see:
https://github.com/metze-samba/liburing/tree/test-send-zerocopy
Stefan Metzmacher (5):
io_uring/opdef: rename SENDZC_NOTIF to SEND_ZC
io_uring/core: move io_cqe->fd over from io_cqe->flags to io_cqe->res
io_uring/core: keep req->cqe.flags on generic errors
io_uring/net: let io_sendzc set IORING_CQE_F_MORE before
sock_sendmsg()
io_uring/notif: let userspace know how effective the zero copy usage
was
include/linux/io_uring_types.h | 6 +++---
io_uring/io_uring.c | 18 +++++++++++++-----
io_uring/net.c | 19 +++++++++++++------
io_uring/notif.c | 18 ++++++++++++++++++
io_uring/opdef.c | 2 +-
net/ipv4/ip_output.c | 3 ++-
net/ipv4/tcp.c | 2 ++
net/ipv6/ip6_output.c | 3 ++-
8 files changed, 54 insertions(+), 17 deletions(-)
--
2.34.1
next reply other threads:[~2022-09-16 21:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 21:36 Stefan Metzmacher [this message]
2022-09-16 21:36 ` [PATCH 1/5] io_uring/opdef: rename SENDZC_NOTIF to SEND_ZC Stefan Metzmacher
2022-09-17 9:17 ` Pavel Begunkov
2022-09-16 21:36 ` [PATCH 2/5] io_uring/core: move io_cqe->fd over from io_cqe->flags to io_cqe->res Stefan Metzmacher
2022-09-16 21:36 ` [PATCH 3/5] io_uring/core: keep req->cqe.flags on generic errors Stefan Metzmacher
2022-09-16 21:36 ` [PATCH 4/5] io_uring/net: let io_sendzc set IORING_CQE_F_MORE before sock_sendmsg() Stefan Metzmacher
2022-09-16 21:36 ` [PATCH 5/5] io_uring/notif: let userspace know how effective the zero copy usage was Stefan Metzmacher
2022-09-17 9:22 ` Pavel Begunkov
2022-09-17 10:24 ` Stefan Metzmacher
2022-09-21 12:04 ` Pavel Begunkov
2022-09-21 12:33 ` Stefan Metzmacher
2022-09-17 9:16 ` [PATCH for-6.0 0/5] IORING_OP_SEND_ZC improvements Pavel Begunkov
2022-09-17 10:44 ` Stefan Metzmacher
2022-09-21 11:39 ` Pavel Begunkov
2022-09-21 12:18 ` Stefan Metzmacher
2022-09-21 12:58 ` Pavel Begunkov
2022-09-18 22:49 ` (subset) " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1663363798.git.metze@samba.org \
--to=metze@samba.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.