From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B6997B; Thu, 20 Oct 2022 21:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666301176; bh=ibzGFol51WWHH1kAZe6QOOvlh+zMJhgtwaluS+pfjKo=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:MIME-Version: Content-Type; b=GaLXFnyiaSpTngMuEfh8nxTIumTnBEP1AwbhNoBFpPg1habkNXoiGsRY8mTCI2nVP 2+Kcck/mr17SmpiLn8m9H2o3R6uspxM25bHybTaz4/CVyNeahz3I4N/YgdhbDbhd+L nlmYKQ7LH6qZepzgkVihAoUKD0iCH2mlpphZKGFg= Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP via [213.182.55.206] Thu, 20 Oct 2022 23:26:16 +0200 (CEST) X-EA-Auth: JE9KFmpUaJpP3Y1Ti1VTiLP+tKc//LVPG0j41IQ1zfzKaCfv/DmG0sYiOyy2mj572pLPj8eMZc98oeUov4bPR0sZO/MrFq1u Date: Fri, 21 Oct 2022 02:56:10 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Larry.Finger@lwfinger.net, phil@philpotter.co.uk, paskripkin@gmail.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com Subject: [PATCH v4 00/11] staging: r8188eu: trivial code cleanup patches Message-ID: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Address different kinds of checkpatch complains for the staging/r8188eu module. The patches are required to be applied in sequence. Changes in v4: 1. Include patch 11 in the set for unused macro clean up. Suggested by julia.lawall@inria.fr 2. Update patch 1 per feedback from David.Laight@ACULAB.COM 3. Update patch 5 & 6 per feedback from dan.carpenter@oracle.com & julia.lawall@inria.fr Changes in v3: 1. Patch 4: Extend the __constant_htons to htons change to other files of the driver. This was suggested by philipp.g.hortmann@gmail.com 2. Patch 4: Spelling mistake corrected as pointed out by joe@perches.com 3. Patch 5 through 10: Included in this version. Additional clean up patches. Changes in v2: I incorrectly labeled the first revision as v1 instead of v2. So, following change recorded under v1 is actually changes for v2. Feedback provided by philipp.g.hortmann@gmail.com 1. Improve language / grammar for the patch descriptions 2. Further improve code reformatting Deepak R Varma (11): staging: r8188eu: use Linux kernel variable naming convention staging: r8188eu: reformat long computation lines staging: r8188eu: remove {} for single statement blocks staging: r8188eu: use htons macro instead of __constant_htons staging: r8188eu: correct misspelled words in comments staging: r8188eu: Add space between function & macro parameters staging: r8188eu: Associate pointer symbol with parameter name staging: r8188eu: replace leading spaces by tabs staging: r8188eu: Put '{" on the symbol declaration line staging: r8188eu: Correct missing or extra space in the statements staging: r8188eu: Remove unused macros drivers/staging/r8188eu/core/rtw_br_ext.c | 119 +++++++++--------- drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 36 +++--- drivers/staging/r8188eu/core/rtw_recv.c | 8 +- drivers/staging/r8188eu/core/rtw_xmit.c | 14 +-- drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 2 +- drivers/staging/r8188eu/hal/odm_RTL8188E.c | 2 +- .../staging/r8188eu/hal/rtl8188e_hal_init.c | 2 +- drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 16 +-- .../staging/r8188eu/include/Hal8188EPhyReg.h | 4 +- .../staging/r8188eu/include/osdep_service.h | 4 +- .../staging/r8188eu/include/rtl8188e_hal.h | 6 +- .../staging/r8188eu/include/rtl8188e_spec.h | 18 +-- drivers/staging/r8188eu/include/rtw_cmd.h | 62 +++++---- drivers/staging/r8188eu/include/rtw_io.h | 16 +-- .../staging/r8188eu/include/rtw_ioctl_set.h | 4 +- drivers/staging/r8188eu/include/rtw_mlme.h | 22 ++-- .../staging/r8188eu/include/rtw_mlme_ext.h | 12 +- drivers/staging/r8188eu/include/rtw_recv.h | 4 +- drivers/staging/r8188eu/include/rtw_xmit.h | 2 +- drivers/staging/r8188eu/include/wifi.h | 12 +- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 6 +- 22 files changed, 176 insertions(+), 197 deletions(-) -- 2.30.2