All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	laurent.pinchart@ideasonboard.com
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Subject: [PATCH v1 0/2] drm: rcar-du: Repair vblank event handling
Date: Thu, 29 Jun 2017 15:02:54 +0100	[thread overview]
Message-ID: <cover.22236bc88adc598797b31ea82329ec99304fe34d.1498744799.git-series.kieran.bingham+renesas@ideasonboard.com> (raw)

The recent changes to the rcar-du driver to fix a race condition inadvertently
change the order of which vblanks are reported.

Correct this by handling vblank events in the same completion handler. This
removes the need for the IRQ handler on DU instances which are sourced by a
VSP1.

For other platforms (Gen2) the vblank handler was enabling the VBK interrupt,
but parsing on the FRM interrupt. Fix this by enabling the FRM interrupt using
the FRE bit in the DIER register

Kieran Bingham (2):
  drm: rcar-du: Enable the FRM interrupt for vblank
  drm: rcar-du: Repair vblank for DRM page flips using the VSP1

 drivers/gpu/drm/rcar-du/rcar_du_crtc.c   | 25 ++++++++++++++++++++-----
 drivers/gpu/drm/rcar-du/rcar_du_crtc.h   |  2 ++-
 drivers/gpu/drm/rcar-du/rcar_du_vsp.c    |  8 ++++++--
 drivers/media/platform/vsp1/vsp1_drm.c   |  5 +++--
 drivers/media/platform/vsp1/vsp1_drm.h   |  2 +-
 drivers/media/platform/vsp1/vsp1_pipe.c  | 20 ++++++++++----------
 drivers/media/platform/vsp1/vsp1_pipe.h  |  2 +-
 drivers/media/platform/vsp1/vsp1_video.c |  6 +++++-
 include/media/vsp1.h                     |  2 +-
 9 files changed, 49 insertions(+), 23 deletions(-)

base-commit: fa5b4114202de0c1a7a64fd407af0b81ca529419
-- 
git-series 0.9.1

             reply	other threads:[~2017-06-29 14:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 14:02 Kieran Bingham [this message]
2017-06-29 14:02 ` [PATCH v1 1/2] drm: rcar-du: Enable the FRM interrupt for vblank Kieran Bingham
2017-06-29 14:02   ` Kieran Bingham
2017-06-29 14:02 ` [PATCH v1 2/2] drm: rcar-du: Repair vblank for DRM page flips using the VSP1 Kieran Bingham
2017-06-29 14:02   ` Kieran Bingham
2017-06-29 14:07   ` Kieran Bingham
2017-06-29 15:58 ` [PATCH v1.1 " Kieran Bingham
2017-06-29 15:58   ` Kieran Bingham
2017-06-30  8:32   ` Kuninori Morimoto
2017-06-30  8:32     ` Kuninori Morimoto
2017-07-02 14:23     ` Laurent Pinchart
2017-07-02 14:23       ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.22236bc88adc598797b31ea82329ec99304fe34d.1498744799.git-series.kieran.bingham+renesas@ideasonboard.com \
    --to=kieran.bingham+renesas@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.