From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: [PATCH 0/6] pinctrl: sunxi: Allow to configure pull-up / pull-down from GPIO flags Date: Thu, 14 Mar 2019 20:32:49 +0100 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Chen-Yu Tsai , Maxime Ripard , Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, Thomas Petazzoni , linux-arm-kernel@lists.infradead.org List-Id: linux-gpio@vger.kernel.org Hi, Here is a series that addresses one of the issues we've had for some time with our pinctrl driver, which is that while we should have had the strict mode enabled, we didn't and now we have to deal with all the DT having GPIO and pinctrl nodes for the same pins. This was partially due to cargo cult (which has been addressed since), but also due to technical limitations of the GPIO DT bindings at the time which didn't allow to specify the pull-up and pull-down resistors, and the drive strength of the pins. Now that the former are supported, we can remove those users, and we will deal with the latter eventually. Let me know what you think, Maxime Maxime Ripard (6): gpio: Set proper argument value to set_config pinctrl: sunxi: implement pin_config_set pinctrl: sunxi: Fix variable assignment syntax pinctrl: sunxi: Declare set_config on the GPIO chip ARM: dts: sunxi: Remove pinctrl groups setting bias ARM: dts: sunxi: Remove useless pinctrl nodes arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts | 20 +--- arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 10 +-- arch/arm/boot/dts/sun4i-a10-dserve-dsrv9703c.dts | 20 +--- arch/arm/boot/dts/sun4i-a10-hyundai-a7hd.dts | 20 +--- arch/arm/boot/dts/sun4i-a10-inet1.dts | 20 +--- arch/arm/boot/dts/sun4i-a10-inet97fv2.dts | 20 +--- arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts | 72 +++-------- arch/arm/boot/dts/sun4i-a10-marsboard.dts | 12 +-- arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 18 +--- arch/arm/boot/dts/sun4i-a10-pcduino.dts | 12 +-- arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts | 19 +--- arch/arm/boot/dts/sun5i-a10s-auxtek-t004.dts | 10 +-- arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 10 +-- arch/arm/boot/dts/sun5i-a13-empire-electronix-d709.dts | 20 +--- arch/arm/boot/dts/sun5i-a13-hsg-h702.dts | 12 +-- arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts | 18 +--- arch/arm/boot/dts/sun5i-a13-olinuxino.dts | 18 +--- arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 14 +-- arch/arm/boot/dts/sun5i-r8-chip.dts | 12 +-- arch/arm/boot/dts/sun5i-reference-design-tablet.dtsi | 20 +--- arch/arm/boot/dts/sun6i-a31-colombus.dts | 14 +-- arch/arm/boot/dts/sun6i-reference-design-tablet.dtsi | 12 +-- arch/arm/boot/dts/sun7i-a20-bananapi.dts | 10 +-- arch/arm/boot/dts/sun7i-a20-cubieboard2.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts | 18 +--- arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 18 +--- arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 18 +--- arch/arm/boot/dts/sun7i-a20-orangepi-mini.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-orangepi.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-pcduino3.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-wits-pro-a20-dkt.dts | 12 +-- arch/arm/boot/dts/sun8i-h3-nanopi.dtsi | 23 +---- arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 30 +----- arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts | 23 +---- arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 23 +---- arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 23 +---- arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 9 +- arch/arm/boot/dts/sun8i-r16-parrot.dts | 12 +-- arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi | 12 +-- drivers/gpio/gpiolib.c | 14 +- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 40 +++--- 44 files changed, 110 insertions(+), 662 deletions(-) base-commit: cf08baa29613dd899954089e7cc7dba1d478b365 -- git-series 0.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9394C4360F for ; Thu, 14 Mar 2019 19:33:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB420217F5 for ; Thu, 14 Mar 2019 19:33:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nAPxW/1i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB420217F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=PvJmRjpLKFL2obC/9jMT+/747mQwWv+RiZYf1Aiy+6U=; b=nAPxW/1inTIZPn vC35wxa7ioNxU5mufclLkbyWySCRIY2a8lMb2nHcoCztW3zhedpV1HO8PQIxDTtUMh9qFJzOiZm7e /P+at/UuWOYlqhh/68fub5mNcJP0G4eDx8QmBW7wIQ2TvYJhdffaoSqQr639Efovlxg4HVnK08TUi YaFfkCsCK1A+Kpj5jj3bucs4+QdCTP673CtToCRmKXttNVFPSEdU6BooQm+8T18s8bQ3qxMQ0wZfE kutSqI3ofuupIgDTMYGMlESoNzFzW8YkdHMyrLjzi89hxGMN4UQaLUJel9lRJ42Y2L7fJxAfUhJ6D +X2GlJB9l2r4giarBYUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4W6X-0003TR-BB; Thu, 14 Mar 2019 19:33:25 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4W6L-0003Gv-Mz for linux-arm-kernel@lists.infradead.org; Thu, 14 Mar 2019 19:33:15 +0000 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 7937C240002; Thu, 14 Mar 2019 19:33:01 +0000 (UTC) From: Maxime Ripard To: Chen-Yu Tsai , Maxime Ripard , Linus Walleij , Bartosz Golaszewski Subject: [PATCH 0/6] pinctrl: sunxi: Allow to configure pull-up / pull-down from GPIO flags Date: Thu, 14 Mar 2019 20:32:49 +0100 Message-Id: X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_123314_346504_94A448FE X-CRM114-Status: UNSURE ( 9.60 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, Thomas Petazzoni , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Here is a series that addresses one of the issues we've had for some time with our pinctrl driver, which is that while we should have had the strict mode enabled, we didn't and now we have to deal with all the DT having GPIO and pinctrl nodes for the same pins. This was partially due to cargo cult (which has been addressed since), but also due to technical limitations of the GPIO DT bindings at the time which didn't allow to specify the pull-up and pull-down resistors, and the drive strength of the pins. Now that the former are supported, we can remove those users, and we will deal with the latter eventually. Let me know what you think, Maxime Maxime Ripard (6): gpio: Set proper argument value to set_config pinctrl: sunxi: implement pin_config_set pinctrl: sunxi: Fix variable assignment syntax pinctrl: sunxi: Declare set_config on the GPIO chip ARM: dts: sunxi: Remove pinctrl groups setting bias ARM: dts: sunxi: Remove useless pinctrl nodes arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts | 20 +--- arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 10 +-- arch/arm/boot/dts/sun4i-a10-dserve-dsrv9703c.dts | 20 +--- arch/arm/boot/dts/sun4i-a10-hyundai-a7hd.dts | 20 +--- arch/arm/boot/dts/sun4i-a10-inet1.dts | 20 +--- arch/arm/boot/dts/sun4i-a10-inet97fv2.dts | 20 +--- arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts | 72 +++-------- arch/arm/boot/dts/sun4i-a10-marsboard.dts | 12 +-- arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 18 +--- arch/arm/boot/dts/sun4i-a10-pcduino.dts | 12 +-- arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts | 19 +--- arch/arm/boot/dts/sun5i-a10s-auxtek-t004.dts | 10 +-- arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 10 +-- arch/arm/boot/dts/sun5i-a13-empire-electronix-d709.dts | 20 +--- arch/arm/boot/dts/sun5i-a13-hsg-h702.dts | 12 +-- arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts | 18 +--- arch/arm/boot/dts/sun5i-a13-olinuxino.dts | 18 +--- arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 14 +-- arch/arm/boot/dts/sun5i-r8-chip.dts | 12 +-- arch/arm/boot/dts/sun5i-reference-design-tablet.dtsi | 20 +--- arch/arm/boot/dts/sun6i-a31-colombus.dts | 14 +-- arch/arm/boot/dts/sun6i-reference-design-tablet.dtsi | 12 +-- arch/arm/boot/dts/sun7i-a20-bananapi.dts | 10 +-- arch/arm/boot/dts/sun7i-a20-cubieboard2.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts | 18 +--- arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 18 +--- arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 18 +--- arch/arm/boot/dts/sun7i-a20-orangepi-mini.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-orangepi.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-pcduino3.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-wits-pro-a20-dkt.dts | 12 +-- arch/arm/boot/dts/sun8i-h3-nanopi.dtsi | 23 +---- arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 30 +----- arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts | 23 +---- arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 23 +---- arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 23 +---- arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 9 +- arch/arm/boot/dts/sun8i-r16-parrot.dts | 12 +-- arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi | 12 +-- drivers/gpio/gpiolib.c | 14 +- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 40 +++--- 44 files changed, 110 insertions(+), 662 deletions(-) base-commit: cf08baa29613dd899954089e7cc7dba1d478b365 -- git-series 0.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel