All of lore.kernel.org
 help / color / mirror / Atom feed
From: "François Legal" <francois.legal@thom.fr.eu.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Greg Gallagher <greg@embeddedgreg.com>, xenomai@xenomai.org
Subject: Re: Bug in xenomai 3.2.x on ARM
Date: Tue, 22 Mar 2022 23:19:25 +0100	[thread overview]
Message-ID: <d01-623a4b80-2b-400dfa00@254398969> (raw)
In-Reply-To: <742b47b4-5a36-c9eb-6446-f7f74584109d@siemens.com>

Le Mardi, Mars 22, 2022 19:57 CET, Jan Kiszka <jan.kiszka@siemens.com> a écrit:

> On 22.03.22 18:31, Greg Gallagher via Xenomai wrote:
> > On Tue, Mar 22, 2022 at 12:49 PM François Legal via Xenomai <
> > xenomai@xenomai.org> wrote:
> >
> >> Hello,
> >>
> >> trying to port a running Xenomai 3.1.x/Linux 4.4.x system to Xenomai
> >> 3.2.x/Linux 4.4.x running on Zynq7000, I found a (maybe) bug in intr.c
> >>
> >> In xnintr_attach, the call to ipipe_set_irq_affinity (when in SMP) expects
> >> a 0 return code. However, on my platform, I end up in irq_gic.c in
> >> gic_set_affinity() which returns IRQ_SET_MASK_OK_DONE (2) when everything
> >> is fine.
> >>
> >> This IRQ_SET_MASK_OK_DONE does not seem very common in the kernel (I could
> >> find a few occurences, on Gic v3 so maybe AARCH64 has the same problem,
> >> plus some PCI devices).
> >>
> >> I was wondering if this was something to fix in ipipe or xenomai ?
> >>
> >> François
> >
> >
> > Do the newer kernels have the same return value? Do we test 3.2.x on the
> > older kernels? Maybe just cip ?
> >
>
> We limited testing to 4.4-cip with 3.0.x. Newer kernels require newer
> Xenomai, and vice versa.
>
> But let's first understand if the issue if 4.4-specific.
>
> Jan
>
> --
> Siemens AG, Technology
> Competence Center Embedded Linux

 In 4.4, gic_set_affinity returns IRQ_SET_MASK_OK (aka 0). In 4.19 is already returns IRQ_SET_MASK_OK_DONE , but in Xenomai 3.1.x, there were no call to ipipe_set_irq_affinity AFAIK.

François



  reply	other threads:[~2022-03-22 22:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 16:48 Bug in xenomai 3.2.x on ARM François Legal
2022-03-22 17:31 ` Greg Gallagher
2022-03-22 18:57   ` Jan Kiszka
2022-03-22 22:19     ` François Legal [this message]
2022-04-14 16:37     ` François Legal
2022-05-20 14:29       ` Gunter Grau
2022-05-20 14:29         ` [PATCH] cobalt: ipipe: intr: Fix return value check of ipipe_set_irq_affinity Gunter Grau
2022-05-20 14:32           ` Grau, Gunter
2022-05-24  7:24           ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d01-623a4b80-2b-400dfa00@254398969 \
    --to=francois.legal@thom.fr.eu.org \
    --cc=greg@embeddedgreg.com \
    --cc=jan.kiszka@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.