From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 200BEC433B4 for ; Fri, 23 Apr 2021 15:01:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E294E61176 for ; Fri, 23 Apr 2021 15:01:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243432AbhDWPCP (ORCPT ); Fri, 23 Apr 2021 11:02:15 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:38722 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243522AbhDWPBr (ORCPT ); Fri, 23 Apr 2021 11:01:47 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: gtucker) with ESMTPSA id C3FCF1F43D22 Subject: Re: [PATCH v1 2/2] iommu/tegra-smmu: Revert workaround that was needed for Nyan Big Chromebook To: Dmitry Osipenko , Nicolin Chen Cc: Thierry Reding , Joerg Roedel , Jonathan Hunter , Krishna Reddy , Will Deacon , iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210328233256.20494-1-digetx@gmail.com> <20210328233256.20494-2-digetx@gmail.com> <20210401085549.GA31146@Asurada-Nvidia> <50a7e4c7-0e72-534a-a317-366e455213c1@gmail.com> From: Guillaume Tucker Message-ID: Date: Fri, 23 Apr 2021 16:01:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <50a7e4c7-0e72-534a-a317-366e455213c1@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 02/04/2021 15:40, Dmitry Osipenko wrote: > 01.04.2021 11:55, Nicolin Chen пишет: >> On Mon, Mar 29, 2021 at 02:32:56AM +0300, Dmitry Osipenko wrote: >>> The previous commit fixes problem where display client was attaching too >>> early to IOMMU during kernel boot in a multi-platform kernel configuration >>> which enables CONFIG_ARM_DMA_USE_IOMMU=y. The workaround that helped to >>> defer the IOMMU attachment for Nyan Big Chromebook isn't needed anymore, >>> revert it. >> >> Sorry for the late reply. I have been busy with downstream tasks. >> >> I will give them a try by the end of the week. Yet, probably it'd >> be better to include Guillaume also as he has the Nyan platform. >> > > Indeed, thanks. Although, I'm pretty sure that it's the same issue which > I reproduced on Nexus 7. > > Guillaume, could you please give a test to these patches on Nyan Big? > There should be no EMEM errors in the kernel log with this patches. > > https://patchwork.ozlabs.org/project/linux-tegra/list/?series=236215 So sorry for the very late reply. I have tried the patches but hit some issues on linux-next, it's not reaching a login prompt with next-20210422. So I then tried with next-20210419 which does boot but shows the IOMMU error: <6>[ 2.995341] tegra-dc 54200000.dc: Adding to iommu group 1 <4>[ 3.001070] Failed to attached device 54200000.dc to IOMMU_mapping https://lava.collabora.co.uk/scheduler/job/3570052#L1120 The branch I'm using with the patches applied can be found here: https://gitlab.collabora.com/gtucker/linux/-/commits/next-20210419-nyan-big-drm-read/ Hope this helps, let me know if you need anything else to be tested. Best wishes, Guillaume From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38AC3C433B4 for ; Fri, 23 Apr 2021 15:01:17 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 929DD61465 for ; Fri, 23 Apr 2021 15:01:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 929DD61465 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 377A740F57; Fri, 23 Apr 2021 15:01:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mB0L43QbpAuw; Fri, 23 Apr 2021 15:01:15 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTP id F40B140F7C; Fri, 23 Apr 2021 15:01:14 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C9BDDC000E; Fri, 23 Apr 2021 15:01:14 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id C8D59C000B for ; Fri, 23 Apr 2021 15:01:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id A20BB4063B for ; Fri, 23 Apr 2021 15:01:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IJ3osXayu9Pz for ; Fri, 23 Apr 2021 15:01:12 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by smtp2.osuosl.org (Postfix) with ESMTPS id 6A48F40610 for ; Fri, 23 Apr 2021 15:01:12 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: gtucker) with ESMTPSA id C3FCF1F43D22 Subject: Re: [PATCH v1 2/2] iommu/tegra-smmu: Revert workaround that was needed for Nyan Big Chromebook To: Dmitry Osipenko , Nicolin Chen References: <20210328233256.20494-1-digetx@gmail.com> <20210328233256.20494-2-digetx@gmail.com> <20210401085549.GA31146@Asurada-Nvidia> <50a7e4c7-0e72-534a-a317-366e455213c1@gmail.com> From: Guillaume Tucker Message-ID: Date: Fri, 23 Apr 2021 16:01:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <50a7e4c7-0e72-534a-a317-366e455213c1@gmail.com> Content-Language: en-US Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jonathan Hunter , Thierry Reding , linux-tegra@vger.kernel.org, Will Deacon X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gMDIvMDQvMjAyMSAxNTo0MCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+IDAxLjA0LjIwMjEg MTE6NTUsIE5pY29saW4gQ2hlbiDQv9C40YjQtdGCOgo+PiBPbiBNb24sIE1hciAyOSwgMjAyMSBh dCAwMjozMjo1NkFNICswMzAwLCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+PiBUaGUgcHJldmlv dXMgY29tbWl0IGZpeGVzIHByb2JsZW0gd2hlcmUgZGlzcGxheSBjbGllbnQgd2FzIGF0dGFjaGlu ZyB0b28KPj4+IGVhcmx5IHRvIElPTU1VIGR1cmluZyBrZXJuZWwgYm9vdCBpbiBhIG11bHRpLXBs YXRmb3JtIGtlcm5lbCBjb25maWd1cmF0aW9uCj4+PiB3aGljaCBlbmFibGVzIENPTkZJR19BUk1f RE1BX1VTRV9JT01NVT15LiBUaGUgd29ya2Fyb3VuZCB0aGF0IGhlbHBlZCB0bwo+Pj4gZGVmZXIg dGhlIElPTU1VIGF0dGFjaG1lbnQgZm9yIE55YW4gQmlnIENocm9tZWJvb2sgaXNuJ3QgbmVlZGVk IGFueW1vcmUsCj4+PiByZXZlcnQgaXQuCj4+Cj4+IFNvcnJ5IGZvciB0aGUgbGF0ZSByZXBseS4g SSBoYXZlIGJlZW4gYnVzeSB3aXRoIGRvd25zdHJlYW0gdGFza3MuCj4+Cj4+IEkgd2lsbCBnaXZl IHRoZW0gYSB0cnkgYnkgdGhlIGVuZCBvZiB0aGUgd2Vlay4gWWV0LCBwcm9iYWJseSBpdCdkCj4+ IGJlIGJldHRlciB0byBpbmNsdWRlIEd1aWxsYXVtZSBhbHNvIGFzIGhlIGhhcyB0aGUgTnlhbiBw bGF0Zm9ybS4KPj4KPiAKPiBJbmRlZWQsIHRoYW5rcy4gQWx0aG91Z2gsIEknbSBwcmV0dHkgc3Vy ZSB0aGF0IGl0J3MgdGhlIHNhbWUgaXNzdWUgd2hpY2gKPiBJIHJlcHJvZHVjZWQgb24gTmV4dXMg Ny4KPiAKPiBHdWlsbGF1bWUsIGNvdWxkIHlvdSBwbGVhc2UgZ2l2ZSBhIHRlc3QgdG8gdGhlc2Ug cGF0Y2hlcyBvbiBOeWFuIEJpZz8KPiBUaGVyZSBzaG91bGQgYmUgbm8gRU1FTSBlcnJvcnMgaW4g dGhlIGtlcm5lbCBsb2cgd2l0aCB0aGlzIHBhdGNoZXMuCj4gCj4gaHR0cHM6Ly9wYXRjaHdvcmsu b3psYWJzLm9yZy9wcm9qZWN0L2xpbnV4LXRlZ3JhL2xpc3QvP3Nlcmllcz0yMzYyMTUKClNvIHNv cnJ5IGZvciB0aGUgdmVyeSBsYXRlIHJlcGx5LiAgSSBoYXZlIHRyaWVkIHRoZSBwYXRjaGVzIGJ1 dApoaXQgc29tZSBpc3N1ZXMgb24gbGludXgtbmV4dCwgaXQncyBub3QgcmVhY2hpbmcgYSBsb2dp biBwcm9tcHQKd2l0aCBuZXh0LTIwMjEwNDIyLiAgU28gSSB0aGVuIHRyaWVkIHdpdGggbmV4dC0y MDIxMDQxOSB3aGljaApkb2VzIGJvb3QgYnV0IHNob3dzIHRoZSBJT01NVSBlcnJvcjoKCjw2Plsg ICAgMi45OTUzNDFdIHRlZ3JhLWRjIDU0MjAwMDAwLmRjOiBBZGRpbmcgdG8gaW9tbXUgZ3JvdXAg MQo8ND5bICAgIDMuMDAxMDcwXSBGYWlsZWQgdG8gYXR0YWNoZWQgZGV2aWNlIDU0MjAwMDAwLmRj IHRvIElPTU1VX21hcHBpbmcgIAoKICBodHRwczovL2xhdmEuY29sbGFib3JhLmNvLnVrL3NjaGVk dWxlci9qb2IvMzU3MDA1MiNMMTEyMAoKVGhlIGJyYW5jaCBJJ20gdXNpbmcgd2l0aCB0aGUgcGF0 Y2hlcyBhcHBsaWVkIGNhbiBiZSBmb3VuZCBoZXJlOgoKICBodHRwczovL2dpdGxhYi5jb2xsYWJv cmEuY29tL2d0dWNrZXIvbGludXgvLS9jb21taXRzL25leHQtMjAyMTA0MTktbnlhbi1iaWctZHJt LXJlYWQvCgpIb3BlIHRoaXMgaGVscHMsIGxldCBtZSBrbm93IGlmIHlvdSBuZWVkIGFueXRoaW5n IGVsc2UgdG8gYmUKdGVzdGVkLgoKQmVzdCB3aXNoZXMsCkd1aWxsYXVtZQpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9t bXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRp b24ub3JnL21haWxtYW4vbGlzdGluZm8vaW9tbXU=