From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v2 1/6] mem: add function for checking memsegs IOVAs addresses Date: Fri, 5 Oct 2018 13:20:45 +0100 Message-ID: References: <1538741212-7922-1-git-send-email-alejandro.lucero@netronome.com> <1538741212-7922-2-git-send-email-alejandro.lucero@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev To: Alejandro Lucero Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C4AAD201 for ; Fri, 5 Oct 2018 14:20:47 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05-Oct-18 1:19 PM, Alejandro Lucero wrote: > > > On Fri, Oct 5, 2018 at 1:15 PM Burakov, Anatoly > > wrote: > > On 05-Oct-18 1:06 PM, Alejandro Lucero wrote: > > A device can suffer addressing limitations. This function checks > > memsegs have iovas within the supported range based on dma mask. > > > > PMDs should use this function during initialization if device > > suffers addressing limitations, returning an error if this function > > returns memsegs out of range. > > > > Another usage is for emulated IOMMU hardware with addressing > > limitations. > > > > It is necessary to save the most restricted dma mask for checking out > > memory allocated dynamically after initialization. > > > > Signed-off-by: Alejandro Lucero > > > --- > > Reviewed-by: Anatoly Burakov > > > > Thanks Anatoly. > > I have just noticed I did not remove the previous keeping of the dma mask. > > I will send another version just with this change and will add you > review if you are happy if I do so. > Sure :) -- Thanks, Anatoly