From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EX13-EDG-OU-002.vmware.com (ex13-edg-ou-002.vmware.com [208.91.0.190]) by gabe.freedesktop.org (Postfix) with ESMTPS id 824F16F2FE for ; Fri, 25 Jan 2019 16:16:28 +0000 (UTC) Message-ID: From: Deepak Singh Rawat Date: Fri, 25 Jan 2019 08:16:52 -0800 In-Reply-To: <20190125145842.15738-6-maxime.ripard@bootlin.com> References: <20190125145842.15738-1-maxime.ripard@bootlin.com> <20190125145842.15738-6-maxime.ripard@bootlin.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v5 05/13] igt: fb: Refactor dumb buffer allocation path List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maxime Ripard , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Thomas Petazzoni , eben@raspberrypi.org List-ID: T24gRnJpLCAyMDE5LTAxLTI1IGF0IDE1OjU4ICswMTAwLCBNYXhpbWUgUmlwYXJkIHdyb3RlOgo+ IFRoZSBlbHNlIGNvbmRpdGlvbiBpcyBub3QgbmVlZGVkLCBzaW5jZSBhbGwgdGhlIG90aGVyIGNv bmRpdGlvbnMKPiByZXR1cm4KPiB3aGVuIHRoZXkgYXJlIGRvbmUuCj4gCj4gTW92ZSB0aGUgS01T IGR1bWIgYnVmZmVyIGFsbG9jYXRpb24gb3V0c2lkZSBvZiB0aGUgb3V0ZXIgZWxzZQo+IGNvbmRp dGlvbiwKPiB0aGlzIHdpbGwgYWxzbyBhbGxvdyB0byBlYXNlIGxhdGVyIGNoYW5nZXMuCj4gCj4g UmV2aWV3ZWQtYnk6IFBhdWwgS29jaWFsa293c2tpIDxwYXVsLmtvY2lhbGtvd3NraUBib290bGlu LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBNYXhpbWUgUmlwYXJkIDxtYXhpbWUucmlwYXJkQGJvb3Rs aW4uY29tPgo+IC0tLQo+ICBsaWIvaWd0X2ZiLmMgfCAyNSArKysrKysrKysrKysrKysrKy0tLS0t LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2ZiLmMgYi9saWIvaWd0X2ZiLmMKPiBpbmRleCBkNjlj M2ZiMmQzOGQuLjI3MGRiOGQ2ZGM5MCAxMDA2NDQKPiAtLS0gYS9saWIvaWd0X2ZiLmMKPiArKysg Yi9saWIvaWd0X2ZiLmMKPiBAQCAtNTU3LDE1ICs1NTcsMjQgQEAgc3RhdGljIGludCBjcmVhdGVf Ym9fZm9yX2ZiKHN0cnVjdCBpZ3RfZmIgKmZiKQo+ICAJCQlpZ3RfcmVxdWlyZShkcml2ZXJfaGFz X2dlbV9hcGkpOwo+ICAJCQlyZXR1cm4gLUVJTlZBTDsKPiAgCQl9Cj4gLQl9IGVsc2Ugewo+IC0J CWZiLT5pc19kdW1iID0gdHJ1ZTsKPiAtCj4gLQkJZmItPmdlbV9oYW5kbGUgPSBrbXN0ZXN0X2R1 bWJfY3JlYXRlKGZkLCBmYi0+d2lkdGgsIGZiLQo+ID5oZWlnaHQsCj4gLQkJCQkJCSAgICAgZmIt PnBsYW5lX2JwcFswXSwKPiAtCQkJCQkJICAgICAmZmItPnN0cmlkZXNbMF0sCj4gJmZiLT5zaXpl KTsKPiAtCj4gLQkJcmV0dXJuIGZiLT5nZW1faGFuZGxlOwo+ICAJfQo+ICsKPiArCS8qCj4gKwkg KiBUaGUgY3VycmVudCBkdW1iIGJ1ZmZlciBhbGxvY2F0aW9uIEFQSSBkb2Vzbid0IHJlYWxseSBh bGxvdwo+IHRvCj4gKwkgKiBzcGVjaWZ5IGEgY3VzdG9tIHNpemUgb3Igc3RyaWRlLiBZZXQgdGhl IGNhbGxlciBpcyBmcmVlIHRvCj4gc3BlY2lmeQo+ICsJICogdGhlbSwgc28gd2UgbmVlZCB0byBt YWtlIHN1cmUgdG8gZXJyb3Igb3V0IGluIHRoaXMgY2FzZS4KPiArCSAqLwo+ICsJaWd0X2Fzc2Vy dChmYi0+c2l6ZSA9PSAwKTsKPiArCWlndF9hc3NlcnQoZmItPnN0cmlkZXNbMF0gPT0gMCk7CgpI aSBNYXhpbWUsIHRoYW5rcyBmb3IgZG9pbmcgdGhpcy4gSSBhbSBub3QgYW4gZXhwZXJ0IGJ1dCBk byB5b3UgdGhpbmsKdGhpcyBzaG91bGQgYmUgaWd0X3NraXAgaW5zdGVhZD8gVGVzdHMgd2lsbCBz aW1wbHkgZmFpbCB3aGVyZSB0aGV5CnNob3VsZCByZWFsbHkgYmUgc2tpcHBpbmcgaWYgZHJpdmVy IGRvbid0IHN1cHBvcnQgdGhlIGZlYXR1cmUuCgo+ICsKPiArCWZiLT5zaXplID0gY2FsY19mYl9z aXplKGZiKTsKPiArCj4gKwlmYi0+aXNfZHVtYiA9IHRydWU7Cj4gKwlmYi0+Z2VtX2hhbmRsZSA9 IGttc3Rlc3RfZHVtYl9jcmVhdGUoZmQsIGZiLT53aWR0aCwgZmItPmhlaWdodCwKPiArCQkJCQkg ICAgIGZiLT5wbGFuZV9icHBbMF0sCj4gKwkJCQkJICAgICAmZmItPnN0cmlkZXNbMF0sICZmYi0K PiA+c2l6ZSk7Cj4gKwo+ICsJcmV0dXJuIGZiLT5nZW1faGFuZGxlOwo+ICB9Cj4gIAo+ICAvKioK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYg bWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=