From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] devtools: check stable tag in fixes Date: Tue, 17 Jan 2017 18:15:06 +0000 Message-ID: References: <1484664872-26859-1-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: Yuanhan Liu To: Thomas Monjalon , dev@dpdk.org Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D27C6DE3 for ; Tue, 17 Jan 2017 19:15:10 +0100 (CET) In-Reply-To: <1484664872-26859-1-git-send-email-thomas.monjalon@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/17/2017 2:54 PM, Thomas Monjalon wrote: > The tag "Cc: stable@dpdk.org" must be set when the commit must be > backported to a stable branch. > > It must be located just below the "Fixes:" tag (without blank line) > and followed by a blank line, separated from SoB and review tags below. I am OK to keep it if it will help stable tree maintenance, but I still not clear about why we need this. If a patch is a fix, it should already have "Fixes:" line, so this can be used to parse git history. If patch is a feature, as far as I know still can go to stable tree, but for this case stable tree maintainer decides this, and author putting "Cc: stable@dpdk.org" tag not so useful. Author can put this tag just for recommendation, but if so why we are saving this into git history? Initially this was to be sure fixes CC'ed to stable mail list, now meaning is changing I guess. For the case author already cc'ed the stable tree but not put Cc: tag into git commit, should committer add this explicitly or ask from author a new version of the patch? Last thing, if this tag will remain in the commit log, is this only for stable tree, or any "Cc: " can stay in the history? > > Signed-off-by: Thomas Monjalon > --- <...>