From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1910C433ED for ; Mon, 10 May 2021 22:19:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4340614A5 for ; Mon, 10 May 2021 22:19:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232082AbhEJWUX (ORCPT ); Mon, 10 May 2021 18:20:23 -0400 Received: from mga02.intel.com ([134.134.136.20]:52294 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231807AbhEJWUU (ORCPT ); Mon, 10 May 2021 18:20:20 -0400 IronPort-SDR: IOLs2pMuMV2FlQhMyFbxacrl45NnJf565KqMVYGXOWQF5k9tfzc3R1VNRbTWns6sJFE1ulOLQl FdGIgOwd9OSQ== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="186434643" X-IronPort-AV: E=Sophos;i="5.82,288,1613462400"; d="scan'208";a="186434643" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 15:19:13 -0700 IronPort-SDR: OwFO49KfvhE+Xw8i3QMr4NJEKXZ6uegf/77SDYWuFvfKNGGoKGAr1tZQxOLN162Sfll5qeh5by 5QtqKWQqGH6g== X-IronPort-AV: E=Sophos;i="5.82,288,1613462400"; d="scan'208";a="609255395" Received: from kcmorris-mobl1.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.213.165.53]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 15:19:13 -0700 Subject: Re: [RFC v2 26/32] x86/mm: Move force_dma_unencrypted() to common code To: Dave Hansen , Peter Zijlstra , Andy Lutomirski , Dan Williams , Tony Luck Cc: Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Raj Ashok , Sean Christopherson , linux-kernel@vger.kernel.org References: <7c5adf75d69ea327b22b404b7c37b29712d73640.1619458733.git.sathyanarayanan.kuppuswamy@linux.intel.com> <5536639a-918d-de8d-ff32-934a13902a03@intel.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: Date: Mon, 10 May 2021 15:19:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <5536639a-918d-de8d-ff32-934a13902a03@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/7/21 2:54 PM, Dave Hansen wrote: > This doesn't seem much like common code to me. It seems like 100% SEV > code. Is this really where we want to move it? Both SEV and TDX code has requirement to enable CONFIG_ARCH_HAS_FORCE_DMA_UNENCRYPTED and define force_dma_unencrypted() function. force_dma_unencrypted() is modified by patch titled "x86/tdx: Make DMA pages shared" to add TDX guest specific support. Since both SEV and TDX code uses it, its moved to common file. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer