From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH] eal: fix compilation without VFIO
Date: Thu, 12 Apr 2018 15:13:22 +0100
Message-ID: <d050d739-50fe-f5e5-eef2-e9781fac82fe@intel.com>
References: <20180412133422.104155-1-shahafs@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Shahaf Shuler <shahafs@mellanox.com>, thomas@monjalon.net
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id A7E641C090
 for <dev@dpdk.org>; Thu, 12 Apr 2018 16:13:27 +0200 (CEST)
In-Reply-To: <20180412133422.104155-1-shahafs@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12-Apr-18 2:34 PM, Shahaf Shuler wrote:
> a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n
> 
> == Build lib/librte_eal/linuxapp/eal
>    CC eal_vfio.o
> /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1535:1: error: no
> previous prototype for 'rte_vfio_dma_map' [-Werror=missing-prototypes]
>   rte_vfio_dma_map(uint64_t __rte_unused vaddr, __rte_unused uint64_t
> iova,
>   ^
> /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1542:1: error: no
> previous prototype for 'rte_vfio_dma_unmap' [-Werror=missing-prototypes]
>   rte_vfio_dma_unmap(uint64_t __rte_unused vaddr, uint64_t __rte_unused
> iova,
>   ^
> 
> As there is no use for those dummy functions without VFIO removing them
> completely.
> 
> Fixes: 73a639085938 ("vfio: allow to map other memory regions")
> Cc: anatoly.burakov@intel.com
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
>   lib/librte_eal/linuxapp/eal/eal_vfio.c | 16 ----------------
>   1 file changed, 16 deletions(-)
> 
> diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linuxapp/eal/eal_vfio.c
> index 589d7d4787..4163bd4e08 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_vfio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c
> @@ -1529,20 +1529,4 @@ rte_vfio_noiommu_is_enabled(void)
>   	return c == 'Y';
>   }
>   
> -#else
> -
> -int __rte_experimental
> -rte_vfio_dma_map(uint64_t __rte_unused vaddr, __rte_unused uint64_t iova,
> -		  __rte_unused uint64_t len)
> -{
> -	return -1;
> -}
> -
> -int __rte_experimental
> -rte_vfio_dma_unmap(uint64_t __rte_unused vaddr, uint64_t __rte_unused iova,
> -		    __rte_unused uint64_t len)
> -{
> -	return -1;
> -}
> -
>   #endif
> 

These functions are part of public API, like rest of functions in this 
header. They're in the map file. Should we perhaps go the BSD way and 
provide EAL with dummy prototypes as well? See bsdapp/eal/eal.c:763 onwards.

-- 
Thanks,
Anatoly