From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D167FC433EF for ; Thu, 10 Feb 2022 14:32:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242970AbiBJOcO (ORCPT ); Thu, 10 Feb 2022 09:32:14 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:46252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236150AbiBJOcO (ORCPT ); Thu, 10 Feb 2022 09:32:14 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53F96BAE for ; Thu, 10 Feb 2022 06:32:14 -0800 (PST) Received: from fraeml708-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4JvfMp09hHz67Wb2; Thu, 10 Feb 2022 22:32:06 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml708-chm.china.huawei.com (10.206.15.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Feb 2022 15:32:12 +0100 Received: from [10.202.227.197] (10.202.227.197) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Feb 2022 14:32:11 +0000 Message-ID: Date: Thu, 10 Feb 2022 14:32:11 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH 07/20] scsi: pm8001: Fix command initialization in pm80XX_send_read_log() To: Damien Le Moal , , "Martin K . Petersen" , Xiang Chen , "Jason Yan" , Luo Jiaxing References: <20220210114218.632725-1-damien.lemoal@opensource.wdc.com> <20220210114218.632725-8-damien.lemoal@opensource.wdc.com> From: John Garry In-Reply-To: <20220210114218.632725-8-damien.lemoal@opensource.wdc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.197] X-ClientProxiedBy: lhreml713-chm.china.huawei.com (10.201.108.64) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 10/02/2022 11:42, Damien Le Moal wrote: > Since the sata_cmd struct is zeroed out before its fields are > initialized, there is no need for using "|=" to initialize the > ncqtag_atap_dir_m field. Using a standard assignment removes the sparse > warning: > > warning: invalid assignment: |= > > Also, since the ncqtag_atap_dir_m field has type __le32, use > cpu_to_le32() to generate the assigned value. > > Fixes: c6b9ef5779c3 ("[SCSI] pm80xx: NCQ error handling changes") > Signed-off-by: Damien Le Moal Reviewed-by: John Garry