From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87AF9C433ED for ; Wed, 14 Apr 2021 11:24:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A7C961164 for ; Wed, 14 Apr 2021 11:24:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350462AbhDNLYk (ORCPT ); Wed, 14 Apr 2021 07:24:40 -0400 Received: from smtpcmd01-sp1.aruba.it ([62.149.158.218]:45732 "EHLO smtpcmd01-sp1.aruba.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350424AbhDNLYg (ORCPT ); Wed, 14 Apr 2021 07:24:36 -0400 Received: from [192.168.126.129] ([146.241.148.6]) by Aruba Outgoing Smtp with ESMTPSA id WdcyllWxJkdBBWdcyl2YpR; Wed, 14 Apr 2021 13:24:12 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1618399452; bh=1QQRifXVR0oTRxBo0DxVJYGcPyQtnZXzwUZ3jWxWIcY=; h=Subject:To:From:Date:MIME-Version:Content-Type; b=b+gWbmOSEwN+GDOsMwEwTRGAgRBBjH8r7SECt2j2u+kZwtTxUcH5f60Kji2jLGbnO vl87sWp9da+o9pf+4H9yKw9MesHx0hnKmcgi3iX+NkaLRU+OG1IFII0UbZ8sBNZpKc ATRUR3ArDNm43X+b/z9Ta4xIJ4KJhDCUT2K6h5OowirDamzVVFD0BYicxRbXXQ1f9y AnO/sNhO+qUrhXfPlEebfZ9or+e288H5J8yq65xj2qOz9ALYiTEyiXr+RZSMM5lJOU blP2iHyUrmpNVD7OjUz19JROoeJHHw1iWHkNCJzThYFu9M3SwW19dLefYw1/OtR8ez /0qfTujDpSSkQ== Subject: Re: [PATCH v7 3/3] Input: add driver for the Hycon HY46XX touchpanel series To: Dmitry Torokhov Cc: Rob Herring , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Henrik Rydberg , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210413144446.2277817-1-giulio.benetti@benettiengineering.com> <20210413144446.2277817-4-giulio.benetti@benettiengineering.com> From: Giulio Benetti Message-ID: Date: Wed, 14 Apr 2021 13:24:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfIHovaEG2odf866I67FeotfeLzP4bSdwkp7WLNi93RSPvdfq0exsyZ7wfUCuPFBehTO6h4l0GRJrDrrHTOyGOdUrrHUJe+F21PILFrqdQFH9dnbrSGd9 tGMTxeCQDfzrjhe5KCeKNjEtMcdRu1nQ/+aWi1zAQotiyNulEge3BtbxQdxWM/UP4JCySf/boexi/lhzCYIewVxlmOTN3/SRxXi0HxemxfB4qNorXEEiSrqG IROUAih0LkRXDTYCXVhaYtuMaEsiPxkDbKambtTYHxiNdf3q4S6sSdIrOPnkKKZFV5yeAMXvkMgiDzRjpdtkxu7v9pp3LIwFIR1ap/psv5MYL4m71LYxh0c7 m1uOtHSqu/Z62nEbHvS3+DemXtyjAVUyqKIa1XrARRONda+b5Lnj0L7Tdho/8gJNQN59k7Yh Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/14/21 7:44 AM, Dmitry Torokhov wrote: > Hi Giulio, > > On Tue, Apr 13, 2021 at 04:44:46PM +0200, Giulio Benetti wrote: >> + >> + input_mt_report_pointer_emulation(tsdata->input, true); > > For touchscreens it does not make much sense to report BTN_DOUBLETAP, > BTN_TRIPLETAP, etc, events (they are really for touchpads), so I changed > this to > > input_mt_report_pointer_emulation(tsdata->input, false); > > to only report ABS_X, ABS_Y, and BTN_TOUCH, and applied. > > Thanks. > Thank you, I've re-tested and it works correctly, I've answered to Peter Hutterer with what I've understood about that. Please correct me if I'm wrong. Thanks a lot for reviewing Best regards -- Giulio Benetti Benetti Engineering sas