From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756091AbeEaS4N (ORCPT ); Thu, 31 May 2018 14:56:13 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:36419 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755955AbeEaS4K (ORCPT ); Thu, 31 May 2018 14:56:10 -0400 X-Google-Smtp-Source: ADUXVKLX2ffX17t6T1EYlK2Ul22rX1+cllcdeOaaK83/6l7nMtmNyegZKbn4cX19birXRLDOyMfp2g== Subject: Re: [PATCH v2 01/21] usb: phy: use match_string() helper To: Andy Shevchenko Cc: Yisheng Xie , Linux Kernel Mailing List , USB , Felipe Balbi , Greg Kroah-Hartman References: <1527765086-19873-1-git-send-email-xieyisheng1@huawei.com> <1527765086-19873-2-git-send-email-xieyisheng1@huawei.com> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Thu, 31 May 2018 21:56:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/31/2018 09:47 PM, Andy Shevchenko wrote: >>> - donot rename err to ret - per Andy >> >> Hm... > >>> - int err, i; > >>> + err = match_string(usbphy_modes, ARRAY_SIZE(usbphy_modes), phy_type); >>> + if (err < 0) >> >> This is one of the few cases when 'err' is not the best name for such a >> variable. I'd prefer to see something like 'match' or even 'rc' or 'ret'... :-) > > Then leaving i would make it? Yes. :-) > I'm okay with either which just not renames err, b/c it's used with > something else in this function. Looking at it again, 'err' seems equally bad for the result of of_property_read_string()... unless the check there is changed to just *if* (err) -- this function never returns positive values, 0 means success, others mean error. MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,01/21] usb: phy: use match_string() helper From: Sergei Shtylyov Message-Id: Date: Thu, 31 May 2018 21:56:06 +0300 To: Andy Shevchenko Cc: Yisheng Xie , Linux Kernel Mailing List , USB , Felipe Balbi , Greg Kroah-Hartman List-ID: T24gMDUvMzEvMjAxOCAwOTo0NyBQTSwgQW5keSBTaGV2Y2hlbmtvIHdyb3RlOgoKPj4+ICAtIGRv bm90IHJlbmFtZSBlcnIgdG8gcmV0ICAtIHBlciBBbmR5Cj4+Cj4+ICAgIEhtLi4uCj4gCj4+PiAt ICAgICBpbnQgZXJyLCBpOwo+IAo+Pj4gKyAgICAgZXJyID0gbWF0Y2hfc3RyaW5nKHVzYnBoeV9t b2RlcywgQVJSQVlfU0laRSh1c2JwaHlfbW9kZXMpLCBwaHlfdHlwZSk7Cj4+PiArICAgICBpZiAo ZXJyIDwgMCkKPj4KPj4gICAgVGhpcyBpcyBvbmUgb2YgdGhlIGZldyBjYXNlcyB3aGVuICdlcnIn IGlzIG5vdCB0aGUgYmVzdCBuYW1lIGZvciBzdWNoIGEKPj4gdmFyaWFibGUuIEknZCBwcmVmZXIg dG8gc2VlIHNvbWV0aGluZyBsaWtlICdtYXRjaCcgb3IgZXZlbiAncmMnIG9yICdyZXQnLi4uIDot KQo+IAo+IFRoZW4gbGVhdmluZyBpIHdvdWxkIG1ha2UgaXQ/CgogICBZZXMuIDotKQoKPiBJJ20g b2theSB3aXRoIGVpdGhlciB3aGljaCBqdXN0IG5vdCByZW5hbWVzIGVyciwgYi9jIGl0J3MgdXNl ZCB3aXRoCj4gc29tZXRoaW5nIGVsc2UgaW4gdGhpcyBmdW5jdGlvbi4KCiAgIExvb2tpbmcgYXQg aXQgYWdhaW4sICdlcnInIHNlZW1zIGVxdWFsbHkgYmFkIGZvciB0aGUgcmVzdWx0IG9mIApvZl9w cm9wZXJ0eV9yZWFkX3N0cmluZygpLi4uIHVubGVzcyB0aGUgY2hlY2sgdGhlcmUgaXMgY2hhbmdl ZCB0byBqdXN0ICppZiogKGVycikgLS0KdGhpcyBmdW5jdGlvbiBuZXZlciByZXR1cm5zIHBvc2l0 aXZlIHZhbHVlcywgMCBtZWFucyBzdWNjZXNzLCBvdGhlcnMgbWVhbiBlcnJvci4KCk1CUiwgU2Vy Z2VpCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5z dWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21v QHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJu ZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK