All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 02/17] ASoC: use snd_soc_dai/component_activity()
Date: Mon, 11 May 2020 15:44:22 -0700	[thread overview]
Message-ID: <d0850429f144f345864776afb59410693abfd33b.camel@linux.intel.com> (raw)
In-Reply-To: <8736879fqa.wl-kuninori.morimoto.gx@renesas.com>

On Mon, 2020-05-11 at 14:56 +0900, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  sound/soc/soc-compress.c |  4 ++--
>  sound/soc/soc-core.c     |  4 ++--
>  sound/soc/soc-dapm.c     |  8 ++++----
>  sound/soc/soc-pcm.c      | 14 +++++++-------
>  4 files changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c
> index def3ae78b4a7..92d70e75a5a4 100644
> --- a/sound/soc/soc-compress.c
> +++ b/sound/soc/soc-compress.c
> @@ -231,10 +231,10 @@ static int soc_compr_free(struct
> snd_compr_stream *cstream)
>  
>  	snd_soc_dai_digital_mute(codec_dai, 1, cstream->direction);
>  
> -	if (!cpu_dai->active)
> +	if (!snd_soc_dai_activity(cpu_dai))
I have a feeling this is probably incorrect. snd_soc_dai_activity()
checks for stream_active count which is different from snd_soc_dai's
active member, isnt it?

Thanks,
Ranjani


  reply	other threads:[~2020-05-12  1:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11  5:55 [PATCH 00/17] ASoC: cleanup DAI/Component activity Kuninori Morimoto
2020-05-11  5:56 ` [PATCH 01/17] ASoC: soc-dai: add snd_soc_dai_activity() Kuninori Morimoto
2020-05-11 22:37   ` Ranjani Sridharan
2020-05-11 22:42   ` Ranjani Sridharan
2020-05-11  5:56 ` [PATCH 02/17] ASoC: use snd_soc_dai/component_activity() Kuninori Morimoto
2020-05-11 22:44   ` Ranjani Sridharan [this message]
2020-05-11 23:53     ` Kuninori Morimoto
2020-05-12  0:55       ` Ranjani Sridharan
2020-05-12  4:06         ` Kuninori Morimoto
2020-05-11  5:56 ` [PATCH 03/17] ASoC: soc-dai: add snd_soc_component_activity() Kuninori Morimoto
2020-05-11 19:07   ` Pierre-Louis Bossart
2020-05-11 22:47   ` Ranjani Sridharan
2020-05-11  5:56 ` [PATCH 04/17] ASoC: atomel: use snd_soc_dai/component_activity() Kuninori Morimoto
2020-05-11  5:56 ` [PATCH 05/17] ASoC: bcm: " Kuninori Morimoto
2020-05-11  5:57 ` [PATCH 06/17] ASoC: cirrus: " Kuninori Morimoto
2020-05-11  5:57 ` [PATCH 07/17] ASoC: codecs: " Kuninori Morimoto
2020-05-11  5:57 ` [PATCH 08/17] ASoC: fsl: " Kuninori Morimoto
2020-05-11  5:57 ` [PATCH 09/17] ASoC: intel: " Kuninori Morimoto
2020-05-11  5:57 ` [PATCH 10/17] ASoC: jz4740: " Kuninori Morimoto
2020-05-11  5:57 ` [PATCH 11/17] ASoC: mediatek: " Kuninori Morimoto
2020-05-11  5:57 ` [PATCH 12/17] ASoC: meson: " Kuninori Morimoto
2020-05-11  5:57 ` [PATCH 13/17] ASoC: pxa: " Kuninori Morimoto
2020-05-11  5:57 ` [PATCH 14/17] ASoC: ti: " Kuninori Morimoto
2020-05-11  5:57 ` [PATCH 15/17] ASoC: uniphier: " Kuninori Morimoto
2020-05-11  5:57 ` [PATCH 16/17] ASoC: cleanup dai / component active code Kuninori Morimoto
2020-05-11  5:58 ` [PATCH 17/17] ASoC: soc-dai: add snd_soc_dai_stream_activity() Kuninori Morimoto
2020-05-11  8:12   ` kbuild test robot
2020-05-11  8:12   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0850429f144f345864776afb59410693abfd33b.camel@linux.intel.com \
    --to=ranjani.sridharan@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.