From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 4/4] drm/i915: enable forcewake voodoo also for gen6
Date: Wed, 08 Feb 2012 10:00:54 +0000 [thread overview]
Message-ID: <d08817$33j9d0@azsmga001.ch.intel.com> (raw)
In-Reply-To: <1327496640-6735-4-git-send-email-daniel.vetter@ffwll.ch>
On Wed, 25 Jan 2012 14:04:00 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> We still have reports of missed irqs even on Sandybridge with the
> HWSTAM workaround in place. Testing by the bug reporter gets rid of
> them with the forcewake voodoo and no HWSTAM writes.
>
> Because I've slightly botched the rebasing I've left out the ACTHD
> readback which is also required to get IVB working. Seems to still
> work on the tester's machine, so I think we should go with the more
> minmal approach on SNB. Especially since I've only found weak evidence
> for holding forcewake while waiting for an interrupt to arrive, but
> none for the ACTHD readback.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45181
> Tested-by: Nicolas Kalkhof nkalkhof()at()web.de
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Whilst this patch doesn't directly enable the ACTHD w/a, I have observed
that with a very light load (drawing a single large transformed texture)
reading back the ACTHD (along with the GT forcewake dance) becomes the
predominant consumer of CPU time for the system. (The rate-limiting step
is still the GPU, it just irked me to see the kernel consume more CPU time
than X.)
This workaround appears more successful than the last, and doesn't
appear to break anything else, so
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-08 10:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 13:03 [PATCH 1/4] drm/i915: outstanding_lazy_request is a u32 Daniel Vetter
2012-01-25 13:03 ` [PATCH 2/4] drm/i915: fixup seqno allocation logic for lazy_request Daniel Vetter
2012-01-25 14:17 ` Chris Wilson
2012-01-25 15:32 ` [PATCH] " Daniel Vetter
2012-01-25 15:46 ` Chris Wilson
2012-01-26 13:55 ` Daniel Vetter
2012-01-25 13:03 ` [PATCH 3/4] drm/i915: adjust ring->add_request to no longer pass back the seqno Daniel Vetter
2012-01-25 15:33 ` [PATCH] " Daniel Vetter
2012-01-25 13:04 ` [PATCH 4/4] drm/i915: enable forcewake voodoo also for gen6 Daniel Vetter
2012-01-30 22:33 ` Daniel Vetter
2012-02-08 10:00 ` Chris Wilson [this message]
2012-02-13 10:00 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='d08817$33j9d0@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.