From: "yangx.jy@fujitsu.com" <yangx.jy@fujitsu.com>
To: Bob Pearson <rpearsonhpe@gmail.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: Fwd: [PATCH for-next] RDMA/rxe: Remove reliable datagram support
Date: Fri, 8 Apr 2022 03:38:13 +0000 [thread overview]
Message-ID: <d089e634-742d-210f-5a5d-dcc142cff5f1@fujitsu.com> (raw)
In-Reply-To: <cce0f07d-25fc-5880-69e7-001d951750b7@gmail.com>
On 2022/4/8 5:04, Bob Pearson wrote:
>
>
>
> -------- Forwarded Message --------
> Subject: [PATCH for-next] RDMA/rxe: Remove reliable datagram support
> Date: Thu, 7 Apr 2022 14:05:23 -0500
> From: Bob Pearson <rpearsonhpe@gmail.com>
> To: jgg@nvidia.com, zyjzyj2000@gmail.com, linux-rdma@vger.kerne.org
> CC: Bob Pearson <rpearsonhpe@gmail.com>
>
> The rdma_rxe driver does not actually support the reliable datagram transport
> but contains two references to RD opcodes in driver code.
> This commit removes these references to RD transport opcodes which
> are never used.
Hi Bob,
Agreed. It looks good to me. ^_^
Best Regards,
Xiao Yang
>
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> ---
> drivers/infiniband/sw/rxe/rxe_req.c | 3 +--
> drivers/infiniband/sw/rxe/rxe_resp.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
> index 52c1d8ff6e5b..5f7348b11268 100644
> --- a/drivers/infiniband/sw/rxe/rxe_req.c
> +++ b/drivers/infiniband/sw/rxe/rxe_req.c
> @@ -413,8 +413,7 @@ static struct sk_buff *init_req_packet(struct rxe_qp *qp,
>
> if (pkt->mask & RXE_ATMETH_MASK) {
> atmeth_set_va(pkt, wqe->iova);
> - if (opcode == IB_OPCODE_RC_COMPARE_SWAP ||
> - opcode == IB_OPCODE_RD_COMPARE_SWAP) {
> + if (opcode == IB_OPCODE_RC_COMPARE_SWAP) {
> atmeth_set_swap_add(pkt, ibwr->wr.atomic.swap);
> atmeth_set_comp(pkt, ibwr->wr.atomic.compare_add);
> } else {
> diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c
> index 9dc38f7c990b..e2653a8721fe 100644
> --- a/drivers/infiniband/sw/rxe/rxe_resp.c
> +++ b/drivers/infiniband/sw/rxe/rxe_resp.c
> @@ -576,8 +576,7 @@ static enum resp_states process_atomic(struct rxe_qp *qp,
>
> qp->resp.atomic_orig = *vaddr;
>
> - if (pkt->opcode == IB_OPCODE_RC_COMPARE_SWAP ||
> - pkt->opcode == IB_OPCODE_RD_COMPARE_SWAP) {
> + if (pkt->opcode == IB_OPCODE_RC_COMPARE_SWAP) {
> if (*vaddr == atmeth_comp(pkt))
> *vaddr = atmeth_swap_add(pkt);
> } else {
next prev parent reply other threads:[~2022-04-08 3:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220407190522.19326-1-rpearsonhpe@gmail.com>
2022-04-07 21:04 ` Fwd: [PATCH for-next] RDMA/rxe: Remove reliable datagram support Bob Pearson
2022-04-08 3:38 ` yangx.jy [this message]
2022-04-08 17:43 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d089e634-742d-210f-5a5d-dcc142cff5f1@fujitsu.com \
--to=yangx.jy@fujitsu.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.