From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4DA6C433F5 for ; Fri, 13 May 2022 03:14:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358713AbiEMDOP (ORCPT ); Thu, 12 May 2022 23:14:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232946AbiEMDOL (ORCPT ); Thu, 12 May 2022 23:14:11 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFB5828F1FA for ; Thu, 12 May 2022 20:14:09 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KztyT6fKjzgZ0Y; Fri, 13 May 2022 11:13:37 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 13 May 2022 11:14:07 +0800 Subject: Re: [PATCH v3 1/3] mm/swapfile: unuse_pte can map random data if swap read fails To: Andrew Morton CC: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBICjloIDlj6Mg55u05LmfKQ==?= , "willy@infradead.org" , "vbabka@suse.cz" , "dhowells@redhat.com" , "neilb@suse.de" , "david@redhat.com" , "apopple@nvidia.com" , "surenb@google.com" , "minchan@kernel.org" , "peterx@redhat.com" , "sfr@canb.auug.org.au" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: <20220424091105.48374-1-linmiaohe@huawei.com> <20220424091105.48374-2-linmiaohe@huawei.com> <20220510061712.GA162496@hori.linux.bs1.fc.nec.co.jp> <2a95aebe-3a00-4699-12d4-fc5d934dde2c@huawei.com> <20220512174247.c4e178334879fb6b10134c2c@linux-foundation.org> From: Miaohe Lin Message-ID: Date: Fri, 13 May 2022 11:14:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220512174247.c4e178334879fb6b10134c2c@linux-foundation.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/5/13 8:42, Andrew Morton wrote: > On Tue, 10 May 2022 14:58:05 +0800 Miaohe Lin wrote: > >>>> Signed-off-by: Miaohe Lin >>>> Acked-by: David Hildenbrand >>> >>> When I reproduced the issue (generated read error with dm-dust), I saw >>> infinite loop in the while loop in shmem_unuse_inode() (and this happens >>> even with this patch). I confirmed that shmem_swapin_page() returns -EIO, >>> but shmem_unuse_swap_entries() does not return the error to the callers, >>> so the while loop in shmem_unuse_inode() seems not break. >>> >> >> Many thanks for your report! I didn't test the shmem case because I saw -EIO >> is returned. So I just focus on the normal page case. Sorry about it. :( >> >>> So maybe you need more code around shmem_unuse_inode() to handle the error? >> >> I will try to reproduce it and come up a fixup patch asap! And if you like, you >> can kindly solve this issue too. ;) > > Seems that this patch didn't cause the infinite loop, so as far as I > can tell it is good to be merged up. But the problem it solves isn't > urgent and fixing that infinite loop might impact this change so I > think I'll drop this version. I will update and resend the corresponding patch series when I fix this infinite loop. Thanks! > . >