From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753623AbdLMQOK (ORCPT ); Wed, 13 Dec 2017 11:14:10 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:43628 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753587AbdLMQOE (ORCPT ); Wed, 13 Dec 2017 11:14:04 -0500 X-Google-Smtp-Source: ACJfBos6qZ4uTI/Bn6ccnoyMUcb5WFr9sQ9ePZWKzR9L7LWujWxyfRqRIduLUsYh/q8ODZ7gcsIR8Q== Subject: Re: [PATCH v4 net-next 4/4] bpftool: implement cgroup bpf operations To: Roman Gushchin , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, ast@kernel.org, daniel@iogearbox.net, jakub.kicinski@netronome.com, kafai@fb.com, Quentin Monnet References: <20171213151854.21960-1-guro@fb.com> <20171213151854.21960-5-guro@fb.com> From: David Ahern Message-ID: Date: Wed, 13 Dec 2017 09:13:59 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171213151854.21960-5-guro@fb.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/13/17 8:18 AM, Roman Gushchin wrote: > This patch adds basic cgroup bpf operations to bpftool: > cgroup list, attach and detach commands. > > Usage is described in the corresponding man pages, > and examples are provided. > > Syntax: > $ bpftool cgroup list CGROUP > $ bpftool cgroup attach CGROUP ATTACH_TYPE PROG [ATTACH_FLAGS] > $ bpftool cgroup detach CGROUP ATTACH_TYPE PROG > > Signed-off-by: Roman Gushchin > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: Jakub Kicinski > Cc: Martin KaFai Lau > Cc: Quentin Monnet > Reviewed-by: David Ahern > --- The updates for attach flags and man page look great. Very user friendly. Thanks for the work on it.