From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63C4BC352A1 for ; Wed, 5 Feb 2020 22:49:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3200A214AF for ; Wed, 5 Feb 2020 22:49:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bWG2Inw2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3200A214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izTUM-0006Da-DO for qemu-devel@archiver.kernel.org; Wed, 05 Feb 2020 17:49:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59426) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izTT9-0005I3-PI for qemu-devel@nongnu.org; Wed, 05 Feb 2020 17:48:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izTT8-0003Jb-Og for qemu-devel@nongnu.org; Wed, 05 Feb 2020 17:48:27 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:50073 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1izTT8-0003J4-Kn for qemu-devel@nongnu.org; Wed, 05 Feb 2020 17:48:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580942906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oaBwiqE0jYhx9ejXvAYgRVxpl96GJsqL3/ZZudtTqFc=; b=bWG2Inw2BtWPFhDdcMff85klgLH7RsD8Ta1s42aEaCjXZ6YET2ub7lZpsg9lO88Nsn2srn sj+w1w80LJ0oVGXuR9Rzns+bvNJ8qT4h0fMIO/4hAKY8ovq6QxJChhnpyqE1lZ2cxDyuo8 UmlCzQdQ8ass8s69IwYDWf9UYOMs3T0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-375-hSs_hcOINeicPKe6N6lT8A-1; Wed, 05 Feb 2020 17:48:22 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 625C4DB22; Wed, 5 Feb 2020 22:48:21 +0000 (UTC) Received: from [10.3.116.181] (ovpn-116-181.phx2.redhat.com [10.3.116.181]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F0FAA5D9E2; Wed, 5 Feb 2020 22:48:20 +0000 (UTC) Subject: Re: [PATCH v2 23/33] block: Drop child_backing To: Max Reitz , qemu-block@nongnu.org References: <20200204170848.614480-1-mreitz@redhat.com> <20200204170848.614480-24-mreitz@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Wed, 5 Feb 2020 16:48:20 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200204170848.614480-24-mreitz@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: hSs_hcOINeicPKe6N6lT8A-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/4/20 11:08 AM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > block.c | 62 +++------------------------------------ > include/block/block_int.h | 1 - > 2 files changed, 4 insertions(+), 59 deletions(-) More code deletion. > > diff --git a/block.c b/block.c > index 6b705ee23a..e245b5d8d9 100644 > --- a/block.c > +++ b/block.c > @@ -1169,15 +1169,6 @@ static void bdrv_backing_attach(BdrvChild *c) > parent->backing_blocker); > } > > -/* XXX: Will be removed along with child_backing */ > -static void bdrv_child_cb_attach_backing(BdrvChild *c) In fact, more promised code deletion :) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org