From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: [PATCH 2 of 2] x86/numa: Remove warning about small NUMA nodes Date: Wed, 11 Jul 2012 13:49:56 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1894051389503318797==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: dario.faggioli@citrix.com, keir@xen.org, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org --===============1894051389503318797== Content-Type: text/x-patch; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="numa-remove-warning.patch" This logic came with the other NUMA logic from Linux 2.6.16 in c/s 11893:f312c2d01d8b. It appears that the Xen memory management subsystem does not suffer from the expressed problems. Furthermore, NUMA nodes with no memory are now quite easy to find, and are not BIOS bugs in the SRAT ACPI table. Signed-off-by: Andrew Cooper diff -r a2dbed3582e5 -r d099f26f6e99 xen/arch/x86/srat.c --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -34,9 +34,6 @@ static int num_node_memblks; static struct node node_memblk_range[NR_NODE_MEMBLKS]; static int memblk_nodeid[NR_NODE_MEMBLKS]; -/* Too small nodes confuse the VM badly. Usually they result - from BIOS bugs. */ -#define NODE_MIN_SIZE (4*1024*1024) static int node_to_pxm(int n); @@ -454,10 +451,6 @@ int __init acpi_scan_nodes(u64 start, u6 printk(KERN_WARNING "SRAT: Node %u has no memory. " "BIOS Bug or mis-configured hardware?\n", i); - else if (size < NODE_MIN_SIZE) - printk(KERN_WARNING "SRAT: Node %u has only %"PRIu64 - " bytes of memory. BIOS Bug?\n", i, size); - setup_node_bootmem(i, nodes[i].start, nodes[i].end); } for (i = 0; i < nr_cpu_ids; i++) { --===============1894051389503318797== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1894051389503318797==--