All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Edward Cree <ecree.xilinx@gmail.com>,
	Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	hv90@scarletmail.rutgers.edu
Cc: Alexei Starovoitov <ast@kernel.org>, bpf <bpf@vger.kernel.org>,
	Harishankar Vishwanathan <harishankar.vishwanathan@rutgers.edu>,
	Matan Shachnai <m.shachnai@rutgers.edu>,
	Srinivas Narayana <srinivas.narayana@rutgers.edu>,
	Santosh Nagarakatte <santosh.nagarakatte@rutgers.edu>
Subject: Re: [PATCH bpf-next] bpf: tnums: Provably sound, faster, and more precise algorithm for tnum_mul
Date: Tue, 1 Jun 2021 11:41:27 +0200	[thread overview]
Message-ID: <d0a2f2f4-b0fe-76ba-8af4-b4c734f4be5d@iogearbox.net> (raw)
In-Reply-To: <a4da47de-daf8-e167-a796-83bd4167341b@gmail.com>

On 6/1/21 10:11 AM, Edward Cree wrote:
> On 30/05/2021 06:59, Andrii Nakryiko wrote:
>> I think your algorithm makes sense, but I've also CC'ed original
>> author of tnum logic. Edward, please take a look as well.Yep, I've been in discussions with them about the paper and their
>   algorithm appears fine to me.  As for the patch, nothing to add
>   beyond your observations.

SGTM, Edward, okay to add your Acked-by or Reviewed-by in that case when applying v2 [0]?

Thanks,
Daniel

   [0] https://patchwork.kernel.org/project/netdevbpf/patch/20210531020157.7386-1-harishankar.vishwanathan@rutgers.edu/

      reply	other threads:[~2021-06-01  9:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28  3:55 [PATCH bpf-next] bpf: tnums: Provably sound, faster, and more precise algorithm for tnum_mul hv90
2021-05-30  5:59 ` Andrii Nakryiko
2021-05-30 23:05   ` HARISHANKAR VISHWANATHAN
2021-06-01  8:11   ` Edward Cree
2021-06-01  9:41     ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0a2f2f4-b0fe-76ba-8af4-b4c734f4be5d@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=andrii.nakryiko@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=ecree.xilinx@gmail.com \
    --cc=harishankar.vishwanathan@rutgers.edu \
    --cc=hv90@scarletmail.rutgers.edu \
    --cc=m.shachnai@rutgers.edu \
    --cc=santosh.nagarakatte@rutgers.edu \
    --cc=srinivas.narayana@rutgers.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.